Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD #11768] Navigating Back takes the user to the home screen on the web - reported by @parasharrajat #10506

Closed
mvtglobally opened this issue Aug 24, 2022 · 39 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Monthly KSv2 Planning Changes still in the thought process
Projects

Comments

@mvtglobally
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Open the app from the home URL (https://staging.new.expensify.com/).
  2. Opening a new Chat from RHN (SearchPage)
  3. Navigate to another chat from RHN (SearchPage).
  4. Go Back.

Expected Result:

The user should not leave the app.

Actual Result:

User is taken out of the app.

Workaround:

unknown

Platform:

Where is this issue occurring?

  • Web

Version Number: 1.1.88-10
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
Issue reported by: @parasharrajat
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1659433336320769

View all open jobs on GitHub

@mvtglobally mvtglobally added AutoAssignerTriage Auto assign issues for triage to an available triage team member Daily KSv2 labels Aug 24, 2022
@melvin-bot
Copy link

melvin-bot bot commented Aug 24, 2022

Triggered auto assignment to @conorpendergrast (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

@Beamanator
Copy link
Contributor

This looks like almost an exact duplicate of #10507 - I think we can close this since #10507 has more details

@parasharrajat
Copy link
Member

This is different based on the Reproduction steps. Both have different navigation actions. I mentioned that on slack.

@melvin-bot
Copy link

melvin-bot bot commented Aug 25, 2022

Looks like something related to react-navigation may have been mentioned in this issue discussion.

As a reminder, please make sure that all proposals are not workarounds and that any and all attempt to fix the issue holistically have been made before proceeding with a solution. Proposals to change our DeprecatedCustomActions.js files should not be accepted.

Feel free to drop a note in #expensify-open-source with any questions.

@marcaaron marcaaron added Engineering Planning Changes still in the thought process labels Aug 25, 2022
@marcaaron marcaaron changed the title Navigating Back takes the user to the home screen on the web - reported by @parasharrajat [HOLD] Navigating Back takes the user to the home screen on the web - reported by @parasharrajat Aug 25, 2022
@marcaaron marcaaron added this to HOLD in Navigation Aug 25, 2022
@marcaaron
Copy link
Contributor

Putting this one on HOLD.

@marcaaron
Copy link
Contributor

Let's leave it open for now we won't be accepting any proposals just yet. Agree it seems similar to the other issue, but it's good to have the different test cases.

@melvin-bot
Copy link

melvin-bot bot commented Aug 29, 2022

Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@melvin-bot melvin-bot bot added the Overdue label Aug 29, 2022
@melvin-bot
Copy link

melvin-bot bot commented Aug 31, 2022

Huh... This is 4 days overdue. Who can take care of this?

@melvin-bot
Copy link

melvin-bot bot commented Sep 2, 2022

6 days overdue. This is scarier than being forced to listen to Vogon poetry!

@melvin-bot
Copy link

melvin-bot bot commented Sep 6, 2022

10 days overdue. I'm getting more depressed than Marvin.

@parasharrajat
Copy link
Member

On Hold.

@melvin-bot
Copy link

melvin-bot bot commented Sep 8, 2022

12 days overdue now... This issue's end is nigh!

@Beamanator
Copy link
Contributor

Not overdue, will demote to weekly

@melvin-bot melvin-bot bot removed the Overdue label Sep 8, 2022
@Beamanator Beamanator added Weekly KSv2 and removed Daily KSv2 labels Sep 8, 2022
@melvin-bot melvin-bot bot added Monthly KSv2 and removed Weekly KSv2 labels Oct 3, 2022
@JmillsExpensify
Copy link

Still on hold for navigation.

@JmillsExpensify JmillsExpensify added Monthly KSv2 and removed Weekly KSv2 labels Dec 19, 2022
@JmillsExpensify
Copy link

Still on hold for navigation. No ETA.

@melvin-bot melvin-bot bot added the Overdue label Feb 13, 2023
@JmillsExpensify
Copy link

Same same

@melvin-bot melvin-bot bot removed the Overdue label Feb 14, 2023
@melvin-bot melvin-bot bot added the Overdue label Mar 17, 2023
@JmillsExpensify
Copy link

Still on hold.

@melvin-bot melvin-bot bot removed the Overdue label Mar 29, 2023
@melvin-bot melvin-bot bot added the Overdue label May 1, 2023
@JmillsExpensify
Copy link

Still on hold

@melvin-bot melvin-bot bot removed the Overdue label May 3, 2023
@melvin-bot melvin-bot bot added the Overdue label Jun 5, 2023
@JmillsExpensify
Copy link

Coming off hold very soon!

@melvin-bot melvin-bot bot removed the Overdue label Jun 7, 2023
@melvin-bot melvin-bot bot added the Overdue label Jul 10, 2023
@JmillsExpensify
Copy link

Working on testing this week.

@melvin-bot melvin-bot bot removed the Overdue label Jul 12, 2023
@melvin-bot melvin-bot bot added the Overdue label Aug 14, 2023
@JmillsExpensify
Copy link

Still trying to make time. Low priority.

@melvin-bot melvin-bot bot removed the Overdue label Aug 16, 2023
@melvin-bot melvin-bot bot added the Overdue label Sep 18, 2023
@JmillsExpensify
Copy link

The user should not leave the app.

Re-tested and I can confirm this no longer happens.

@melvin-bot melvin-bot bot removed the Overdue label Oct 10, 2023
@JmillsExpensify
Copy link

Payout summary: $250 to @parasharrajat for issue reporting

@JmillsExpensify
Copy link

I'm going to close this issue, though please make sure to send a request via NewDot!

@parasharrajat
Copy link
Member

Payment requested as per #10506 (comment)

@JmillsExpensify
Copy link

$250 payment approved for @parasharrajat based on summary above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Monthly KSv2 Planning Changes still in the thought process
Projects
Development

No branches or pull requests

7 participants