Investigate: 💥 Crash 💥 com.horcrux.svg.SVGLength.<init>

[melvin-bot]

Firebase has reported a new crash that we need to fix, here are all the details we found:

Fatal Exception: java.lang.NullPointerException

Attempt to invoke virtual method 'java.lang.String java.lang.String.trim()' on a null object reference

SVGLength.java line 37 com.horcrux.svg.SVGLength.<init>

Number of Crashes: 20

Device Information

• Platforms: Android
• App Versions: 1.1.96-0
• Devices: Google Pixel 3 12

Stacktraces

Android 1.1.96-0

com.horcrux.svg.SVGLength.<init> (SVGLength.java:37)
com.horcrux.svg.SVGLength.from (SVGLength.java:107)
com.horcrux.svg.LinearGradientView.setX1 (LinearGradientView.java:50)
com.horcrux.svg.RenderableViewManager$LinearGradientManager.setX1 (RenderableViewManager.java:1806)
com.horcrux.svg.RenderableViewManager$LinearGradientManager.setX1 (RenderableViewManager.java:1770)
com.facebook.react.viewmanagers.RNSVGLinearGradientManagerDelegate.setProperty (RNSVGLinearGradientManagerDelegate.java:59)
com.facebook.react.uimanager.ViewManagerPropertyUpdater.updateProps (ViewManagerPropertyUpdater.java:46)
com.facebook.react.uimanager.ViewManager.updateProperties (ViewManager.java:46)
com.facebook.react.uimanager.NativeViewHierarchyManager.updateProperties (NativeViewHierarchyManager.java:142)
com.facebook.react.uimanager.UIImplementation.synchronouslyUpdateViewOnUIThread (UIImplementation.java:305)
com.facebook.react.uimanager.UIManagerModule.synchronouslyUpdateViewOnUIThread (UIManagerModule.java:400)
com.facebook.react.animated.PropsAnimatedNode.restoreDefaultValues (PropsAnimatedNode.java:90)
com.facebook.react.animated.NativeAnimatedNodesManager.restoreDefaultValues (NativeAnimatedNodesManager.java:470)
com.facebook.react.animated.NativeAnimatedModule$20.execute (NativeAnimatedModule.java:866)
com.facebook.react.animated.NativeAnimatedModule$ConcurrentOperationQueue.executeBatch (NativeAnimatedModule.java:147)
com.facebook.react.animated.NativeAnimatedModule$2.execute (NativeAnimatedModule.java:324)
com.facebook.react.uimanager.UIViewOperationQueue$UIBlockOperation.execute (UIViewOperationQueue.java:579)
com.facebook.react.uimanager.UIViewOperationQueue$1.run (UIViewOperationQueue.java:915)
com.facebook.react.uimanager.UIViewOperationQueue.flushPendingBatches (UIViewOperationQueue.java:1026)
com.facebook.react.uimanager.UIViewOperationQueue.access$2600 (UIViewOperationQueue.java:47)
com.facebook.react.uimanager.UIViewOperationQueue$DispatchUIFrameCallback.doFrameGuarded (UIViewOperationQueue.java:1086)
com.facebook.react.uimanager.GuardedFrameCallback.doFrame (GuardedFrameCallback.java:29)
com.facebook.react.modules.core.ReactChoreographer$ReactChoreographerDispatcher.doFrame (ReactChoreographer.java:175)
com.facebook.react.modules.core.ChoreographerCompat$FrameCallback$1.doFrame (ChoreographerCompat.java:85)
android.view.Choreographer$CallbackRecord.run (Choreographer.java:1035)
android.view.Choreographer.doCallbacks (Choreographer.java:845)
android.view.Choreographer.doFrame (Choreographer.java:775)
android.view.Choreographer$FrameDisplayEventReceiver.run (Choreographer.java:1022)
android.os.Handler.handleCallback (Handler.java:938)
android.os.Handler.dispatchMessage (Handler.java:99)
android.os.Looper.loopOnce (Looper.java:201)
android.os.Looper.loop (Looper.java:288)
android.app.ActivityThread.main (ActivityThread.java:7842)
java.lang.reflect.Method.invoke
com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run (RuntimeInit.java:548)
com.android.internal.os.ZygoteInit.main (ZygoteInit.java:1003)

---

Internal Firebase Info

💥 DO NOT EDIT THIS SECTION 💥

Crash IDs: c829986edd9dbc0c3a548342190f4600
Exception: Attempt to invoke virtual method 'java.lang.String java.lang.String.trim()' on a null object reference

[melvin-bot]

Triggered auto assignment to @laurenreidexpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[parasharrajat]

Do not make it external. This is a crash from #10334 so technically a regression.

cc: @mateusbra

I faced this issue during review only once so I thought it is just a cache issue but it seems it is real.

[melvin-bot]

Triggered auto assignment to @mountiny (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[mountiny]

@parasharrajat Why could this not be External?

[parasharrajat]

I am considering it as a regression for now.

[mountiny]

Ok I see, so this is coming from Staging, should this be a deploy blocker in your opinion? @parasharrajat seems like this package version is only in staging

@mateusbra Would you be able to look ad this? We could revert in case this is causing more substantial issues.

[parasharrajat]

I don't this is affecting Production. This is QA passed. In fact, I only faced it once while reviewing the PR. It may be caching issue.

[mateusbra]

I'll investigate it, do you have a reprodution steps for this issue?

[AndrewGable]

Reproduction steps are here: #10757

[parasharrajat]

Let's revert that PR and only upgrad a minor version.

[AndrewGable]

Closed via #10775, let's bring further discussion to #10221

[melvin-bot]

This crash occurred again and has not been fully fixed, reopening issue 🔄

[mountiny]

This is not coming from the latest staging app