-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2022-10-12] [$250] Upgrade react-native-svg
package to the latest version
#10221
Comments
Current assignee @trjExpensify is eligible for the External assigner, not assigning anyone new. |
Triggered auto assignment to @AndrewGable ( |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat ( |
Current assignee @AndrewGable is eligible for the Exported assigner, not assigning anyone new. |
react-native-svg
package to the latest version react-native-svg
package to the latest version
PROPOSALWe need to upgrade the version of Line 105 in 28778a0
to: "react-native-svg": "^12.4.3", I tested |
@mateusbra Looks good. These things need to be tested and verified on the PR.
cc: @AndrewGable 🎀 👀 🎀 C+ reviewed |
Bump @AndrewGable. |
Thanks for bump, looks good. |
📣 @mateusbra You have been assigned to this job by @AndrewGable! |
Sweet! @mateusbra & @parasharrajat can you both apply to the Upwork job here, please? |
@mateusbra When can we expect the PR? |
Waiting on some input from @AndrewGable - who's back on Monday! |
^^ no change since Friday melv, jeez! |
How can we get this one unblocked as it has stalled in review. @AndrewGable, are you able to take a look please? |
I need someone from the internal team to review the vulnerability status that we are trying to fix on that PR. I do not have access to Synk so I can't do that. PR is looking good but there is no use for my approval if the PR does not serve the purpose for what it is created. |
The vulnerability fix is in
|
Ok. Thanks |
@AndrewGable, @trjExpensify, @parasharrajat, @mateusbra Whoops! This issue is 2 days overdue. Let's get this updated quick! |
Not overdue, the PR has merged awaiting a deploy to prod. |
react-native-svg
package to the latest version react-native-svg
package to the latest version
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.11-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2022-10-12. 🎊 |
Waiting payment |
Hm, that's annoying. I didn't think Upwork closed jobs with hires. 🤔 New job is here and I've sent offers to both @parasharrajat & @mateusbra. |
@mateusbra - paid! |
@parasharrajat - paid! |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
(Internal reference) CC: @flodnv @joelbettner
Upwork job URL: https://www.upwork.com/jobs/~014e2ad669b286cdd1
For the proposal it would be good to see:
The text was updated successfully, but these errors were encountered: