Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Desktop/ Web- Production server is displayed even if the staging server is enabled #10970

Closed
kavimuru opened this issue Sep 13, 2022 · 6 comments
Assignees

Comments

@kavimuru
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Issue found when executing #10935

Action Performed:

  1. Open app on web
  2. Go to Settings -> Preference
  3. Use staging server is toggled ON
  4. Open dev tool
  5. Go to Network tab.
  6. Focus on app and send some message.

Expected Result:

Verify that the request in Fetch/XHR is of staging server https://staging.expensify.com/

Actual Result:

The request shows always production server

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • Web
  • Desktop App

Version Number: 1.2.0-0
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:
https://user-images.githubusercontent.com/43996225/189965104-49b6c59b-2564-47e5-932d-280b22a3e69b.mp4
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

View all open jobs on GitHub

@melvin-bot
Copy link

melvin-bot bot commented Sep 13, 2022

Triggered auto assignment to @Luke9389 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@Luke9389
Copy link
Contributor

Hmm, I don't see how to enable the staging server on web. Is this an error in the issue description @kavimuru?

@francoisl
Copy link
Contributor

francoisl commented Sep 13, 2022

Hmm confused by this one, #10690 and #10935 are the same PR, and the former was reverted in #10920

#10935 should be included in 1.2.0.0, but somehow it doesn't seem to be. Still looking.

cc @mdneyazahmad @mountiny if you have any additional context.

@mountiny
Copy link
Contributor

This is a problem with our GH CD/CI which we encountered already once before. Discussing in Slack here

@francoisl
Copy link
Contributor

This should be fixed now, waiting for Applause to finish testing #10935 again.

@mountiny
Copy link
Contributor

It was checked off by Applause, closing #10958 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants