[HOLD for payment 2022-12-22][$500] Bug: Old dot link without ‘www.’ prefix ( expensify.com/inbox) does not auto signin to old dot reported by @sobitneupane

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Login to new dot expensify.
2. Send old dot link without ‘www.’ prefix (example: expensify.com/inbox)
3. Press the link.

Expected Result:

You are automatically signed in to old dot.

Actual Result:

You are prompted to enter password.

Workaround:

unknown

Platform:

Where is this issue occurring?

• Web
• iOS
• Android
• Desktop App
• Mobile Web

Version Number: 1.2.14
Reproducible in staging?: y
Reproducible in production?: y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Screen.Recording.2022-10-12.at.15.35.11.mov

Expensify/Expensify Issue URL:
Issue reported by: @sobitneupane
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1665568331616469

View all open jobs on GitHub

Recording.686.mp4

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~011559e465b3832421
• Upwork Job ID: 1603853910330884096
• Last Price Increase: 2022-12-23

[melvin-bot]

Triggered auto assignment to @conorpendergrast (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

[melvin-bot]

@conorpendergrast Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

Triggered auto assignment to @sakluger (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

[conorpendergrast]

Didn't get to this before I went OoO, reassigning!

[sakluger]

Reproduced in prod in an incognito window.

[melvin-bot]

Triggered auto assignment to @MonilBhavsar (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[melvin-bot]

@MonilBhavsar Huh... This is 4 days overdue. Who can take care of this?

[melvin-bot]

@MonilBhavsar 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[melvin-bot]

Triggered auto assignment to @CortneyOfstad (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[sonialiap]

@tienifr please apply for this job:

https://www.upwork.com/jobs/~01af93adacf3d34f62

@parasharrajat I believe I found your profile on Upwork and invited you to the job, offer sent :)
EDIT: Rajat has been paid

[tienifr]

Thanks @sonialiap

I would also request a bonus for @tienifr because it required working on multiple PRs and we asked them to create a more generalized solution. cc: @MonilBhavsar

@MonilBhavsar @parasharrajat I'd like to confirm on the bonus mentioned here

This issue requires many PRs, a generalized solution, with 70+ lines of code added and a new ~250 lines test file to cover all cases.
#12701
Expensify/expensify-common#475

[sonialiap]

@tienifr thanks for bringing that up! Please apply for https://www.upwork.com/jobs/~01af93adacf3d34f62 and I'll include the bonus

[parasharrajat]

@sonialiap Thanks for the payment. C+ is also eligible for the same bonus as per the process. Could you please add that as well? Thanks.

[tienifr]

@sonialiap should we align on the bonus amount on this thread first, similar to in here?

@parasharrajat @MonilBhavsar what do you think?

[parasharrajat]

I think $250 is fine for the additional PR as 50% bonus.

Adding tests and clean up is considered part of work. It may not be needed for some PRs but it doesn't count as additional work.

[sonialiap]

@tienifr yes, good idea. Do you have thoughts of how much the bonus should be on this issue?

(Rajat, I am going to hold of sending a bonus payment until we figure out the bonus amount)

[tienifr]

@sonialiap I think $500 bonus would be reasonable considering the amount of changes made are rather huge compared to a regular issue.

But I'm all good with any final decision made by @parasharrajat here.

I've applied to the job, thanks.

[sonialiap]

Sound good @tienifr. @MonilBhavsar, can you please confirm via a comment that you're cool with this and I'll issue payment?

[MonilBhavsar]

I think $250 is fine for the additional PR as 50% bonus.

Adding tests and clean up is considered part of work. It may not be needed for some PRs but it doesn't count as additional work.

I agree with Rajat's reasoning here and $250 bonus

[MonilBhavsar]

@sonialiap can we please issue the payment and bonus here

[MonilBhavsar]

@sonialiap is ooo

[mallenexpensify]

Bonused Rajat $250. Paid @sobitneupane $250 for reporting.
@tienifr can you please accept the job and reply here once you have? You'll get paid $750 total
https://www.upwork.com/jobs/~01af93adacf3d34f62

[tienifr]

@mallenexpensify accepted, thanks!

[mallenexpensify]

Paid @tienifr $750
I added this to the testing guidelines we're working on, since it doesn't make sense (to me) to have a test case for it.

As for the other regression checklist items, I don't remember this ever working correctly before, does anyone?

[parasharrajat]

No, it was not working since the start.

[MonilBhavsar]

@mallenexpensify thanks!

since it doesn't make sense (to me) to have a test case for it.

I think we should have a test for this in chat messages list. We discussed here https://expensify.slack.com/archives/C01SKUP7QR0/p1673918731715469

Regarding regression, I believe it is like this since beginning, as we missed this case.

[mallenexpensify]

oooh, I didn't know we had an area for OldDot Transition in TestRail, that sounds like the best place for it. Thanks @MonilBhavsar

[sonialiap]

Thanks @mallenexpensify!

[parasharrajat]

Are we waiting on something? I think it is ready to be closed.

[MonilBhavsar]

Looks like everyone are paid.
we can close this once we have requested to add this to regression testing. cc @sonialiap

[sonialiap]

Was just following up on the regression GH. Looks like all is set on this one, everyone's paid and the regression test is set up. We can close 👍

[MonilBhavsar]

Thanks!