-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Android - Chat - App is crashed after sent the message #12666
Comments
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open
|
Triggered auto assignment to @dangrous ( |
Was able to reproduce locally when pointing to the staging server. Interestingly, not when pointed to my local dev environment. Not sure if that's useful information or not, tbd. Will start looking through the checklist to see what might be the culprit. |
Looks like this is the error that's being thrown in the logs on the crash: [OOPS!] API threw InvalidArgumentException - f862e02c8f5ff3962f0c8b69a4a8cbfc ~~ exceptionMessage: 'Invalid Push_Channel Parameters' exceptionFile: '/git/releases/expensify.com/76fb8d8/lib/Push/Channel.php' exceptionLine: '140' exceptionCode: '500' |
Here's the error from the android side (finally got Flipper working!) tldr -
|
Not really making much progress here, have posted in #eng-chat to see if I can find some help! |
It is indeed #12606 - something about changing the zindex of chats isn't playing nicely with Android. Tried removing that line and the crash doesn't seem to happen. Obviously that's not a good solution, though, so have reached out to @roryabraham (PR author) and will continue to investigate on my end as well. |
@dangrous Great job triaging this, I'll start working on a fix now |
Keeping you assigned so you get your GH points 😉 |
I'm pretty sure that this is a bug in React Native, but because this is an hourly we can't really afford to fix it upstream right now, so we need a temporary workaround. Here are the first things I would suggest that we try:
Then, with lower priority, I can try to make a minimal reproduction of this bug and work on a better upstream fix |
Removing DeployBlocker tag as this was fixed with #12688 |
Yo yo! @roryabraham @dangrous don't forget to add BugZero so that @mananjadhav can be paid out for his review in the linked PR. Adding the |
Triggered auto assignment to @mateocole ( |
@mateocole Can we get @mananjadhav paid out today for his review of the linked internal PR? Thanks! |
Not overdue, awaiting payment |
@mateocole quick bump, can you help with the payout here ? |
@mananjadhav Can you please apply here and I'll handle: https://www.upwork.com/jobs/~0115fde2357c200b23 |
Done. All paid out. |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
Expected Result:
Message should be send
Actual Result:
App is crashed after sent the message
Workaround:
Unknown
Platform:
Where is this issue occurring?
Version Number: 1.2.27.0
Reproducible in staging?: Yes
Reproducible in production?: No
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Screen_Recording_20221111-090024_One.UI.Home.mp4
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
View all open jobs on GitHub
The text was updated successfully, but these errors were encountered: