Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy Checklist: New Expensify 2022-12-16 #13654

Closed
25 tasks done
OSBotify opened this issue Dec 16, 2022 · 13 comments
Closed
25 tasks done

Deploy Checklist: New Expensify 2022-12-16 #13654

OSBotify opened this issue Dec 16, 2022 · 13 comments
Assignees
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging Monthly KSv2 StagingDeployCash

Comments

@OSBotify
Copy link
Contributor

OSBotify commented Dec 16, 2022

Release Version: 1.2.41-3
Compare Changes: production...staging

This release contains changes from the following pull requests:

Deploy Blockers:

Deployer verifications:

  • I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
  • I checked Firebase Crashlytics and verified that this release does not introduce any new crashes.

cc @Expensify/applauseleads

@melvin-bot melvin-bot bot locked and limited conversation to collaborators Dec 16, 2022
@mvtglobally mvtglobally added the 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging label Dec 16, 2022
@OSBotify
Copy link
Contributor Author

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.2.41-1 🚀

@mvtglobally
Copy link

@chiragsalian Regression is completed
Blockers
#13661
#13665

PRs
PR #12701 is failing #11810. Its repro in PROD, but pls double check
PR #13546 is failing #13679 & #13665
PR #13590 is failing #13679
PR #13593 is failing on Android #11048. repro in PROD checking off
PR #13607 is failing #13681. Its already in PROD. Are we ok to check it off?
PR #13621 is failing #13676. repro in PROD

@mvtglobally
Copy link

@yuwenmemon Let us know if any retests or anything required to push this through

Additional blocker #13687

@yuwenmemon
Copy link
Contributor

Thanks @mvtglobally! Will post about the blockers now and will take a look at the failing PRs

@yuwenmemon
Copy link
Contributor

yuwenmemon commented Dec 19, 2022

PR #12701 is failing #11810. Its repro in PROD, but pls double check

Tested on staging / prod, works the same! (And works!) So, checking it off

@melvin-bot melvin-bot bot added the Monthly KSv2 label Dec 19, 2022
@OSBotify
Copy link
Contributor Author

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.2.41-2 🚀

@OSBotify
Copy link
Contributor Author

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.2.41-2 has been deployed to staging 🎉

@mvtglobally
Copy link

Checking off #13590, retest is pass

@OSBotify
Copy link
Contributor Author

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.2.41-3 🚀

@OSBotify
Copy link
Contributor Author

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.2.41-3 has been deployed to staging 🎉

@mvtglobally
Copy link

#13703 is failing. logging an issue app is crashing

@yuwenmemon
Copy link
Contributor

Yes we had some intermiddent failures while we were CP'ing the proper changes to staging. Just tested locally and it works well now!

@yuwenmemon
Copy link
Contributor

:shipit:

@Expensify Expensify unlocked this conversation Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging Monthly KSv2 StagingDeployCash
Projects
None yet
Development

No branches or pull requests

4 participants