-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2023-02-08] [$2000] Deep link routing is inconsistent when the app is open #13691
Comments
On it |
Started convo re: repro steps |
Commented here. I believe this isn't worth fixing and will cease to be a problem after we rework our app navigation. |
Closing as dupe for 9179 |
Based on our Slack discussion, that might be premature. I'm going to see if I can provide any evidence for my belief that it'll be resolved by our navigation changes. |
After a lot of testing, I believe this is a good overview of deep linking: Magic Sign in deep link
Workspace message deep link
So, I believe there are two main problems here: A) Because of this known issue, the user is taken to the LHN instead of the specific deep link chat. This is because of our weird navigation hierarchy, where both the LHN and Chat page are at the same level (mirroring web/Desktop). This will cease to be a problem once we implement the navigation improvements because LHN and the Chat pages will be completely separated |
Job added to Upwork: https://www.upwork.com/jobs/~0106e69a3f4a655640 |
Triggered auto assignment to Contributor Plus for review of internal employee PR - @rushatgabhane ( |
Nice, thanks Jules. So it's this we focus on here right?
|
Yikes, that one seems like quite the project, right? I'd want to make sure that we also consider whether there are broader improvements, and potentially even a refactor of sorts for consideration. |
@rushatgabhane @Julesssss @mountiny the PR is ready for review #14588 |
Thanks for moving this forward all, I'm back and will test it today. |
Yeah, I don't think it's a bad regression that would reduce payment, but I'm taking care of it here. |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.63-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2023-02-08. 🎊 After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
|
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
I wouldn't count this as a regression but is an overlooked case from the initial implementation (a very long time ago). So I checked off the relevant boxes. A regression test would be useful though. |
@rushatgabhane @Julesssss @mountiny Regression Test ProposalBug: Deep link routing is inconsistent when the app is open Proposed Test Steps:
Do we 👍 or 👎 |
Yep that looks good, thanks. @dylanexpensify, all yours to check off |
Looks great! Nice one @tienifr ! |
Added GH for test! Will begin payments tomorrow! |
@tienifr sent offer! @rushatgabhane invited to apply to job! |
@dylanexpensify please send an offer for reporting bonus |
@gadhiyamanan sent! |
@rushatgabhane can you accept offer when you get the chance? |
@dylanexpensify Accepted |
@dylanexpensify accepted, thanks! |
All paid out, thanks all! |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
1) Magic sign in Success
2) Magic sign in Failure
3) Admin chat failure
Solution
Figure out why the deep-links aren't working as expected while the app is open.
Actual Result :
on signin it navigates to chat screen with concierge
Workaround:
unknown
Platform:
Where is this issue occurring?
Version Number: 1.2.41-1
Reproducible in staging?: y
Reproducible in production?: y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:
Screen_Recording_20221217_122455_New.Expensify.mp4
screen-20221219-134725.mp4
Expensify/Expensify Issue URL:
Issue reported by: @gadhiyamanan
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1671280997504769
View all open jobs on GitHub
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: