[HOLD for payment 2023-04-03] Clean-up react-native-web workaround and fix it upstream

[mountiny]

Coming from #9183 (comment)

@kidroca Has raised that this workaround can be fixed in the react-native-web upstream and that is definitely what we prefer. Creating this issue to track a progress on this.

Slack discussion is here

[melvin-bot]

Triggered auto assignment to @sophiepintoraetz (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[mountiny]

@sophiepintoraetz sorry I think this does not need to be handled as bug, just to track this and have room for updates.

[kidroca]

Thanks @mountiny

I'll try to recreate the bug extrenally and report it in react native web

I'll submit a fix for Expensify's fork and the mainstream react native web repo

[mountiny]

Thanks!

[mountiny]

Making this Weekly as it might take a while to get the maintainer to approve the payment, this is mainly for tracking

[MelvinBot]

This issue has not been updated in over 15 days. @kidroca eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[mountiny]

@kidroca Could you link the upstream PR here please?

[kidroca]

Yeah, sorry I haven't published it yet

I think I need to post 2 PRs

• for our fork (because that's what we're using in App)
• and for the original repo

[mountiny]

I see thanks for the context

[kidroca]

Sorry, I've been working on other issues - I'll the PRs about this today

[kidroca]

I've opened a bug report on the upstream repo

• Adding already rendered image has a small flicker necolas/react-native-web#2492

[kidroca]

Created a PR for the main repository

• Fix Image Caching necolas/react-native-web#2493

[mountiny]

I am gonna have to release out fork, instructions https://stackoverflowteams.com/c/expensify/questions/13855

[MelvinBot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[MelvinBot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.89-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Refactor: Remove Avatar platform specific code #15663

If no regressions arise, payment will be issued on 2023-04-03. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[mountiny]

@mollfpr I think you have reviewed and tested the PR, can you comment here so I can assign you

[Beamanator]

@mountiny fyi you can manually assign C+ w/out them needing to comment 👍

[mountiny]

Waaaaat, they were not showing up in my list, maybe I could scroll and I did not. Thanks!

[Beamanator]

Weird!! Hope it works next time 😬

[mountiny]

@mollfpr this still needs to be paid for your review and testing right?

[mollfpr]

@mountiny Yes!

[MelvinBot]

Current assignee @dylanexpensify is eligible for the Bug assigner, not assigning anyone new.

[mountiny]

@dylanexpensify could you please pay $1000 to @mollfpr for PR review and testing, thank you!

[dylanexpensify]

On it! @mollfpr here's the job to apply to! https://www.upwork.com/jobs/~01340b9f282d5e934e

[mollfpr]

@dylanexpensify The job is private for me.

[dylanexpensify]

ah shoot - sent invite to apply!

[mollfpr]

@dylanexpensify Applied, thank you!

[dylanexpensify]

Offer sent!

[dylanexpensify]

Payment done!