[HOLD for payment 2023-06-01] [$4000] After returning to a setting from a profile, the tooltip loses position on the profile image when you hover the mouse for the first time.

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to the setting -> Profile
2. Go back to Setting and hover the mouse over the profile image.
   (hover the image quickly)

Expected Result:

The tooltip should not lose the position even if you hover the image quickly.

Actual Result:

If you quickly hover over the image after returning from the profile, the tooltip loses position.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• MacOS / Chrome

Version Number: 1.2.73-1
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

tooltip.mp4

2023-02-16.20-31-00.mp4

Expensify/Expensify Issue URL:
Issue reported by: @ayazhussain79
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1676563140766109

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0175f90dca3be1912f
• Upwork Job ID: 1628033343922810880
• Last Price Increase: 2023-04-17

[MelvinBot]

Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[MelvinBot]

@CortneyOfstad Whoops! This issue is 2 days overdue. Let's get this updated quick!

[CortneyOfstad]

Was OoO — tackling this now!

[MelvinBot]

Job added to Upwork: https://www.upwork.com/jobs/~0175f90dca3be1912f

[MelvinBot]

Current assignee @CortneyOfstad is eligible for the External assigner, not assigning anyone new.

[MelvinBot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @parasharrajat (Internal)

[MelvinBot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (External)

[MelvinBot]

Triggered auto assignment to @MariaHCD (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[Ramkrishna1998]

The tooltip position is initialized only once during the first hover and the issue occurs because of the single initialization of the position of the tooltip so even if the target element position gets changed but tooltip position will not changed.

I have tried to implement the same scenario using the same component and I am attaching the before and after the fix

before: https://www.loom.com/share/f40dfbbdf9f94c07bee3e3c73285de34

after: https://www.loom.com/share/fa19295843f74158a8c4164546455202

[Litande]

Proposal

Please re-state the problem that we are trying to solve in this issue.

After returning to a setting from a profile, the tooltip loses position on the profile image when you hover the mouse for the first time.

What is the root cause of that problem?

There 2 events that are causing this issue.

1. The back button on settings have also a tooltip which triggers active state on TooltipSense component.
2. While the initial display in Tooltip is delayed (500 ms - atm) when TooltipSense is active it is happening imidiate, those the positions of tooltip is passed imidiatly and the tooltip is shown in the wrong place

What changes do you think we should make in order to solve the problem?

I propose 2 things:

1. Extend TooltipSense component to have method called deactivateImidiate which will reset active state on back button click.
2. In Tooltip to move the delay parameter as depency on active state before the execution of getWrapperPosition which desides on the tooltip position
   this will effectly will take the correct position and conserve the TooltipSense behavior.

What alternative solutions did you explore? (Optional)

Moving the delay to Hoverable component but at this point i belive it is over complecated without breaking the TooltipSense behavior.

[MelvinBot]

Looks like something related to react-navigation may have been mentioned in this issue discussion.

As a reminder, please make sure that all proposals are not workarounds and that any and all attempt to fix the issue holistically have been made before proceeding with a solution. Proposals to change our DeprecatedCustomActions.js files should not be accepted.

Feel free to drop a note in #expensify-open-source with any questions.

[MelvinBot]

📣 @Litande! 📣

Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
2. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
3. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.

Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[MelvinBot]

⚠️ Missing/invalid email or upwork profile link. Please make sure you add both your Expensify email and Upwork profile link in the format specified.

[Litande]

Contributor details
Your Expensify account email: mihaelchas@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/michaelchasovin

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.17-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Use BoundsObserver to keep tooltip over the wrapper #18782

If no regressions arise, payment will be issued on 2023-06-01. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@parasharrajat] The PR that introduced the bug has been identified. Link to the PR:
• [@parasharrajat] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@parasharrajat] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@parasharrajat] Determine if we should create a regression test for this bug.
• [@parasharrajat] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@anmurali] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[anmurali]

@parasharrajat can you complete the checklist above so I can pay and add regression (if applicable) before closing?

[parasharrajat]

[@parasharrajat] The PR that introduced the bug has been identified. Link to the PR: This bug is present since the first implementation. We never faced this up to this date.

[@parasharrajat] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: NA

[@parasharrajat] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: NA. This comes under edge-case scenarios and is rarely reproducible.

[@parasharrajat] Determine if we should create a regression test for this bug. yes

[@parasharrajat] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again. #15229 (comment)

[parasharrajat]

Regression Test Steps

1. Open the app on the web.

2. Test tooltip positioning for animated elements.

   1. Go to the "Settings" Page.
   2. Click on the Avatar to go to "Profile" page.
   3. Click the back arrow to go back to "Settings" and quickly hover the mouse over the profile Avatar.
   4. Verify that the tooltip behaves as expected and is positioned correctly.

3. Test the tooltip positioning in case of scrolling.

   1. Go to a page where content is scrollable and tooltips in the content. For example, a workspace chat with multiple messages
   2. Hover over an element with a tooltip (e.g. an avatar) and start scrolling slowly.
   3. Verify that the tooltip stays over that element.

Do you agree 👍 or 👎 ?

[flodnv]

It sounds super edge case, I'm not sure TBH. What do you think @anmurali ? Should we ask QA?

[anmurali]

No harm in adding a regression test proposal in a GH for Applause to evaluate.

[anmurali]

Also sent offers to @cubuspl42 and @parasharrajat for payment

[ayazhussain79]

@anmurali I reported that bug

[anmurali]

Sent offer

[ayazhussain79]

@anmurali offer accepted, Thank you

[flodnv]

Are we done here @anmurali ?

[anmurali]

Paid!

[ayazhussain79]

@anmurali could you please close this bug contract on upwrok for me