[HOLD for payment 2024-06-06] [HOLD #37147 RN PR][$2000] iOS - Chat - Cursor in the second and following lines touches the symbols of the previous line

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open the app
2. Sign in with any account
3. Go to any chat
4. Type anything on the composer until you reach the end of the line

Expected Result:

Cursor in the second and following lines NOT touches the symbols of the previous line

Actual Result:

Cursor in the second and following lines touches the symbols of the previous line

Workaround:

UNknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.2.78.0

Reproducible in staging?: Yes

Reproducible in production?: yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01dac248cbb18d206b
• Upwork Job ID: 1632682995228594176
• Last Price Increase: 2023-03-27

Issue Owner

Current Issue Owner: @sakluger / @zanyrenney

[MelvinBot]

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[sakluger]

I was able to reproduce, this happens for letters that extend below the line (like p and g). In the screenshot below, you can see that the cursor slightly overlaps with the g from the line above.

[MelvinBot]

Job added to Upwork: https://www.upwork.com/jobs/~01dac248cbb18d206b

[MelvinBot]

Current assignee @sakluger is eligible for the External assigner, not assigning anyone new.

[MelvinBot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Santhosh-Sellavel (External)

[MelvinBot]

Triggered auto assignment to @alex-mechler (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[shaunnewsum2020]

Proposal

Please re-state the problem that we are trying to solve in this issue.

[iOS] Chat: The cursor of the composer is located at the wrong line when touched.

What is the root cause of that problem?

React Native's TextInput component has an issue on iOS regarding the line height - facebook/react-native#28012

What changes do you think we should make in order to solve the problem?

We can fix it by just removing the lineHeight property in the styles.

[MelvinBot]

📣 @shaunnewsum2020! 📣

Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
2. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
3. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.

Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[shaunnewsum2020]

Contributor details
Your Expensify account email: shaunnewsum2020@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~01619249d793a96491

[MelvinBot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[alex-mechler]

Still waiting for more proposals Melvin

[allroundexperts]

@alex-mechler This seems to be something that is the default behaviour on RN Text input for iOS. It is not dependent on the line height of the input. I have created a Snack for you to confirm this. I think we should do nothing here.

[fabOnReact]

Update 22 May 2024

• Merged PR Fix TextInput vertical alignment issue when using lineHeight prop on iOS without changing Text baseline (Fabric - new arch) react-native-live-markdown#350
• Published Draft PR upgrade react-native-live-markdown to 0.1.76 #42454 to update Expensify dependency react-native-live-markdown to 0.1.76. I will move it to Ready for Review tomorrow.

[fabOnReact]

Update 23 May 2024

Moved PR #42454 to ready for review.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.77-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• upgrade react-native-live-markdown to 0.1.76 #42454

If no regressions arise, payment will be issued on 2024-06-06. 🎊

For reference, here are some details about the assignees on this issue:

• @OlimpiaZurek does not require payment (Contractor)
• @Santhosh-Sellavel requires payment through NewDot Manual Requests

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@marcochavezf] The PR that introduced the bug has been identified. Link to the PR:
• [@marcochavezf] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@marcochavezf] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@OlimpiaZurek / @Santhosh-Sellavel] Determine if we should create a regression test for this bug.
• [@OlimpiaZurek / @Santhosh-Sellavel] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@sakluger / @zanyrenney] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[fabOnReact]

Update 1st of June 2024

PR #42454 was reverted because there are issues with react-native-live-markdown. The issues seem to not be related to PR Expensify/react-native-live-markdown#350.

• Chat - For quote, live markdown is not shown #42755 (Android)
• [$250] Android-Room-After creating room, entering @ not showing contact suggestions #42766 (Android)
  I will look into it.

[fabOnReact]

Update 5th of June 2024

Hello @sakluger,

The issue is solved with PRs:

• Fix TextInput vertical alignment issue when using lineHeight prop on iOS without changing Text baseline (Paper - old arch)  facebook/react-native#38359 (Paper - merged)
• Fix TextInput vertical alignment issue when using lineHeight prop on iOS without changing Text baseline (Fabric - new arch) react-native-live-markdown#350 (Fabric - merged)

Before	After

Should I apply for the Upwork job?
Thanks a lot

Related issues are #17767 and #14445

[melvin-bot]

Payment Summary

Upwork Job

• Contributor: @OlimpiaZurek is from an agency-contributor and not due payment
• Reviewer: @Santhosh-Sellavel owed $250 via NewDot

BugZero Checklist (@sakluger)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1632682995228594176/hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[sakluger]

Hey @Santhosh-Sellavel could you please complete the BZ checklist?

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[Santhosh-Sellavel]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@marcochavezf] The PR that introduced the bug has been identified. Link to the PR: N/A
• [@marcochavezf] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
• [@marcochavezf] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
• [@OlimpiaZurek / @Santhosh-Sellavel] Determine if we should create a regression test for this bug. Yes
• [@OlimpiaZurek / @Santhosh-Sellavel] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again. Will do in the comment below
• [@sakluger / @zanyrenney] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

N/A - Because this bug was in upstream issue in react native

cc: @marcochavezf @sakluger

[Santhosh-Sellavel]

Bug: Chat - Cursor in the second and following lines touches the symbols of the previous line

Proposed Test Steps:

1. Open the app
2. Sign in with any account
3. Go to any chat
4. Type anything on the composer until you reach the end of the line
5. Verify Cursor in the second and following lines NOT touches the symbols of the previous line

👍 or 👎

cc: @sakluger @marcochavezf

[Santhosh-Sellavel]

@sakluger
Can you update the payment summary, please!
It says only $250, this had lot of review work. It was $2000 as you can see it in title, this was on hold mostly due to RN Deploy. Not sure when it got merged as you can see this original facebook/react-native#37147 is still open, I missed this comment it got merged in mention PRs it seems I am unaware because of that. Any please update the payment summary accordingly if there is deduction please let me know, but $250 is really low for the work done here Thanks!

[fabOnReact]

See #15640 (comment) and previous comments.

PR 37147 not merged.