-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2023-06-15] [HOLD for payment 2023-05-09] [Navigation Reboot] Remove the drawer navigator #15852
Comments
Hi is there no bounty for this issue? Anyways I wanted to start contributing for native iOS, could someone point me to the starting point? For example, how I onboard on the project? |
@gauravmishra-17 sorry this one is not available, can you please give this doc a good read and get into our Slack channels. All instructions are there. |
Going to implement this |
Job added to Upwork: https://www.upwork.com/jobs/~01039b367e157236fb |
Triggered auto assignment to Contributor Plus for review of internal employee PR - @s77rt ( |
Work will resume now once ECX is done |
This one will be done sooner as part of one PR with other two issues |
Unassigning CPlus for now, I will ask in the channel once the PR will be ready |
Actively being worked on |
@mountiny, @adamgrzybowski Uh oh! This issue is overdue by 2 days. Don't forget to update your issues! |
Actively being worked on |
Triggered auto assignment to @miljakljajic ( |
Lets handle payments for this massive PR. It was Rajat and Aimane reviewing, although to be fair it was Rajat who spent the most time on this so I believe he should be rewarded more.
|
@miljakljajic Would you be bale to help us with the payments here, its described in the comment above. Thank you! |
Sorry for the delay! I will pay right away. |
Offers sent to both of you :) |
Accepted. Thanks |
Both of you have been paid, and contracts ended! |
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results. If a regression has occurred and you are the assigned CM follow the instructions here. If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future. |
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.25-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2023-06-15. 🎊 After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
|
Tracking issue #11768
Created a new branch
navigation-refactor
to which we will merge all the PRs of this refactor.Remove the drawer navigator and extract the SidebarScreen and Report screens to the ResponsiveNavigator
Bookmark in the doc
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: