Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2023-06-15] [HOLD for payment 2023-05-09] [Navigation Reboot] Remove the drawer navigator #15852

Closed
mountiny opened this issue Mar 10, 2023 · 26 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Engineering Internal Requires API changes or must be handled by Expensify staff NewFeature Something to build that is a new item. Reviewing Has a PR in review Weekly KSv2

Comments

@mountiny
Copy link
Contributor

mountiny commented Mar 10, 2023

Tracking issue #11768

Created a new branch navigation-refactor to which we will merge all the PRs of this refactor.

Remove the drawer navigator and extract the SidebarScreen and Report screens to the ResponsiveNavigator

Bookmark in the doc

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01039b367e157236fb
  • Upwork Job ID: 1634918647147466752
  • Last Price Increase: 2023-03-12
@mountiny mountiny added Engineering Daily KSv2 NewFeature Something to build that is a new item. labels Mar 10, 2023
@mountiny mountiny self-assigned this Mar 10, 2023
@melvin-bot melvin-bot bot locked and limited conversation to collaborators Mar 10, 2023
@Expensify Expensify unlocked this conversation Mar 10, 2023
@mountiny mountiny added Weekly KSv2 and removed Daily KSv2 labels Mar 10, 2023
@gauravmishra-17
Copy link

gauravmishra-17 commented Mar 10, 2023

Hi is there no bounty for this issue? Anyways I wanted to start contributing for native iOS, could someone point me to the starting point? For example, how I onboard on the project?

@mountiny
Copy link
Contributor Author

@gauravmishra-17 sorry this one is not available, can you please give this doc a good read and get into our Slack channels. All instructions are there.

@Expensify Expensify deleted a comment from MelvinBot Mar 10, 2023
@adamgrzybowski
Copy link
Contributor

Going to implement this

@mountiny mountiny added the Internal Requires API changes or must be handled by Expensify staff label Mar 12, 2023
@MelvinBot
Copy link

Job added to Upwork: https://www.upwork.com/jobs/~01039b367e157236fb

@MelvinBot
Copy link

Triggered auto assignment to Contributor Plus for review of internal employee PR - @s77rt (Internal)

@adamgrzybowski
Copy link
Contributor

Work will resume now once ECX is done

@melvin-bot melvin-bot bot removed the Overdue label Mar 20, 2023
@mountiny mountiny added Daily KSv2 and removed Weekly KSv2 labels Mar 21, 2023
@mountiny
Copy link
Contributor Author

This one will be done sooner as part of one PR with other two issues

@mountiny
Copy link
Contributor Author

Unassigning CPlus for now, I will ask in the channel once the PR will be ready

@adamgrzybowski
Copy link
Contributor

Still working on this. It's not that easy to create separate PR just for this issue so the Implementation will be pushed in a single PR including:

#15848
#15851
#15852

@mountiny
Copy link
Contributor Author

Actively being worked on

@MelvinBot
Copy link

@mountiny, @adamgrzybowski Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@mountiny
Copy link
Contributor Author

Actively being worked on

@mountiny mountiny added NewFeature Something to build that is a new item. and removed NewFeature Something to build that is a new item. labels Apr 22, 2023
@MelvinBot
Copy link

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Apr 22, 2023
@mountiny
Copy link
Contributor Author

Lets handle payments for this massive PR. It was Rajat and Aimane reviewing, although to be fair it was Rajat who spent the most time on this so I believe he should be rewarded more.

@mountiny
Copy link
Contributor Author

mountiny commented May 8, 2023

@miljakljajic Would you be bale to help us with the payments here, its described in the comment above. Thank you!

@mountiny mountiny added the Awaiting Payment Auto-added when associated PR is deployed to production label May 8, 2023
@mountiny mountiny changed the title [Navigation Reboot] Remove the drawer navigator [HOLD for payment 2023-05-09] [Navigation Reboot] Remove the drawer navigator May 8, 2023
@mountiny mountiny added Daily KSv2 and removed Reviewing Has a PR in review Weekly KSv2 labels May 8, 2023
@miljakljajic
Copy link
Contributor

Sorry for the delay! I will pay right away.

@miljakljajic
Copy link
Contributor

Offers sent to both of you :)

@parasharrajat
Copy link
Member

Accepted. Thanks

@miljakljajic
Copy link
Contributor

Both of you have been paid, and contracts ended!

@melvin-bot
Copy link

melvin-bot bot commented Jun 7, 2023

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Jun 8, 2023
@melvin-bot melvin-bot bot changed the title [HOLD for payment 2023-05-09] [Navigation Reboot] Remove the drawer navigator [HOLD for payment 2023-06-15] [HOLD for payment 2023-05-09] [Navigation Reboot] Remove the drawer navigator Jun 8, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jun 8, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.25-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-06-15. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

  • Merged PR within 3 business days of assignment - 50% bonus
  • Merged PR more than 9 business days after assignment - 50% penalty

@melvin-bot melvin-bot bot added the Reviewing Has a PR in review label Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Engineering Internal Requires API changes or must be handled by Expensify staff NewFeature Something to build that is a new item. Reviewing Has a PR in review Weekly KSv2
Projects
None yet
Development

No branches or pull requests

9 participants