Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD #11768] After opening the timezones deeplink once, pressing enter/return on any other page takes the user back to the timezone page #16512

Closed
1 of 6 tasks
kavimuru opened this issue Mar 25, 2023 · 21 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Monthly KSv2 Reviewing Has a PR in review

Comments

@kavimuru
Copy link

kavimuru commented Mar 25, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Open https://staging.new.expensify.com/settings/profile/timezone/select
  2. Press back until you reach the Display name, Contact method, or Pronouns page
  3. Click on either Display name, Contact method, or Pronouns page
  4. Press enter/return key

Expected Result:

The user is not taken to the timezone page

Actual Result:

The user is taken to the timezone page

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.2.89-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Recording.49.mp4
Screen.Recording.2023-03-25.at.4.55.56.PM.mov

Expensify/Expensify Issue URL:
Issue reported by: @adeel0202
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1679745461112709

View all open jobs on GitHub

@kavimuru kavimuru added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Mar 25, 2023
@MelvinBot
Copy link

Triggered auto assignment to @sophiepintoraetz (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@MelvinBot
Copy link

MelvinBot commented Mar 25, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@melvin-bot melvin-bot bot added the Overdue label Mar 27, 2023
@MelvinBot
Copy link

@sophiepintoraetz Whoops! This issue is 2 days overdue. Let's get this updated quick!

@MelvinBot
Copy link

Triggered auto assignment to @robertjchen (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@sophiepintoraetz
Copy link
Contributor

Was able to reproduce!

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Mar 28, 2023
@robertjchen
Copy link
Contributor

👀

@melvin-bot melvin-bot bot removed the Overdue label Apr 2, 2023
@robertjchen robertjchen added Weekly KSv2 and removed Daily KSv2 labels Apr 2, 2023
@robertjchen
Copy link
Contributor

Seems like something the Navigation Reboot will address, adding a HOLD for now: #11768

@MelvinBot
Copy link

Looks like something related to react-navigation may have been mentioned in this issue discussion.

As a reminder, please make sure that all proposals are not workarounds and that any and all attempt to fix the issue holistically have been made before proceeding with a solution. Proposals to change our DeprecatedCustomActions.js files should not be accepted.

Feel free to drop a note in #expensify-open-source with any questions.

@robertjchen robertjchen changed the title After opening the timezones deeplink once, pressing enter/return on any other page takes the user back to the timezone page [HOLD #11768] After opening the timezones deeplink once, pressing enter/return on any other page takes the user back to the timezone page Apr 7, 2023
@robertjchen robertjchen added Monthly KSv2 and removed Weekly KSv2 labels Apr 7, 2023
@sophiepintoraetz
Copy link
Contributor

Actually going to close this and add it to the OP of the linked issue.

@adeel0202
Copy link
Contributor

@sophiepintoraetz I'm eligible for the reporting bonus here, so shouldn't it be open until it gets fixed with the linked issue and I get paid for reporting? 😄

@mountiny
Copy link
Contributor

mountiny commented Jul 27, 2023

@adeel0202 Can you confirm this is now fixed?

If so we should pay the reporting bonus

@mountiny mountiny reopened this Jul 27, 2023
@melvin-bot melvin-bot bot added the Overdue label Jul 27, 2023
@adeel0202
Copy link
Contributor

Yes, it's fixed now.

@robertjchen robertjchen added the Reviewing Has a PR in review label Jul 28, 2023
@melvin-bot melvin-bot bot removed the Overdue label Jul 28, 2023
@mallenexpensify
Copy link
Contributor

@adeel0202 , can you please accept the job and reply here once you have?
https://www.upwork.com/jobs/~01ec32930db552871f

@adeel0202
Copy link
Contributor

Thanks, I have accepted.

@adeel0202
Copy link
Contributor

@mallenexpensify a friendly bump

@robertjchen
Copy link
Contributor

I believe this has been completed, but please feel free to re-open if not handled 👍

@adeel0202
Copy link
Contributor

@robertjchen, I accepted the Upwork offer but I am not paid yet.
cc @mallenexpensify

@robertjchen robertjchen reopened this Sep 4, 2023
@sophiepintoraetz
Copy link
Contributor

Offer sent @adeel0202!

@adeel0202
Copy link
Contributor

@sophiepintoraetz, I was already sent an offer by @mallenexpensify. I accepted it and that contract is still ongoing. Can you please release payment for that contract?

@mallenexpensify
Copy link
Contributor

mallenexpensify commented Sep 5, 2023

Issue reporter: @adeel0202 paid $250 via Upwork.

https://www.upwork.com/jobs/~01ec32930db552871f

Should be all set, so closing.

@sophiepintoraetz
Copy link
Contributor

@adeel0202 - fyi, I did not have access to the offer as it came from Matt. There are limitations to Upwork!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Monthly KSv2 Reviewing Has a PR in review
Projects
None yet
Development

No branches or pull requests

7 participants