[HOLD for payment 2023-06-15] [$1000] Deleted message gets highlighted when we send a message, delete the message, visit any other chat and revisit the chat in offline mode #18165

kavimuru · 2023-04-28T20:27:53Z

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

Open the app
Open any report
Switch to offline mode
Delete any message (currently it is not highlighted)
Switch to other report and revisit the deleted message report to see that message is highlighted now
Switch off offline mode
Again visit the chat to see that deleted message is now gone
Switch back the offline mode
Revisit the chat and deleted message is back and it is still highlighted

Expected Result:

App should not highlight deleted message on revisiting chat in offline mode nor have the deleted message reappear after reconnecting online then offline

Actual Result:

App highlights deleted message on revisiting chat in offline mode and highlight remains intact. App shows deleted message in offline mode even after going back online then offline again.

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

Version Number: 1.3.8
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

delete.in.offline.mode.highlights.the.message.mp4

Recording.412.mp4

Expensify/Expensify Issue URL:
Issue reported by: @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1682681346161399

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~013afb44ff7c31e750
Upwork Job ID: 1654091952987746304
Last Price Increase: 2023-06-01

MelvinBot · 2023-04-28T20:27:59Z

Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

MelvinBot · 2023-04-28T20:28:02Z

Bug0 Triage Checklist (Main S/O)

This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

dylanexpensify · 2023-05-02T07:49:36Z

reviewing today!

bernhardoj · 2023-05-02T09:43:11Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

The deleted message while offline has a hover effect after switching back from another chat.

What is the root cause of that problem?

The hover effect will show if:

is hovered
is a whisper
a context menu active

is a draft message

App/src/pages/home/report/ReportActionItem.js

Lines 282 to 286 in ce3b938

    
           style={StyleUtils.getReportActionItemStyle( 
        
               hovered 
        
               || isWhisper 
        
               || this.state.isContextMenuActive 
        
               || this.props.draftMessage,

and the condition that it meets is the third one. Why?

When we delete a chat, it will show a delete modal by calling showDeleteModal of PopoverReportActionContextMenu passing the selected report action id and the report id.

App/src/pages/home/report/ContextMenu/PopoverReportActionContextMenu.js

Lines 287 to 296 in ce3b938

    
           showDeleteModal(reportID, reportAction, shouldSetModalVisibility = true, onConfirm = () => {}, onCancel = () => {}) { 
        
               this.onCancelDeleteModal = onCancel; 
        
               this.onComfirmDeleteModal = onConfirm; 
        
               this.setState({ 
        
                   reportID, 
        
                   reportAction, 
        
                   shouldSetModalVisibilityForDeleteConfirmation: shouldSetModalVisibility, 
        
                   isDeleteCommentConfirmModalVisible: true, 
        
               }); 
        
           }

When we confirm the deletion, we

delete the message

hide the modal

App/src/pages/home/report/ContextMenu/PopoverReportActionContextMenu.js

Lines 261 to 265 in ce3b938

    
           confirmDeleteAndHideModal() { 
        
               this.callbackWhenDeleteModalHide = () => this.onComfirmDeleteModal = this.runAndResetCallback(this.onComfirmDeleteModal); 
        
               Report.deleteReportComment(this.state.reportID, this.state.reportAction); 
        
               this.setState({isDeleteCommentConfirmModalVisible: false}); 
        
           }

One thing is missing is to reset the report action id and report id. So, when we reopen the chat, it will remount the component and check, is this chat message has an active context menu?

App/src/pages/home/report/ReportActionItem.js

Lines 99 to 101 in ce3b938

    
           this.state = { 
        
               isContextMenuActive: ReportActionContextMenu.isActiveReportAction(props.action.reportActionID), 
        
           };

App/src/pages/home/report/ContextMenu/PopoverReportActionContextMenu.js

Lines 110 to 112 in ce3b938

    
           isActiveReportAction(actionID) { 
        
               return Boolean(actionID) && this.state.reportAction.reportActionID === actionID; 
        
           }

Because we didn't clear the report action id, it will say, yes, a context menu is active for this chat message.

~~This issue however doesn't happen when we simply cancel the deletion because when we cancel it, we will call hideDeleteModal that will reset the report action id and along with other state.~~

App/src/pages/home/report/ContextMenu/PopoverReportActionContextMenu.js

Lines 267 to 277 in ce3b938

    
           hideDeleteModal() { 
        
               this.callbackWhenDeleteModalHide = () => this.onCancelDeleteModal = this.runAndResetCallback(this.onCancelDeleteModal); 
        
               this.setState({ 
        
                   reportID: '0', 
        
                   reportAction: {}, 
        
                   isDeleteCommentConfirmModalVisible: false, 
        
                   shouldSetModalVisibilityForDeleteConfirmation: true, 
        
                   isArchivedRoom: false, 
        
                   isChronosReport: false, 
        
               }); 
        
           }

UPDATE: It's no longer true because we remove the reportActions reset here

What changes do you think we should make in order to solve the problem?

Reset both report action and report id in onModalHide callback of ConfirmModal

App/src/pages/home/report/ContextMenu/PopoverReportActionContextMenu.js

Line 332 in b6eb637

onModalHide={this.callbackWhenDeleteModalHide}

onModalHide={() => {
    this.setState({reportID: '0', reportAction: {});
    this.callbackWhenDeleteModalHide()
}}

dylanexpensify · 2023-05-03T17:26:54Z

Didn't get to this today due to focusing on ECUK and CPM tasks! Will review tomorrow!

dylanexpensify · 2023-05-04T10:01:51Z

Posted about this to get clarification on expected behavior. Will update this once we come to a conclusion.

dylanexpensify · 2023-05-04T10:45:21Z

After discussing we confirmed that this is an expected behavior! @dhanashree-sawant here's where you can find more info!

dhanashree-sawant · 2023-05-04T10:51:35Z

Hi @dylanexpensify, In the document, we have mentioned that it should be greyed out but in the issue, the deleted message gets highlighted not greyed out. It gets greyed out when we delete but when we revisit the chat, it gets highlighted.

dylanexpensify · 2023-05-04T10:56:02Z

I believe that makes sense it's still highlighted while in offline mode, since technically, the delete action hasn't registered 100% yet. I think this would be a bug if we got back online, and the deleted comment did finish deletion, but then still highlighted after switching back. Mind confirming for me it doesn't do that?

dhanashree-sawant · 2023-05-04T11:09:54Z

Yes so on going back offline, the deleted message reappears and it is still highlighted, steps I did:

switched to offline mode
delete any message (currently it is not highlighted)
switch to other report and revisit the deleted message report to see that message is highlighted now
Switch off offline mode
Again visit the chat to see that deleted message is now gone
Switch back the offline mode
Revisit the chat and deleted message is back and it is still highlighted

dylanexpensify · 2023-05-04T11:21:09Z

And after step 5, is the message now gone? Did you show those steps in the video above?

dhanashree-sawant · 2023-05-04T11:23:05Z

No message still exist, sorry I haven't shown that part in the video , I will add new video below with step 6 and 7 shown in it.

dylanexpensify · 2023-05-04T11:23:39Z

Ah that'd be great if you can show the steps you just commented in a video! Thanks!

dhanashree-sawant · 2023-05-04T11:28:29Z

Here is the video

2023-05-04.16-56-58.mp4

bernhardoj · 2023-05-04T11:49:32Z

@dylanexpensify
Just sharing my thoughts.

I agree with @dhanashree-sawant that the offline feedback should be the grayed out and strikethrough-ed, but not with the highlight effect. This is consistent with other component that apply the same offline feedback, for example workspaces list. Notice there is no highlight effect.

Based on my finding, the chat message is highlighted because the chat message "thought" that there is an active context menu.

dylanexpensify · 2023-05-04T11:50:18Z

@dhanashree-sawant that new video is super helpful, ty!
@bernhardoj appreciate the thoughts, and like where your head is at with it!

dylanexpensify · 2023-05-04T11:53:40Z

Was able to successfully repro. Thanks for the back and forth here team!

MelvinBot · 2023-05-04T11:53:50Z

Job added to Upwork: https://www.upwork.com/jobs/~013afb44ff7c31e750

MelvinBot · 2023-05-04T11:53:53Z

Current assignee @dylanexpensify is eligible for the External assigner, not assigning anyone new.

MelvinBot · 2023-05-04T11:54:00Z

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Santhosh-Sellavel (External)

Santhosh-Sellavel · 2023-06-29T17:50:59Z

Will do a checklist in a day or two, caught up with other priority items!

Regarding payment check this!

dylanexpensify · 2023-07-03T08:46:43Z

@Santhosh-Sellavel let's get this done today 🙌

Santhosh-Sellavel · 2023-07-03T15:19:53Z

@bernhardoj Could use your help here is the https://github.com/Expensify/App/pull/17348/files#r1165760995 which caused this regression?

bernhardoj · 2023-07-03T15:41:40Z

@Santhosh-Sellavel yes

dylanexpensify · 2023-07-06T08:35:19Z

@Santhosh-Sellavel let's get an update here today please! 🙇‍♂️

Santhosh-Sellavel · 2023-07-06T20:30:33Z

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@Santhosh-Sellavel] The PR that introduced the bug has been identified. Link to the PR: Allow money request deletion #17348

[@Santhosh-Sellavel] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/17348/files#r1254888267

[@Santhosh-Sellavel] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: Should have caught based on the checklist in offline tests

[@Santhosh-Sellavel] Determine if we should create a regression test for this bug.

[@Santhosh-Sellavel] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again. [HOLD for payment 2023-06-15] [$1000] Deleted message gets highlighted when we send a message, delete the message, visit any other chat and revisit the chat in offline mode #18165 (comment)

[@dylanexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

@flodnv Let me know if differ on any of the above, thanks!

Santhosh-Sellavel · 2023-07-06T20:48:21Z

Bug:
Deleted message highlight remains when offline, even after switching chats

Regression Steps

Open a chat report on NewDot
Send a message in the chat
Open the context menu and choose Delete comment
Cancel the delete modal
Switch to another chat
Come back to the chat
Verify the message we are trying to delete is not highlighted
Turn off internet connection
Now, delete the message
Repeat steps 5-7

👍 or 👎

cc: @flodnv @dylanexpensify

dylanexpensify · 2023-07-10T09:36:12Z

Reviewing today!

flodnv · 2023-07-11T15:23:04Z

This is so incredibly niche, I'm not sure it's worth adding a regression test...

dylanexpensify · 2023-07-12T08:59:38Z

I think we can add it as an edge case test? They only test those once a month? But even then, maybe a bit much haha

dylanexpensify · 2023-07-12T08:59:53Z

Closing!

flodnv · 2023-07-12T13:05:28Z

Ah I forgot that was a thing. Maybe edge case makes sense yeah..

…

On Wed, Jul 12, 2023 at 11:00 AM Dylan Courtney ***@***.***> wrote: Closed #18165 <#18165> as completed. — Reply to this email directly, view it on GitHub <#18165 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AA7Y2OMQ464T3RPU6DMHKYDXPZRRJANCNFSM6AAAAAAXPVS5TU> . You are receiving this because you were mentioned.Message ID: ***@***.***>

Santhosh-Sellavel · 2023-07-12T15:12:49Z

I've had not received payment for this @dylanexpensify will request via NewDot

Santhosh-Sellavel · 2023-07-14T21:50:18Z

Requested Payment on ND

dylanexpensify · 2023-07-17T09:40:35Z

reopened while we wait for @Santhosh-Sellavel to be paid! Cc @anmurali

anmurali · 2023-07-18T18:05:36Z

Approved $1500 (with bonus) for Santhosh

kavimuru added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Apr 28, 2023

melvin-bot bot assigned dylanexpensify Apr 28, 2023

melvin-bot bot added the Overdue label May 1, 2023

melvin-bot bot removed the Overdue label May 2, 2023

dylanexpensify closed this as completed May 4, 2023

dylanexpensify added the External Added to denote the issue can be worked on by a contributor label May 4, 2023

melvin-bot bot assigned Santhosh-Sellavel May 4, 2023

melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label May 4, 2023

melvin-bot bot removed the Overdue label Jun 29, 2023

melvin-bot bot added the Overdue label Jul 3, 2023

melvin-bot bot removed the Overdue label Jul 3, 2023

melvin-bot bot added the Overdue label Jul 5, 2023

melvin-bot bot removed the Overdue label Jul 6, 2023

Santhosh-Sellavel mentioned this issue Jul 6, 2023

Allow money request deletion #17348

Merged

56 tasks

melvin-bot bot added the Overdue label Jul 10, 2023

melvin-bot bot removed the Overdue label Jul 10, 2023

dylanexpensify closed this as completed Jul 12, 2023

dylanexpensify reopened this Jul 17, 2023

melvin-bot bot added the Overdue label Jul 19, 2023

dylanexpensify closed this as completed Jul 20, 2023

melvin-bot bot removed the Overdue label Jul 20, 2023

s77rt mentioned this issue Aug 10, 2023

[HOLD for payment 2023-09-27] [$2000] Chat - Main composer is displayed when editing two messages #23908

Closed

6 tasks

[HOLD for payment 2023-06-15] [$1000] Deleted message gets highlighted when we send a message, delete the message, visit any other chat and revisit the chat in offline mode #18165

[HOLD for payment 2023-06-15] [$1000] Deleted message gets highlighted when we send a message, delete the message, visit any other chat and revisit the chat in offline mode #18165

Comments

kavimuru commented Apr 28, 2023 • edited by melvin-bot bot

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

MelvinBot commented Apr 28, 2023

MelvinBot commented Apr 28, 2023 • edited by dylanexpensify

Bug0 Triage Checklist (Main S/O)

dylanexpensify commented May 2, 2023

bernhardoj commented May 2, 2023 • edited

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

dylanexpensify commented May 3, 2023

dylanexpensify commented May 4, 2023

dylanexpensify commented May 4, 2023

dhanashree-sawant commented May 4, 2023

dylanexpensify commented May 4, 2023

dhanashree-sawant commented May 4, 2023

dylanexpensify commented May 4, 2023

dhanashree-sawant commented May 4, 2023

dylanexpensify commented May 4, 2023

dhanashree-sawant commented May 4, 2023

bernhardoj commented May 4, 2023

dylanexpensify commented May 4, 2023

dylanexpensify commented May 4, 2023

MelvinBot commented May 4, 2023

MelvinBot commented May 4, 2023

MelvinBot commented May 4, 2023

Santhosh-Sellavel commented Jun 29, 2023

dylanexpensify commented Jul 3, 2023

Santhosh-Sellavel commented Jul 3, 2023

bernhardoj commented Jul 3, 2023

dylanexpensify commented Jul 6, 2023

Santhosh-Sellavel commented Jul 6, 2023 • edited

Santhosh-Sellavel commented Jul 6, 2023 • edited

Regression Steps

dylanexpensify commented Jul 10, 2023

flodnv commented Jul 11, 2023

dylanexpensify commented Jul 12, 2023

dylanexpensify commented Jul 12, 2023

flodnv commented Jul 12, 2023 via email

Santhosh-Sellavel commented Jul 12, 2023

Santhosh-Sellavel commented Jul 14, 2023

dylanexpensify commented Jul 17, 2023

anmurali commented Jul 18, 2023

kavimuru commented Apr 28, 2023 •

edited by melvin-bot bot

MelvinBot commented Apr 28, 2023 •

edited by dylanexpensify

bernhardoj commented May 2, 2023 •

edited

Santhosh-Sellavel commented Jul 6, 2023 •

edited

Santhosh-Sellavel commented Jul 6, 2023 •

edited