Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created workspace is not immediately reflected in LHN #18323

Closed
1 of 6 tasks
kavimuru opened this issue May 3, 2023 · 19 comments
Closed
1 of 6 tasks

Created workspace is not immediately reflected in LHN #18323

kavimuru opened this issue May 3, 2023 · 19 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Internal Requires API changes or must be handled by Expensify staff Reviewing Has a PR in review

Comments

@kavimuru
Copy link

kavimuru commented May 3, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Click on ‘Profile’ avatar
  2. Click on ‘Workspaces’ link
  3. Click on ‘New workspace’ button
  4. Observe that workspace is displayed on LHN briefly and disappeared

Expected Result:

Created workspace should be displayed on LHN upon creation

Actual Result:

Created workspace is not displayed on LHN upon creation

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.9-4
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

2023-05-03.04.12.56.mp4
Recording.464.mp4

Expensify/Expensify Issue URL:
Issue reported by: @Natnael-Guchima
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1683076759095689

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0118b0a2d7058654a7
  • Upwork Job ID: 1653811047192453120
  • Last Price Increase: 2023-05-03
@kavimuru kavimuru added DeployBlockerCash This issue or pull request should block deployment Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels May 3, 2023
@MelvinBot
Copy link

Triggered auto assignment to @flaviadefaria (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@MelvinBot
Copy link

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@OSBotify
Copy link
Contributor

OSBotify commented May 3, 2023

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@MelvinBot
Copy link

Triggered auto assignment to @robertjchen (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@flaviadefaria
Copy link
Contributor

@robertjchen I'll leave this as hourly so that you can look into it as soon as possible.

@marcaaron
Copy link
Contributor

Hmm I think this is maybe related to some backend change. I tried to reproduce this and what I see is:

2023-05-03_07-07-48

If you turn off the "Use staging server" option in "Test preference" it will not be broken.

@joelbettner should get this on your radar as you are the web deployer this week. Once we deploy Web all NewDot versions will experience this issue.

@marcaaron marcaaron removed the DeployBlockerCash This issue or pull request should block deployment label May 3, 2023
@marcaaron
Copy link
Contributor

Removing the blocker since it is related to the Web deploy.

@marcaaron marcaaron added the Internal Requires API changes or must be handled by Expensify staff label May 3, 2023
@MelvinBot
Copy link

Job added to Upwork: https://www.upwork.com/jobs/~0118b0a2d7058654a7

@MelvinBot
Copy link

Triggered auto assignment to Contributor Plus for review of internal employee PR - @Santhosh-Sellavel (Internal)

@marcaaron marcaaron removed the Hourly KSv2 label May 3, 2023
@iwiznia iwiznia assigned iwiznia and unassigned robertjchen May 3, 2023
@iwiznia iwiznia added the Reviewing Has a PR in review label May 3, 2023
@melvin-bot
Copy link

melvin-bot bot commented May 11, 2023

@iwiznia, @flaviadefaria Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@iwiznia
Copy link
Contributor

iwiznia commented May 11, 2023

No update

@Natnael-Guchima
Copy link

Natnael-Guchima commented May 12, 2023

Hello @iwiznia @flaviadefaria 👋. This issue seems to be fixed and deployed to production. I was testing it now, and it seems to be working fine.

2023-05-12.10.29.38.mp4

@Natnael-Guchima
Copy link

A gentle bump @iwiznia @flaviadefaria

@iwiznia
Copy link
Contributor

iwiznia commented May 17, 2023

@flaviadefaria I assume @Natnael-Guchima is asking for payment for reporting the bug

@flaviadefaria
Copy link
Contributor

Paying him now!

@flaviadefaria
Copy link
Contributor

Offer sent, waiting for it to be accepted so that I can you @Natnael-Guchima.

@Natnael-Guchima
Copy link

Offer sent, waiting for it to be accepted so that I can you @Natnael-Guchima.

Accepted. Thanks @flaviadefaria .

@flaviadefaria
Copy link
Contributor

Paid so closing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Internal Requires API changes or must be handled by Expensify staff Reviewing Has a PR in review
Projects
None yet
Development

No branches or pull requests

9 participants