Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split Bill - List of user is not displayed in Split bill request #18341

Closed
2 of 6 tasks
kbecciv opened this issue May 3, 2023 · 10 comments
Closed
2 of 6 tasks

Split Bill - List of user is not displayed in Split bill request #18341

kbecciv opened this issue May 3, 2023 · 10 comments
Assignees

Comments

@kbecciv
Copy link

kbecciv commented May 3, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Click in "+" button
  2. Start split bill
  3. Insert amount and select 3 users from list
  4. Click next
  5. Click "Split" button

Expected Result:

The list of split users should be displayed in chat.

Actual Result:

No users list is displayed after Split bill request is completed

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.9.14

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6041367_SPlit_bill_list_user_Desktop.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

@kbecciv kbecciv added the DeployBlockerCash This issue or pull request should block deployment label May 3, 2023
@OSBotify
Copy link
Contributor

OSBotify commented May 3, 2023

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@MelvinBot
Copy link

Triggered auto assignment to @neil-marcellini (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@kbecciv
Copy link
Author

kbecciv commented May 3, 2023

Issue is not reproductible in production.

Screen.Recording.2023-05-03.at.12.22.28.mov

@pecanoro
Copy link
Contributor

pecanoro commented May 3, 2023

It's probably coming from this PR here: https://github.com/Expensify/Web-Expensify/pull/37076 cc/ @luacmartins If this was on purpose, the code needs to be cleaned to remove the $who from the code as it is unused now.

@avi-shek-jha
Copy link

Seems like the same issue was reported here earlier in slack today - https://expensify.slack.com/archives/C049HHMV9SM/p1683116974707729

@luacmartins
Copy link
Contributor

We changed these messages in this PR, so this is the expected behavior. I agree that we need to clean up $who since it's unused, here's the PR

@luacmartins
Copy link
Contributor

We can close this issue

@luacmartins luacmartins removed the DeployBlockerCash This issue or pull request should block deployment label May 3, 2023
@MonilBhavsar
Copy link
Contributor

What! Why we did this?
If one splits money between 3 in a group of 4 then it's impossible to figure out the participants, no?

@luacmartins
Copy link
Contributor

@MonilBhavsar the message will be completely gone from the chat by the time we are done with manual request. It will still be shown in the LHN though, but you couldn't get all participants names in there anyways.

Screenshot 2023-05-03 at 6 18 29 PM

@MonilBhavsar
Copy link
Contributor

Thanks for clarifying!
That makes sense 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants