Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request Money -The word "Request" in the conversation appears with a small letter #18359

Closed
6 tasks done
kbecciv opened this issue May 3, 2023 · 13 comments
Closed
6 tasks done
Assignees

Comments

@kbecciv
Copy link

kbecciv commented May 3, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Go to URL https://staging.new.expensify.com/
  2. Login with any account
  3. Navigate to a conversation
  4. Click on the + button in the compose box and select Request Money.

Expected Result:

The word "Request" must be displayed in capital letter.

Actual Result:

The word "Request" in the conversation appears with a small letter.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.9.14

Reproducible in staging?: yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6041541_Recording__2375.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

@kbecciv kbecciv added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels May 3, 2023
@MelvinBot
Copy link

Triggered auto assignment to @sophiepintoraetz (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@MelvinBot
Copy link

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@kbecciv kbecciv added DeployBlockerCash This issue or pull request should block deployment and removed Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels May 3, 2023
@OSBotify
Copy link
Contributor

OSBotify commented May 3, 2023

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@MelvinBot
Copy link

Triggered auto assignment to @dangrous (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@marcaaron
Copy link
Contributor

asking @luacmartins to check this one out I believe he has the most context

@dangrous
Copy link
Contributor

dangrous commented May 3, 2023

Yeah basically do we need to update the optimistic data, or do we need to adjust the backend to send a capital letter again? I see it was an intentional choice - https://github.com/Expensify/Web-Expensify/pull/37076/commits/ced6a21b3dca719510fda6e9b290543843e5aed2 - but wondering where that comes from?

(and if we update the optimistic data to match, we should also update whatever TestRail it is that says all of these should be capitalized)

@marcaaron
Copy link
Contributor

Ah Carlos M is ooo actually. Let's ask in eng chat.

@marcaaron
Copy link
Contributor

There might also be a plan to update app or an open PR... maybe we just chose to roll out Web first then fix App later.

@luacmartins
Copy link
Contributor

luacmartins commented May 3, 2023

This is the expected behavior. We are updating to lower case letters. I have an app PR in review that addresses that.

@luacmartins luacmartins removed the DeployBlockerCash This issue or pull request should block deployment label May 3, 2023
@luacmartins
Copy link
Contributor

Closing this issue since it’s the expected behavior

@marcaaron marcaaron reopened this May 3, 2023
@marcaaron
Copy link
Contributor

Reopening for a second... the expected behavior is for the message to change from capitalized to not capitalized?

@marcaaron
Copy link
Contributor

@dangrous
Copy link
Contributor

dangrous commented May 3, 2023

The optimistic data shall be fixed soon! https://github.com/Expensify/App/pull/17583/files

@kbecciv do you have test steps that specify the capital letter Requested? We'll need to update those, as it will be shifting to always lowercase requested. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants