-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Request Money -The word "Request" in the conversation appears with a small letter #18359
Comments
Triggered auto assignment to @sophiepintoraetz ( |
Bug0 Triage Checklist (Main S/O)
|
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open
|
Triggered auto assignment to @dangrous ( |
asking @luacmartins to check this one out I believe he has the most context |
Yeah basically do we need to update the optimistic data, or do we need to adjust the backend to send a capital letter again? I see it was an intentional choice - https://github.com/Expensify/Web-Expensify/pull/37076/commits/ced6a21b3dca719510fda6e9b290543843e5aed2 - but wondering where that comes from? (and if we update the optimistic data to match, we should also update whatever TestRail it is that says all of these should be capitalized) |
Ah Carlos M is ooo actually. Let's ask in eng chat. |
There might also be a plan to update app or an open PR... maybe we just chose to roll out Web first then fix App later. |
This is the expected behavior. We are updating to lower case letters. I have an app PR in review that addresses that. |
Closing this issue since it’s the expected behavior |
Reopening for a second... the expected behavior is for the message to change from capitalized to not capitalized? |
continuing here -> https://expensify.slack.com/archives/C03TQ48KC/p1683144192710769 |
The optimistic data shall be fixed soon! https://github.com/Expensify/App/pull/17583/files @kbecciv do you have test steps that specify the capital letter |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
Expected Result:
The word "Request" must be displayed in capital letter.
Actual Result:
The word "Request" in the conversation appears with a small letter.
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Version Number: 1.3.9.14
Reproducible in staging?: yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Bug6041541_Recording__2375.mp4
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
View all open jobs on GitHub
The text was updated successfully, but these errors were encountered: