[HOLD for payment 2023-05-16] Unable to use keyboard arrow navigation in the list if open "new chat"

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open https://staging.new.expensify.com/
2. Click on "+" FAB menu icon
3. Click on "New chat"
4. Press CMD+K
5. Press up/down arrows keys in the keyboard to navigate in the chat list

Expected Result:

User is able to navigate in the chat switcher list by using the up/down arrows keys

Actual Result:

Nothing happens when user presses the up/down arrows keys

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.11.2
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Bug6044421__Unable_to_use_keyboard_arrow_navigation_in_the_list_if_open__new_chat_.1.mp4

Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @NicMendonca (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @flodnv (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[Beamanator]

Huh this is weird because if you go directly to "Search" (or "New chat") the arrow keys work just fine, something with pressing "CMD + K" removes the arrow key listener or something

[Beamanator]

And can confirm this is reproducible in staging, and isn't reproducible in production

[Beamanator]

Looks like this could have been caused by #17590 or #18420

Posted in Slack to get some ideas: https://expensify.slack.com/archives/C01GTK53T8Q/p1683551147132719

[azimgd]

👀

[mollfpr]

@Beamanator I checkout to this PR #18273 and is not reproduce.

Screen.Recording.2023-05-08.at.20.35.38.mov

[azimgd]

@Beamanator this looks like a side-effect of listener re-subscription implemented here: #18425

[Beamanator]

@mollfpr thanks so much for checking there!

[Beamanator]

@azimgd Thanks for looking into that! Do you want to suggest a fix for this? :D If not I will look into solving 👍

[azimgd]

PR: #18578

[Beamanator]

@mollfpr or @mananjadhav do you have free time to test & record screenshots for ^ PR?

(@mananjadhav was auto-assigned but since this a deploy blocker I'm hoping to get this resolved quickly)

Also @azimgd thanks for the quick PR! Can you add a few more details WHY that change is needed (in the PR)? I Also added a comment about doing a few more tests for your change

[mollfpr]

@Beamanator Yes, I'm quite free for this 😁

[Beamanator]

Thanks @mollfpr - assigned you to the PR 👍

[aldo-expensify]

Since it is the end of the day for @Beamanator , I'll take over to finish this.

[aldo-expensify]

New PR up: #18599

[aldo-expensify]

Hmm, I see that the problem in the issue seems very similar to #18419

Basically, the BaseOptionsSelector keep consuming events like arrow keys after you navigated to a different view because it remains open in the background.

[sakluger]

Hmm, I see that the problem in the issue seems very similar to #18419

Will the PR here fix that other issue?

[aldo-expensify]

@sakluger nop, I just tested that, but I was thinking that maybe this proposal could fix #18419 and this one.

Anyway... I think we may still want the #18599 changes even if in the future we implement #18419 (comment).

So lets proceed with reviewing #18599, so far it seems to work fine on my end.

[neil-marcellini]

Does this really need to be a deploy blocker? We should probably fix it but it seems like quite an edge case issue.

[aldo-expensify]

Does this really need to be a deploy blocker? We should probably fix it but it seems like quite an edge case issue.

I'm not aware of a criteria based on being an edge case for considering something a deploy blocker or not.

I think we should just review #18599 and proceed if it fixes it.

[aldo-expensify]

#18599 was deployed to staging in version 1.3.11-3. I confirmed that the bug is no longer there:

Screen.Recording.2023-05-08.at.11.22.38.AM.mov

Removing this as a deploy blocker.

[roryabraham]

@aldo-expensify should we close this?

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.12-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix arrow focus shortcut modal local state (v2.0) #18599

If no regressions arise, payment will be issued on 2023-05-16. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@Beamanator / @aldo-expensify] The PR that introduced the bug has been identified. Link to the PR:
• [@Beamanator / @aldo-expensify] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@Beamanator / @aldo-expensify] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@Beamanator / @aldo-expensify] Determine if we should create a regression test for this bug.
• [@Beamanator / @aldo-expensify] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@NicMendonca] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[aldo-expensify]

@aldo-expensify should we close this?

I didn't close it because I'm not sure if there is some compensation to be handled.

[NicMendonca]

@aldo-expensify I am not sure! Can you confirm?

[mollfpr]

I didn't get to review the PR, so I'm not eligible for the compensation.

[NicMendonca]

Thank you for confirming that @mollfpr 🙌