[$500] Workspace - Invite members to workspace error but user can still join the workspace

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open 2 users on 2 browsers
2. B send message to A
3. A create a workspace
4. A invite B and invalid user (+252 3 234211), observed an error appearing in 2 users when inviting
5. A go to announce room and send message
6. From B, Observe that B can access the room

Expected Result:

When the invite user fails, B cannot access the workspace

Actual Result:

B can access the workspace during invite error

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• Windows / Chrome
• MacOS / Desktop

Version Number: 1.3.55-7

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-08-09.at.21.28.40.mov

Gravar.2942.mp4

Expensify/Expensify Issue URL:

Issue reported by: @namhihi237

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1691655815906349

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~017361e55ce3e1ac2d
• Upwork Job ID: 1693979555238805504
• Last Price Increase: 2024-05-02
• Automatic offers:
• s77rt | Reviewer | 102505066
• tienifr | Contributor | 102505069

Issue Owner

Current Issue Owner: @bondydaa

[melvin-bot]

Triggered auto assignment to @laurenreidexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~017361e55ce3e1ac2d

[melvin-bot]

Current assignee @laurenreidexpensify is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (External)

[WaqasIbrahim]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Invited members to a workspace shows an error but the user can still access the workspace.

What is the root cause of that problem?

The issue title is misleading, the cause of the problem is not that the user is not added. The user is added successfully but the malformed phone number is the cause of the error.

API Response:

Error message: "The provided phone number does not match the country you are currently located at, please use your email address instead."

This part assumes that the request failed completely for all users.

App/src/libs/actions/Policy.js

Lines 394 to 399 in 0f68829

	value: _.object(
	accountIDs,
	Array(accountIDs.length).fill({
	errors: ErrorUtils.getMicroSecondOnyxError('workspace.people.error.genericAdd'),
	}),
	),

What changes do you think we should make in order to solve the problem?

You should filter out users and only show error message for users that were failed to add, not to all.

[melvin-bot]

📣 @WaqasIbrahim! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
2. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
3. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[WaqasIbrahim]

Contributor details
Your Expensify account email: waqas.abrahim@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~018d936bc5c4987b6f

[melvin-bot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[s77rt]

@WaqasIbrahim Thanks for the proposal. Indeed the other user seem to "partly" get access to the workspace. I don't see them in the members list but according to the OP video they can access restricted rooms. This should be handled internally.

[s77rt]

@laurenreidexpensify This seems internal. Can you please apple the label?

[WaqasIbrahim]

@s77rt You are welcome. Just a suggestion, UX wise this should be handled the same way internally. I (as a user) should not have to reselect the members and add to workspace if last request failed because of one invalid member.

[melvin-bot]

Current assignee @s77rt is eligible for the Internal assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to @bondydaa (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[laurenreidexpensify]

@bondydaa this one is internal, so adding engineering for extra eyes

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[bondydaa]

still haven't gotten back to this yes, will do so by EOW

[melvin-bot]

@bondydaa, @s77rt, @laurenreidexpensify Eep! 4 days overdue now. Issues have feelings too...

[bondydaa]

sorry jumped into our recent fires so didn't get to this again last week

[mvtglobally]

Issue not reproducible during KI retests. (Third week)

1715968984182.bandicam_2024-05-17_20-00-26-282.mp4

[tienifr]

@mvtglobally It's still reproducible via these steps

[melvin-bot]

@bondydaa, @s77rt, @laurenreidexpensify Huh... This is 4 days overdue. Who can take care of this?

[bondydaa]

We have an internal issue here https://github.com/Expensify/Expensify/issues/386300 to refactor the AddMembersToWorkspace API which should address some of the bigger backend headaches still lingering in this.

but I finally looked at @tienifr 's proposal and lets do it as well to get this working for now with how the API functions.

as we do more 1:1:1 refactors we can continue to improve.

[melvin-bot]

📣 @s77rt 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @tienifr 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[mvtglobally]

Issue not reproducible during KI retests. (Fourth week)

[s77rt]

@tienifr Thanks for the PR. I just retested and noticed that the employees list is now keyed by email instead of account id. This gives us a potential easy solution. In WorkspaceMembersPage if we don't have the employee's personal details, instead of returning early here, we create a fallback details object. That's almost all we have to do. Please test from your end and update your proposal.

[s77rt]

@bondydaa A new solution came to light and also a new BE bug 😅 it should be easy to fix though, the AddMembersToWorkspace response contains 2 onyx updates responsible for the employees list, this should be combined into one. Notice in the below screenshot that the second onyx update is targeting the correct object policy_ID.employeeList while first is targeting directly policy_ID which results in the error not being applied correctly.

[tienifr]

@s77rt The second problem is the error to display. When we invite B and an invalid user (+252 3 234211), the policy.employeeListcontains an invalid user (+252 3 234211) without error. But the error is returned in policy['+252 3 234211@expensify.sms'] (see below image). So currently in the PR, we need to create a requestDataProcessors, which will pick the errors returned in policy['+252 3 234211@expensify.sms'] and add to policy.employeeList['+252 3 234211@expensify.sms']. So the solution is not only what you said above:

In WorkspaceMembersPage if we don't have the employee's personal details, instead of returning early here, we create a fallback details object. That's almost all we have to do.

[s77rt]

@tienifr That's a BE bug #25592 (comment)

[tienifr]

@bondydaa What do you think about this comment?

[tienifr]

@bondydaa Any updates here?

[tienifr]

Still waiting for the response from @bondydaa