Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Benchmark: End-to-End Encryption Library #30341

Closed
robertjchen opened this issue Oct 25, 2023 · 6 comments
Closed

Benchmark: End-to-End Encryption Library #30341

robertjchen opened this issue Oct 25, 2023 · 6 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. NewFeature Something to build that is a new item. Task Weekly KSv2

Comments

@robertjchen
Copy link
Contributor

robertjchen commented Oct 25, 2023

Coming on the heels of: #21144 cc: @roryabraham @chrispader

Now for the fun part! Using the new library, could we perform a quick benchmark of average times of the functionality running in the App (on a various Mobile hardware if that's available).

  • Generating a RSA/Kyber keypair for a user
  • Generating (Kyber) the AES shared key to encrypt a message
  • AES encryption of a typical message, say of 255 characters
  • Decryption (RSA) and Derivation (Kyber) to get the shared AES key
  • AES decryption of the above typical message

Any other timings that would be useful! 😄

After that we can explore a quick in-UI MVP, but we'll draft up the details for that after we get some numbers 🙌

@robertjchen robertjchen added Weekly KSv2 NewFeature Something to build that is a new item. Task Bug Something is broken. Auto assigns a BugZero manager. labels Oct 25, 2023
@melvin-bot melvin-bot bot added Daily KSv2 and removed Daily KSv2 Weekly KSv2 labels Oct 25, 2023
@Expensify Expensify deleted a comment from melvin-bot bot Oct 25, 2023
@Expensify Expensify deleted a comment from melvin-bot bot Oct 25, 2023
@Expensify Expensify deleted a comment from melvin-bot bot Oct 25, 2023
@robertjchen robertjchen self-assigned this Oct 25, 2023
@robertjchen
Copy link
Contributor Author

Hm, can't seem to assign to @chrispader for some reason. Just tagging for now 👍

@chrispader
Copy link
Contributor

I have to comment so you can assign me :)

@chrispader
Copy link
Contributor

Just finished the fist round of benchmarks and gave an update in this comment

cc @robertjchen @roryabraham

Copy link

melvin-bot bot commented Nov 8, 2023

@robertjchen @chrispader this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

@melvin-bot melvin-bot bot added Daily KSv2 Overdue and removed Monthly KSv2 labels Nov 8, 2023
@robertjchen robertjchen added Weekly KSv2 and removed Daily KSv2 labels Nov 13, 2023
@melvin-bot melvin-bot bot removed the Overdue label Nov 13, 2023
@robertjchen
Copy link
Contributor Author

perfect, thanks!! Can't wait to see how those figures look on actual hardware ✨

@melvin-bot melvin-bot bot added the Overdue label Nov 21, 2023
@robertjchen
Copy link
Contributor Author

We got the numbers, closing this out for now!

@melvin-bot melvin-bot bot removed the Overdue label Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. NewFeature Something to build that is a new item. Task Weekly KSv2
Projects
None yet
Development

No branches or pull requests

4 participants