-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Benchmark react-native-encryptify #30523
Benchmark react-native-encryptify #30523
Conversation
…yptify-performance
Updates on benchmarking of the E2E encryption library I now added simple performance metrics for the On all web platforms we can see that load time of the The performance of I also added benchmarks for symmetrical AES functions under heavy load ( In general i can say from repeatedly benchmarking on all platforms, that these benchmarks sometimes differ from time to time by a lot. We might want to test this in some clean and reproducible environment for better metrics too. Lmk if there are any other benchmarks we might need or want! |
@robertjchen @roryabraham just added benchmarks for physical devices now too (iOS and Android)... do we need release/production builds too? |
Thanks, going to play with this locally! By release/production builds, do you mean built without debugging (with potential for more performance improvements)? |
Closing this PR until we further continue working on E2E encryption |
@robertjchen @roryabraham
Details
Measured performance metrics are documented in this comment
Fixed Issues
$ #30341
PROPOSAL:
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop