[HOLD for payment 2024-03-07] Android - Task-Tapping assignee shows infinite loading page

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.44
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Launch app
2. Tap fab-assign task
3. Enter title and tap next
4. Select share somewhere
5. Tap Create task
6. Tap on new task created to open details page
7. Tap assignee

Or

1. Tap settings
2. Tap workspaces----workspace
3. Tap members
4. Tap invite members

Expected Result:

In task details page, tapping assignee must show contacts page
Tapping Workspace invite members must display contacts and must not load infinitely.

Actual Result:

In task details page, tapping assignee shows infinite loading page.
Tapping Workspace invite members is also loading infinitely.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6393505_1708999290340.oz.mp4

Bug6393505_1709001206987.WS_loading.mp4

View all open jobs on GitHub

[melvin-bot]

Unable to auto-create job on Upwork. The BZ team member should create it manually for this issue.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (External)

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Auto-assign attempt failed, all eligible assignees are OOO.

[lanitochka17]

We think that this bug might be related to #vip-vsp
CC @quinthar

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

In task details page, tapping assignee shows infinite loading page.

What is the root cause of that problem?

The didScreenTransitionEnd here on Android is always false, that's because the event here never fires. This transitionEnd has been known to be unreliable, which is why we ditched this approach and used this approach instead to be sure the transition has ended (it has been used in several places as part of the useAutoFocusInput hook)

What changes do you think we should make in order to solve the problem?

We should use this agreed approach to detect transition end in this case too.

We can do that by:

• Extract this logic to a useIsScreenTransitionEnded hook, which will return a isScreenTransitionEnded boolean value indicating if the screen transition has ended
• Use that hook in here and in places that use didScreenTransitionEnd in there, use the boolean returned from the hook instead.
• In here, also use that hook for DRY

What alternative solutions did you explore? (Optional)

We can use the useIsScreenTransitionEnded hook inside the ScreenWrapper itself and pass it down to child components, and not relying on the navigation event any more.

[s77rt]

A regression from #29991.

@hannojg @kirillzyusko This is another case of #37156

[s77rt]

@dukenv0307 Thanks for the proposal.

This transitionEnd has been known to be unreliable

This is not the case. It's not firing only due to a recent navigation change as outlined above ^

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[puneetlath]

PR that caused it was reverted.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.45-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• revert: native stack #37305

If no regressions arise, payment will be issued on 2024-03-07. 🎊

For reference, here are some details about the assignees on this issue:

• @s77rt requires payment (Needs manual offer from BZ)