-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2024-03-07] [$500] Android - Task - Keyboard does not open after selecting task title #37273
Comments
Job added to Upwork: https://www.upwork.com/jobs/~01476b0db32bd2022c |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav ( |
Triggered auto assignment to @alexpensify ( |
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
|
Triggered auto assignment to @madmax330 ( |
We think that this bug might be related to #vip-vsb |
Proposal What is the root cause of that problem? Likely related to the focus management of the input field, which should trigger the keyboard to appear. What changes do you think we should make in order to solve the problem? Check that the input component is configured properly, make sure TextInput isn't being obstructed or improperly managed by layout components. What alternative solutions did you explore? |
📣 @Martin-REI! 📣
|
Contributor details |
✅ Contributor details stored successfully. Thank you for contributing to Expensify! |
ProposalPlease re-state the problem that we are trying to solve in this issue.Task title input is not focused on load What is the root cause of that problem?InputWrapper for TaskTitle page is missing autoFocus prop App/src/pages/tasks/TaskTitlePage.js Line 100 in 668df99
What changes do you think we should make in order to solve the problem?Add autoFocus prop to InputWrapper component in taskTitle page <InputWrapper
autoFocus
InputComponent={TextInput}
role={CONST.ROLE.PRESENTATION}
inputID={INPUT_IDS.TITLE} What alternative solutions did you explore? (Optional)None |
@aswin-s this is deploy blocker. There should be offending PR |
ProposalPlease re-state the problem that we are trying to solve in this issue.The task title field is not focused after opening the task title edit view when creating or editing a task. What is the root cause of that problem?The title input does not get autofocused after the screen is open. What changes do you think we should make in order to solve the problem?We can make use of the +const {inputCallbackRef} = useAutoFocusInput();
<InputWrapper
...
- ref={(el) => {
- if (!el) {
- return;
- }
- if (!inputRef.current && didScreenTransitionEnd) {
- el.focus();
- }
- inputRef.current = el;
-}}
+ ref={inputCallbackRef} We can also update the TaskDescriptionPage to follow this approach. What alternative solutions did you explore? (Optional)None. |
ProposalPlease re-state the problem that we are trying to solve in this issue.Android - Task - Keyboard does not open after selecting task title What is the root cause of that problem?The logic of focus input was added in here: #26634. What changes do you think we should make in order to solve the problem?Use our best pratice by using const {inputCallbackRef} = useAutoFocusInput(); And update our input <InputWrapper ref={inputCallbackRef} /> What alternative solutions did you explore? (Optional) |
ProposalSome formatting updates. |
@situchan - thanks for the summary. @mananjadhav let's review if we should fix this issue here or address it in the respective GHs listed here: We have some proposals here too ready for review. Thanks! |
This fix already reached staging |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.45-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2024-03-07. 🎊 For reference, here are some details about the assignees on this issue:
|
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
Awesome, looks like automation kicked in here. Heads up, I will be offline until Tuesday, March 5, 2024. I will not be actively watching over this GitHub during that period. If anything urgent is needed here, please ask for help in the Open Source Slack Room-- thanks! |
Payment Summary
BugZero Checklist (@alexpensify)
|
Please assign me here for reviewing PR |
@mananjadhav - I reviewed the PR and only see action by @situchan. Can you share the PR related to your actions for a PR related to this GitHub? Thanks! I'm trying to complete the payment process and want to make sure that I'm not missing a C+ review. Thanks! |
@alexpensify here's context |
Yes I didn't work on this issue. The PR was solving multiple regressions, and I was afk. Hence I asked to reassign. |
Thanks for the context! I wasn't aware of the Slack post and wanted to double-check that there wasn't a split here. |
❌ There was an error making the offer to @situchan for the Contributor role. The BZ member will need to manually hire the contributor. |
@situchan - Please accept here: https://www.upwork.com/jobs/~01476b0db32bd2022c After, I can complete the required process. Thanks! Here is the payment summary:
Upwork Job: See above |
All set, everyone has been paid in Upwork here. |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.4.44-0
Reproducible in staging?: Y
Reproducible in production?: N
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal Team
Action Performed:
Expected Result:
The keyboard opens, and the title field is in focus
Actual Result:
The keyboard does not open, and the title field is not in focus
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Bug6393640_1709013065452.screen-20240227-000407.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: