Deploy Checklist: New Expensify 2024-03-06

[github-actions]

Release Version: 1.4.48-0
Compare Changes: production...staging

This release contains changes from the following pull requests:

• Fix receipt image blink when opening it the first time #33860
• feat: add PDFThumbnail to preview PDF receipt #35255
• [TS migration] Migrate 'SettingsSecurity2FA' page to TypeScript #35359
• [No QA] [TS migration] Migrate 'fs.js' mock to TypeScript #35912
• [New architecture] Replace @oguzhnatly/react-native-image-manipulator with expo-image-manipulator #36019
• Create Change-or-add-email-address.md #36699
• pay conditions based on reimbursement settings #36814
• Pass displayed amount to the backend when paying a money request #36904
• [No QA][TS migration] Migrate RequestTest to Typescript #37006
• Fix - Mark the chat as "read" immediately upon switching to the tab #37021
• adds haptic feedback on long press #37108
• Fix workspace system message when contains markdown isn't grayed out #37124
• Add currency to default mileage rate #37128
• Fix - An employee can access in a paid IOU the tag selection menu via a URL request #37176
• Feature: [P2P Distance] Enable P2P/splits in App #37185
• [No QA] [TS Migration] Migrate enhanceParametersTest.js, LocalizeTests.js, nativeVersionUpdaterTest.js, createOrUpdateStagingDeployTest.js, TranslateTest.js test to TypeScript #37208
• Fix console error on dismiss video preview when playing #37259
• fix: Task - Pointer shows up for an archived task when hovering over the edge of the checkbox. #37260
• Fix displaying error message when image has been downloaded #37316
• [TS migration] Migrate 'config.js' test to TypeScript #37432
• Fix: Emoji picker - Highlight is removed from emoji when scrolling up with up key #37439
• Call OpenPolicyCategoriesPage #37457
• Return tags in the order of their orderWeight #37471
• Correct simultaneous logout when the account is closed. #37481
• Hover menu is not dismissed after opening emoji picker #37509
• fix: gesture direction for left modal stack #37601
• Fix optimistic report amount in title #37617
• Back button in SAML page doesn't work to go back to log in page #37618
• Create WorkspaceTagsPage #37621
• fix: no action after swipe down to close action #37630
• Update PurposeForUsingExpensifyPage.tsx #37652
• Fix: add spacing between long category name and category status #37668
• Upgrade react-native-reanimated to 3.7.2 #37679
• Update _routes.yml #37683
• fix: resetting pinchScale.value to 1 when double tap performed #37692
• Update PULL_REQUEST_TEMPLATE.md WRT copy #37699
• Make members page read only #37700
• Create CreateCategoryPage #37704
• Fix able to confirm split a scan request in policy expense chat even though the merchant is empty #37740
• [Snyk] Security upgrade electron-builder from 24.6.4 to 24.13.2 #37744
• [NOQA] Redesign Reassure tests for getOrderedReportIDs #37762
• fix - Hold Request - English content is copied to clipboard when hold request message is Spanish #37769
• Use mandatory survey on HybridApp in addition to web #37784
• Update redirects.csv #37830
• Update redirects.csv #37831

Internal QA:

• Apply onyx updates from push notifications reliably #36047 - @arosiclair
• Add supportal navigation #35410 - @danieldoglas

Deploy Blockers:

• [HOLD for payment 2024-03-14] [$500] Video - App crashes when opening video in full screen while it is still loading #37710
• [HOLD for payment 2024-03-14] [HOLD for payment 2024-03-13] Workspace - "Free" user is able to see "Admin Role" when WS is made as "Default" #37779
• [HOLD for payment 2024-04-30][$500] Tag - Tag in Parent: Child format is displayed as Parent/: Child in Tag list #37847
• [HOLD for payment 2024-03-20] App loads chats on the left with tag list on the right when refreshing tag list #37848
• Profile - Unable to upload profile avatar #37849
• [HOLD for payment 2024-03-25] [$500] Distance confirmation page shows (none) briefly when the map is loading #37850
• Distance - Error shows up when creating p2p distance request #37851
• [$250] PDF receipt preview loads each time visiting 1:1 DM, report and transaction thread #37852
• [$500] New order of tags do not update after reopening confirmation page #37864
• Amount validation is requested on Connect with Plaid after trying to add BA manually #37865
• Pay elsewhere button does not show up for Admin after report approval #37867
• [HOLD for payment 2024-03-20] Tag - Newly added tags aren't displayed under the "Tags" section in workspace settings #37873
• [HOLD for payment 2024-03-19] Tag - Not here page shows up when opening Tag from split details RHP #37886

Deployer verifications:

• I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
• I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
• I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

[luacmartins]

Demoted #37873

[luacmartins]

Demoted #37848

[kavimuru]

Regression TR is 78% progress.
#37692 failing with #36597 in mWeb, known bug checking it off
#36019 failing with #37849
We are still validating other unchecked PRs.

[danieldoglas]

@kavimuru please also test #35410 - we need to test all the flows from OldDot to NewDot on that PR to confirm we didn't break anything.

[arosiclair]

#36047 passes!

[kavimuru]

@danieldoglas

@kavimuru please also test #35410 - we need to test all the flows from OldDot to NewDot on that PR to confirm we didn't break anything.

We do have OD to ND transition regression TR steps. Will that be sufficient?

[danieldoglas]

@kavimuru yes, those should be enough!

[kavimuru]

Regression is 7% left.

#36019 failing with #37849
#37457 failing with repro in PROD checking it off.
#36814 validation pending in desktop, mweb and android
#37021 validation pending in iOS
#37108 validation pending in iOS
#37176 validation pending in iOS and desktop
#37185 validation pending in android and iOS
#37481 validation pending in iOS
#37630 validation pending in iOS
#37652 validation pending in Desktop

[kavimuru]

We are just left with 3% in TR.
unchecked PRs:
#36019 failing with #37849
#36814 failing with #37867
#37108 failing with #37887 repro in PROD chcking it off
#37185 failing with #37851 (closed as this is incomplete feature) - OK to check it off?

[luacmartins]

demoted #37847

[kavimuru]

Regression is completed.

unchecked PRs:
#36019 failing with #37849
#36814 failing with #37867
#37185 failing with #37851 (closed as this is incomplete feature) - OK to check it off?

Open Blockers:
#37849
#37850
#37852

[roryabraham]

#35410 can't be tested on staging until https://github.com/Expensify/Web-Expensify/pull/40720 is on staging, so I'm going to go ahead and check it off. It's good that it didn't appear to cause a regression 🙂

InternalQA will happen with https://github.com/Expensify/Web-Expensify/pull/40720

[roryabraham]

I do see some recent crashes but none in 1.4.48:

[roryabraham]