-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct simultaneous logout when the account is closed. #37481
Correct simultaneous logout when the account is closed. #37481
Conversation
…ut to cleanupSession
…x/36632-simultant-signout
…x/36632-simultant-signout
Reviewer Checklist
Screenshots/VideosAndroid: Nativeandroid-msafari.movAndroid: mWeb Chromeweb-desktop-ios-mchrome.moviOS: Nativeweb-desktop-ios-mchrome.moviOS: mWeb Safariandroid-msafari.movMacOS: Chrome / Safariweb-desktop-ios-mchrome.movMacOS: Desktopweb-desktop-ios-mchrome.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/chiragsalian in version: 1.4.48-0 🚀
|
🚀 Deployed to production by https://github.com/roryabraham in version: 1.4.48-0 🚀
|
@situchan @chiragsalian
Details
This PR will fix the simultaneous signout bug that was blocked by the absence of a null check.
Fixed Issues
$ #36632
PROPOSAL: #36632 (comment)
Tests
Offline tests
Primary Device can't offline, the
Close Account
button will be disabledQA Steps
Same as tests
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
GMT20240229-072827_Clip_Wildan.M.s.Clip.02_29_2024.mp4
Android: mWeb Chrome
GMT20240229-073651_Clip_Wildan.M.s.Clip.02_29_2024.mp4
iOS: Native
GMT20240229-073937_Clip_Wildan.M.s.Clip.02_29_2024.mp4
iOS: mWeb Safari
GMT20240229-074638_Clip_Wildan.M.s.Clip.02_29_2024.mp4
MacOS: Chrome / Safari
GMT20240229-071014_Clip_Wildan.M.s.Clip.02_29_2024.mp4
MacOS: Desktop
GMT20240229-083121_Clip_Wildan.M.s.Clip.02_29_2024.mp4