Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$250] mWeb/Safari - Chat - Space appears above chat header after opening and closing attachment #39065

Closed
1 of 6 tasks
izarutskaya opened this issue Mar 27, 2024 · 29 comments
Closed
1 of 6 tasks
Assignees
Labels
Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Weekly KSv2

Comments

@izarutskaya
Copy link

izarutskaya commented Mar 27, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.57-2
Reproducible in staging?: Y
Reproducible in production?: N
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

  1. Send any image in chat
  2. Open the image and close this image
  3. Observe the chat header in the report

Expected Result:

There should be no extra space at the top above the chat header and below the suggestion to open the new.expensify in the app

Actual Result:

There is an extra space appears above the chat header and below the suggestion to open the new.expensify in the app

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6428725_1711547758276.RPReplay_Final1711547352.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01ac4eb38e7291bc5c
  • Upwork Job ID: 1780691771436589056
  • Last Price Increase: 2024-05-22
Issue OwnerCurrent Issue Owner: @anmurali
@izarutskaya izarutskaya added DeployBlockerCash This issue or pull request should block deployment Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Mar 27, 2024
Copy link

melvin-bot bot commented Mar 27, 2024

Triggered auto assignment to @anmurali (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Mar 27, 2024
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

Copy link

melvin-bot bot commented Mar 27, 2024

Triggered auto assignment to @AndrewGable (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@izarutskaya
Copy link
Author

@anmurali I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

@izarutskaya
Copy link
Author

We think that this bug might be related to #vip-vsb.

@izarutskaya
Copy link
Author

Production

RPReplay_Final1711549477.MP4

@AndrewGable
Copy link
Contributor

#36658 looks like it could be suspect, can someone confirm?

cc @SzymczakJ @puneetlath @s77rt @kubabutkiewicz @BartoszGrajdek

@puneetlath
Copy link
Contributor

Seems likely. Can you please take a look @SzymczakJ?

@s77rt
Copy link
Contributor

s77rt commented Mar 27, 2024

I was not able to reproduce. I doubt it's related to the attachment carousel.

@AndrewGable
Copy link
Contributor

Reproduce at all?

@SzymczakJ
Copy link
Contributor

@AndrewGable I was also not able to reproduce, both locally and on staging.new.expensify.com

@AndrewGable AndrewGable added Daily KSv2 Hourly KSv2 and removed Hourly KSv2 DeployBlockerCash This issue or pull request should block deployment Bug Something is broken. Auto assigns a BugZero manager. labels Mar 28, 2024
@AndrewGable
Copy link
Contributor

OK thanks - @izarutskaya can you try to reproduce once more? And try to find more detailed reproduction steps?

@AndrewGable AndrewGable removed the Hourly KSv2 label Mar 28, 2024
@melvin-bot melvin-bot bot added the Overdue label Apr 1, 2024
@AndrewGable AndrewGable added the Weekly KSv2 label Apr 1, 2024
@AndrewGable
Copy link
Contributor

Agree - I don't see the banner either, we should attempt to reproduce while the banner is up.

@melvin-bot melvin-bot bot added the Overdue label Apr 17, 2024
@AndrewGable AndrewGable added the External Added to denote the issue can be worked on by a contributor label Apr 17, 2024
@melvin-bot melvin-bot bot changed the title mWeb/Safari - Chat - Space appears above chat header after opening and closing attachment [$250] mWeb/Safari - Chat - Space appears above chat header after opening and closing attachment Apr 17, 2024
Copy link

melvin-bot bot commented Apr 17, 2024

Job added to Upwork: https://www.upwork.com/jobs/~01ac4eb38e7291bc5c

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Apr 17, 2024
Copy link

melvin-bot bot commented Apr 17, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @dukenv0307 (External)

@melvin-bot melvin-bot bot added Daily KSv2 Overdue and removed Overdue Weekly KSv2 labels Apr 17, 2024
@anmurali
Copy link

I can't reproduce this either. How do I setup an account such that there is a banner shown on mWeb?

@melvin-bot melvin-bot bot removed the Overdue label Apr 23, 2024
@anmurali anmurali added Weekly KSv2 and removed Daily KSv2 labels Apr 23, 2024
Copy link

melvin-bot bot commented Apr 24, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

1 similar comment
Copy link

melvin-bot bot commented May 1, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@melvin-bot melvin-bot bot added the Overdue label May 1, 2024
@AndrewGable
Copy link
Contributor

I believe you have to go to mWeb on a device that doesn't have the iOS app installed

Copy link

melvin-bot bot commented May 8, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@anmurali
Copy link

IMG_5CCA38E894EE-1
@AndrewGable I still don't see that banner...

@melvin-bot melvin-bot bot removed the Overdue label May 15, 2024
Copy link

melvin-bot bot commented May 15, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@mvtglobally
Copy link

Issue not reproducible during KI retests. (First week)

Copy link

melvin-bot bot commented May 22, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@melvin-bot melvin-bot bot added the Overdue label May 23, 2024
@AndrewGable
Copy link
Contributor

If it's not reproducible anymore, let's just close. It's been hard to reproduce and track down to begin with.

@melvin-bot melvin-bot bot removed the Overdue label May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Weekly KSv2
Projects
None yet
Development

No branches or pull requests

9 participants