Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Awaiting Payment 16th May] [Wave Collect] [Xero] Handle errors in the connections #39726

Closed
lakchote opened this issue Apr 5, 2024 · 14 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 NewFeature Something to build that is a new item.

Comments

@lakchote
Copy link
Contributor

lakchote commented Apr 5, 2024

We need to handle Xero connection errors. More details here.

This will be worked on by SWM engineers, see Slack discussion here.

Until the Xero authorization flow (NewDot issue) is done (which entails NewDot, Web-E and IS changes), we won't be able to work on this yet.

@lakchote lakchote added Weekly KSv2 NewFeature Something to build that is a new item. labels Apr 5, 2024
Copy link

melvin-bot bot commented Apr 5, 2024

@melvin-bot melvin-bot bot added the Overdue label Apr 15, 2024
@lakchote lakchote changed the title [Wave Collect] [Xero] Handle errors in the connections [HOLD #39725] [Wave Collect] [Xero] Handle errors in the connections Apr 15, 2024
@sonialiap
Copy link
Contributor

On hold for #39725

@melvin-bot melvin-bot bot removed the Overdue label Apr 15, 2024
@lakchote
Copy link
Contributor Author

Double-checking with internal engineers, some might be interested to work on this.

@SzymczakJ
Copy link
Contributor

I can take care of that, since I'm already in context because I was doing Xero authorization flow. Could you assign me @mountiny?

@hayata-suenaga
Copy link
Contributor

@lakchote thank you for handling this. I have one question:

Is this about the error handling when connecting to Xero or error handling for invalid configuration combinations?

or is it about error handling for sync errors?

@mountiny
Copy link
Contributor

I think this is purely the connection errors

@lakchote
Copy link
Contributor Author

I think this is purely the connection errors

Yes @hayata-suenaga, as @mountiny said it's purely showing the connection errors and the RBR.

@melvin-bot melvin-bot bot added the Overdue label Apr 30, 2024
@sonialiap
Copy link
Contributor

On hold for #39725

@melvin-bot melvin-bot bot removed the Overdue label May 1, 2024
@lakchote lakchote changed the title [HOLD #39725] [Wave Collect] [Xero] Handle errors in the connections [Wave Collect] [Xero] Handle errors in the connections May 2, 2024
@lakchote
Copy link
Contributor Author

lakchote commented May 2, 2024

Not on hold anymore, cc @SzymczakJ

@lakchote
Copy link
Contributor Author

lakchote commented May 6, 2024

Assigning @mananjadhav as he'll be working on this.

@lakchote lakchote assigned mananjadhav and unassigned SzymczakJ May 6, 2024
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Weekly KSv2 labels May 6, 2024
@mananjadhav
Copy link
Collaborator

@lakchote Added the PR to fix the disconnect Xero.

@trjExpensify
Copy link
Contributor

Deployed to prod 9 hours ago.

@trjExpensify trjExpensify changed the title [Wave Collect] [Xero] Handle errors in the connections [Awaiting Payment 16th May] [Wave Collect] [Xero] Handle errors in the connections May 9, 2024
@trjExpensify trjExpensify removed the Reviewing Has a PR in review label May 9, 2024
@trjExpensify trjExpensify added the Awaiting Payment Auto-added when associated PR is deployed to production label May 9, 2024
@mananjadhav
Copy link
Collaborator

Payout for this will be handled after all Xero issues are done. We can close this after the regression period.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels May 15, 2024
@trjExpensify
Copy link
Contributor

Yep, agreed. Regression period is over, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 NewFeature Something to build that is a new item.
Projects
Archived in project
Development

No branches or pull requests

7 participants