Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-05-10] [Wave Collect] [Xero] Build the Authorization flow #39725

Closed
lakchote opened this issue Apr 5, 2024 · 25 comments
Closed
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 NewFeature Something to build that is a new item.

Comments

@lakchote
Copy link
Contributor

lakchote commented Apr 5, 2024

You need to build the Xero authorization flow, following the steps outlined here.

Issue OwnerCurrent Issue Owner: @johncschuster
@lakchote lakchote added Daily KSv2 NewFeature Something to build that is a new item. labels Apr 5, 2024
Copy link

melvin-bot bot commented Apr 5, 2024

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Apr 5, 2024
Copy link

melvin-bot bot commented Apr 5, 2024

⚠️ It looks like this issue is labelled as a New Feature but not tied to any GitHub Project. Keep in mind that all new features should be tied to GitHub Projects in order to properly track external CAP software time ⚠️

@lakchote lakchote added Daily KSv2 and removed Weekly KSv2 labels Apr 5, 2024
@johncschuster
Copy link
Contributor

@lakchote I'm not familiar with whether or not this can be built by an external contributor. Can you help me understand to whom I should triage this?

@melvin-bot melvin-bot bot added the Overdue label Apr 8, 2024
Copy link

melvin-bot bot commented Apr 8, 2024

@johncschuster Whoops! This issue is 2 days overdue. Let's get this updated quick!

@SzymczakJ
Copy link
Contributor

Hey! I’m Jakub Szymczak from Software Mansion, an expert agency, and I’d like to work on this issue!

@johncschuster
Copy link
Contributor

@lakchote bump! Can I assign this one out to @SzymczakJ?

@melvin-bot melvin-bot bot removed the Overdue label Apr 9, 2024
@lakchote
Copy link
Contributor Author

lakchote commented Apr 10, 2024

@lakchote bump! Can I assign this one out to @SzymczakJ?

Sorry I've just seen your message! Yes, this can be built by an external contributor, you can assign the issue to @SzymczakJ.

Here is the Slack discussion for context, thank you!

Also @SzymczakJ, please be aware of #39955

@lakchote
Copy link
Contributor Author

lakchote commented Apr 10, 2024

Assigned @SzymczakJ now @johncschuster as this PR is a critical one, since it's a requirement of the follow-up PRs for the different flows (Import, Export, Advanced). If we can gain time in making progress here, it'll be greatly beneficial for having momentum.

Thank you for choosing to work on this.

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Apr 22, 2024
@johncschuster
Copy link
Contributor

Bumping for Melvin. Looks like this one is being worked on above.

@mountiny
Copy link
Contributor

PR merged

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Apr 29, 2024
@lakchote
Copy link
Contributor Author

lakchote commented May 3, 2024

It has been deployed to staging and production, closing the issue.

@lakchote lakchote closed this as completed May 3, 2024
@melvin-bot melvin-bot bot removed the Overdue label May 3, 2024
@lakchote lakchote reopened this May 3, 2024
@lakchote
Copy link
Contributor Author

lakchote commented May 3, 2024

It has been deployed to staging and production, closing the issue.

I realised my mistake after, and asked for confirmation with my mentor. Reopening the issue, that overdue label messed with me!

Payment date should be next Friday

cc @johncschuster

@melvin-bot melvin-bot bot added the Overdue label May 6, 2024
Copy link

melvin-bot bot commented May 7, 2024

@mananjadhav, @johncschuster, @lakchote, @mountiny, @SzymczakJ Whoops! This issue is 2 days overdue. Let's get this updated quick!

@mananjadhav
Copy link
Collaborator

@johncschuster This is ready for payout for C+ review.

@melvin-bot melvin-bot bot removed the Overdue label May 7, 2024
@mountiny mountiny changed the title [Wave Collect] [Xero] Build the Authorization flow [HOLD for payment 2024-05-10] [Wave Collect] [Xero] Build the Authorization flow May 8, 2024
@mountiny mountiny added the Awaiting Payment Auto-added when associated PR is deployed to production label May 8, 2024
@mountiny
Copy link
Contributor

mountiny commented May 8, 2024

This was a large PR and @mananjadhav helped to get this done urgently, I think we should pay them $500 for their thorough review @johncschuster

@mananjadhav
Copy link
Collaborator

Thanks @mountiny. Appreciate it. Quick question, this was deployed on production on May 01. Shouldn't it be ready for payout by now?

@mananjadhav
Copy link
Collaborator

Looks like we are at May 10 anyway. @johncschuster quick bump.

@melvin-bot melvin-bot bot added the Overdue label May 10, 2024
Copy link

melvin-bot bot commented May 10, 2024

Payment Summary

Upwork Job

BugZero Checklist (@johncschuster)

  • I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
  • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
  • I have paid out the Upwork contracts or cancelled the ones that are incorrect
  • I have verified the payment summary above is correct

@johncschuster
Copy link
Contributor

Payment summary has been updated (Thanks for the incredible work, @mananjadhav and @SzymczakJ!). Please request $500 in NewDot, @mananjadhav!

@JmillsExpensify
Copy link

$500 approved for @mananjadhav

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 NewFeature Something to build that is a new item.
Projects
Archived in project
Development

No branches or pull requests

6 participants