Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-05-30] [Wave Collect] [Xero] [Export Flow] Create the Preferred exporter select page #39742

Closed
lakchote opened this issue Apr 5, 2024 · 22 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production NewFeature Something to build that is a new item. Reviewing Has a PR in review Weekly KSv2

Comments

@lakchote
Copy link
Contributor

lakchote commented Apr 5, 2024

You need to build the page following the steps outlined here.

This will be worked on by SWM engineers, see Slack discussion here.

Until the Xero authorization flow (NewDot issue) is done (which entails NewDot, Web-E and IS changes), we won't be able to work on this yet.

@lakchote lakchote added Daily KSv2 NewFeature Something to build that is a new item. labels Apr 5, 2024
Copy link

melvin-bot bot commented Apr 5, 2024

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Apr 5, 2024
@stephanieelliott stephanieelliott added the Help Wanted Apply this label when an issue is open to proposals by contributors label Apr 8, 2024
@stephanieelliott
Copy link
Contributor

@lakchote can this be done externally or do we need to pull in an internal engineer for this?

@lakchote lakchote removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Apr 10, 2024
@lakchote
Copy link
Contributor Author

@lakchote can this be done externally or do we need to pull in an internal engineer for this?

This will be worked on by SWM engineers, see Slack discussion here.

I've removed the Help Wanted label as we do not need proposals for it.

Until the Xero authorization flow (NewDot issue) is done (which entails NewDot, Web-E and IS changes), we won't be able to work on this yet.

@stephanieelliott
Copy link
Contributor

stephanieelliott commented Apr 10, 2024

Cool, thanks for clarifying! In that case I'm gonna put this on hold for #39725

@stephanieelliott stephanieelliott changed the title [Wave Collect] [Xero] [Export Flow] Create the Preferred exporter select page [HOLD for 39725] [Wave Collect] [Xero] [Export Flow] Create the Preferred exporter select page Apr 10, 2024
@stephanieelliott
Copy link
Contributor

Still held on #39725

@lakchote
Copy link
Contributor Author

Double-checking with internal engineers, some might be interested to work on this.

@stephanieelliott stephanieelliott added NewFeature Something to build that is a new item. and removed NewFeature Something to build that is a new item. labels Apr 23, 2024
Copy link

melvin-bot bot commented Apr 23, 2024

Triggered auto assignment to @JmillsExpensify (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

@stephanieelliott
Copy link
Contributor

Reapplying the New Feature label to get another BZ member on this while I am OOO til May 2. Thanks @JmillsExpensify -- this is held on the Xero authorization flow but will be worked on either by SWM or internal engineers (context here). Please keep an eye for any movement and I will grab this back from you when I return!

@lakchote lakchote changed the title [HOLD for 39725] [Wave Collect] [Xero] [Export Flow] Create the Preferred exporter select page [Wave Collect] [Xero] [Export Flow] Create the Preferred exporter select page Apr 30, 2024
@lakchote
Copy link
Contributor Author

Yes, we were on hold for #39725 to be merged.

It was merged yesterday. Technically we are able to work on this now.

I'm going to focus today on fixing the remaining bugs for the Xero authorization flow before working on it.

@lakchote lakchote self-assigned this Apr 30, 2024
@stephanieelliott
Copy link
Contributor

I'm back from OOO, thanks for watching this while I was out @JmillsExpensify!

Thanks for the update @lakchote! Just want to clarify -- are you going to work on this one yourself, or should we pull in the SWM engineers per the Slack discussion?

@lakchote
Copy link
Contributor Author

lakchote commented May 3, 2024

I'm back from OOO, thanks for watching this while I was out @JmillsExpensify!

Thanks for the update @lakchote! Just want to clarify -- are you going to work on this one yourself, or should we pull in the SWM engineers per the Slack discussion?

It will be worked on by @hungvu193

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Weekly KSv2 labels May 6, 2024
Copy link

melvin-bot bot commented May 7, 2024

Triggered auto assignment to @stitesExpensify, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@lakchote lakchote assigned lakchote and unassigned stitesExpensify May 7, 2024
@trjExpensify
Copy link
Contributor

Merged into the Xero feature branch

@trjExpensify
Copy link
Contributor

Deployed to staging yesterday.

@lakchote
Copy link
Contributor Author

Assigning @mananjadhav as he'll need to be paid for the C+ review of the linked PR once this hits production and the 7 day regression period passes.

@stephanieelliott
Copy link
Contributor

PR is still on staging.

@stephanieelliott
Copy link
Contributor

Looks like the PR deployed to prod last week, will manually update the title/labels for the 7-day hold.

@stephanieelliott stephanieelliott added the Awaiting Payment Auto-added when associated PR is deployed to production label May 29, 2024
@stephanieelliott stephanieelliott changed the title [Wave Collect] [Xero] [Export Flow] Create the Preferred exporter select page [HOLD for payment 2024-05-30] [Wave Collect] [Xero] [Export Flow] Create the Preferred exporter select page May 29, 2024
Copy link

melvin-bot bot commented May 30, 2024

Payment Summary

Upwork Job

BugZero Checklist (@stephanieelliott)

  • I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
  • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
  • I have paid out the Upwork contracts or cancelled the ones that are incorrect
  • I have verified the payment summary above is correct

@stephanieelliott
Copy link
Contributor

I had to manually create a job on Upwork for this

@stephanieelliott
Copy link
Contributor

Summarizing payment on this issue:

Upwork job is here: https://www.upwork.com/jobs/~017aaac0f9f763d071

@trjExpensify
Copy link
Contributor

... ah, we'll handle the payment for this centrally with the guys working on the feature. We can close this out as the regression period is over!

@stephanieelliott
Copy link
Contributor

Ah cool! Ok Upwork job canceled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production NewFeature Something to build that is a new item. Reviewing Has a PR in review Weekly KSv2
Projects
Status: Done
Development

No branches or pull requests

7 participants