Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-06-06] [$250] [Search v1] Create ReportListItem #39878

Open
luacmartins opened this issue Apr 9, 2024 · 27 comments
Open
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item. Reviewing Has a PR in review

Comments

@luacmartins
Copy link
Contributor

luacmartins commented Apr 9, 2024

Section from design doc

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~019c409bcf645b2946
  • Upwork Job ID: 1790719013023596544
  • Last Price Increase: 2024-05-15
  • Automatic offers:
    • DylanDylann | Contributor | 102482657
Issue OwnerCurrent Issue Owner: @laurenreidexpensify
@luacmartins luacmartins added the Daily KSv2 label Apr 9, 2024
@luacmartins luacmartins self-assigned this Apr 9, 2024
@luacmartins luacmartins changed the title [Search v1] Create ReportListItem [HOLD][Search v1] Create ReportListItem Apr 9, 2024
@melvin-bot melvin-bot bot added the Overdue label Apr 11, 2024
Copy link

melvin-bot bot commented Apr 12, 2024

@luacmartins Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@luacmartins luacmartins added Weekly KSv2 and removed Daily KSv2 labels Apr 14, 2024
@melvin-bot melvin-bot bot removed the Overdue label Apr 14, 2024
@melvin-bot melvin-bot bot added the Overdue label Apr 22, 2024
@luacmartins
Copy link
Contributor Author

On hold

@melvin-bot melvin-bot bot removed the Overdue label Apr 24, 2024
@melvin-bot melvin-bot bot added the Overdue label May 2, 2024
@luacmartins luacmartins changed the title [HOLD][Search v1] Create ReportListItem [Search v1] Create ReportListItem May 6, 2024
@luacmartins
Copy link
Contributor Author

Taking off hold, we'll start implementation shortly.

@melvin-bot melvin-bot bot removed the Overdue label May 8, 2024
@luacmartins luacmartins added NewFeature Something to build that is a new item. Hot Pick Ready for an engineer to pick up and run with labels May 10, 2024
Copy link

melvin-bot bot commented May 10, 2024

Triggered auto assignment to @laurenreidexpensify (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

@luacmartins luacmartins added Daily KSv2 and removed Weekly KSv2 labels May 10, 2024
@luacmartins
Copy link
Contributor Author

I'll work on this one

@luacmartins
Copy link
Contributor Author

I got a draft PR started, but I'll be ooo for 3 days this week, so if someone wants to take over to continue the work, please go ahead.

@luacmartins luacmartins added the External Added to denote the issue can be worked on by a contributor label May 15, 2024
Copy link

melvin-bot bot commented May 15, 2024

Job added to Upwork: https://www.upwork.com/jobs/~019c409bcf645b2946

@melvin-bot melvin-bot bot changed the title [Search v1] Create ReportListItem [$250] [Search v1] Create ReportListItem May 15, 2024
@melvin-bot melvin-bot bot added Overdue Help Wanted Apply this label when an issue is open to proposals by contributors labels May 15, 2024
@laurenreidexpensify
Copy link
Contributor

@WojtekBoman what is the ETA on the PR draft? Thanks

@WojtekBoman
Copy link
Contributor

I'll create a draft PR for that tomorrow :)

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels May 22, 2024
@luacmartins
Copy link
Contributor Author

@nkdengineer are you a member of the C+ team?

Copy link

melvin-bot bot commented May 27, 2024

📣 @DylanDylann 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

@nkdengineer
Copy link
Contributor

Hi @luacmartins I'm not a C+ but there're cases where a C is assigned to do the C+ work on the PR. I've seen one here.

I was under assumption this is a similar case from this comment

@DylanDylann
Copy link
Contributor

@luacmartins Could you give me access to this docs?

@luacmartins
Copy link
Contributor Author

Done!

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels May 30, 2024
@melvin-bot melvin-bot bot changed the title [$250] [Search v1] Create ReportListItem [HOLD for payment 2024-06-06] [$250] [Search v1] Create ReportListItem May 30, 2024
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label May 30, 2024
Copy link

melvin-bot bot commented May 30, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented May 30, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.77-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-06-06. 🎊

For reference, here are some details about the assignees on this issue:

Copy link

melvin-bot bot commented May 30, 2024

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@DylanDylann] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
  • [@laurenreidexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 Daily KSv2 and removed Weekly KSv2 labels Jun 5, 2024
@laurenreidexpensify
Copy link
Contributor

laurenreidexpensify commented Jun 7, 2024

Payment Summary:

@laurenreidexpensify
Copy link
Contributor

@DylanDylann pls advise on regression steps thanks

@nkdengineer
Copy link
Contributor

Hi @laurenreidexpensify I was assigned by mistake so no payment due for me here, I've declined the Upwork offer, thanks!

@luacmartins
Copy link
Contributor Author

No regression steps needed on this one. We'll add them with the project wrap up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item. Reviewing Has a PR in review
Projects
Status: Release 1.5: XeroCon 2024 (June 12th)
Development

No branches or pull requests

7 participants