[HOLD #40565] [$250] Room - Room mention is not copied to clipboard and editor is empty when editing room mention

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.63-0
Reproducible in staging?: Y
Reproducible in production?: N
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

Precondition:

• User has created a few rooms linked to the same workspace.

1. Go to staging.new.expensify.com
2. Go to any room from the precondition.
3. Type # and select a room.
4. Send the message.
5. Right click on the message > Copy to clipboard.
6. Paste the content.
7. Right click on the message > Edit comment.

Expected Result:

In Step 5, the room in the message will be copied.
In Step 7. the room in the editor will be preserved.

Actual Result:

In Step 5, the room in the message is not copied.
In Step 7. the room in the editor is missing.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6453285_1713425267404.room_mention.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01c98cde11a4c25f4e
• Upwork Job ID: 1780934156183453696
• Last Price Increase: 2024-05-16

[melvin-bot]

Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @lakchote (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[izarutskaya]

@JmillsExpensify I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

[izarutskaya]

We think this issue might be related to the #collect project.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01c98cde11a4c25f4e

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Santhosh-Sellavel (External)

[lakchote]

Not a blocker - it's an edge case that only concer room mentions, no core customer functionality is broken.

[ahmedGaber93]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Room - Room mention is not copied to clipboard and editor is empty when editing room mention

What is the root cause of that problem?

we don't handle mention-report in ContextMenuActions.tsx after copy to clipboard pressed, we only handle mention-user

App/src/pages/home/report/ContextMenu/ContextMenuActions.tsx

Lines 395 to 398 in 9b839f4

	content.replace(/(<mention-user>)(.*?)(<\/mention-user>)/gi, (match, openTag, innerContent, closeTag): string => {
	const modifiedContent = Str.removeSMSDomain(innerContent) || '';
	return openTag + modifiedContent + closeTag || '';
	}),

before sending mention report text to backend we format it to be like this <mention-report>#reportName<mention-report/>
but the message html come from backend with this format <mention-report reportID="1234" /> and this format will return empty text after parsing it to text before add it to clipboard here

What changes do you think we should make in order to solve the problem?

we need to handle mention-report in ContextMenuActions.tsx with the same way we used it in mention-user.

to copy the orignal message we need to catch reportID from <mention-report reportID="1234" />, and get reportName then revert it to orignal format before send <mention-report>#reportName<mention-report/>.

for that we need to add this extra replace here

.replace(/<mention-report reportID="(\d*)"\/>/gi, (match, reportID): string => {
   const report = getReport(reportID);

   return `<mention-report>${report?.reportName ?? report?.displayName}<mention-report/>`;
})

and setClipboardMessage will parse the orignal message html and get the massage text and add it to Clipboard

App/src/pages/home/report/ContextMenu/ContextMenuActions.tsx

Lines 43 to 51 in 9b839f4

	function setClipboardMessage(content: string) {
	const parser = new ExpensiMark();
	if (!Clipboard.canSetHtml()) {
	Clipboard.setString(parser.htmlToMarkdown(content));
	} else {
	const plainText = parser.htmlToText(content);
	Clipboard.setHtml(content, plainText);
	}
	}

What alternative solutions did you explore? (Optional)

[lakchote]

@JmillsExpensify I'll be OOO next week until April 29th. Feel free to assign another internal engineer to review if needed.

[Santhosh-Sellavel]

Roomname is copied successfully, but the editor is still empty while editing the room mention

Screen.Recording.2024-04-22.at.1.42.30.AM.mov

[JmillsExpensify]

Interesting, let's keep this open then

[lakchote]

@Santhosh-Sellavel can you take a look at recent comments from @ahmedGaber93 please?

[eh2077]

@lakchote We can put this on hold as discussed here #40477 (comment). We can have a holistic solution to fix them together.

[marcaaron]

@ahmedGaber93 do you think you could drop into the other issue a Problem & Solution statement that summarizes both of these very similar issues and present the holistic plan to fix them?

[ahmedGaber93]

@ahmedGaber93 do you think you could drop into #40477 (comment) a Problem & Solution statement that summarizes both of these very similar issues and present the holistic plan to fix them?

@marcaaron Yes I agree, these are two implementations for one feature, and fixing them together will facilitate the process of testing and discover the possible bugs and fix it.

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot]

@JmillsExpensify, @lakchote, @Santhosh-Sellavel Whoops! This issue is 2 days overdue. Let's get this updated quick!

[eh2077]

I added a summary here #40477 (comment)

[melvin-bot]

@JmillsExpensify, @lakchote, @Santhosh-Sellavel Still overdue 6 days?! Let's take care of this!

[eh2077]

We have updates on the other issue.

[JmillsExpensify]

Thanks, yes updated on the other issue.

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot]

@JmillsExpensify @lakchote @Santhosh-Sellavel this issue is now 4 weeks old, please consider:

• Finding a contributor to fix the bug
• Closing the issue if BZ has been unable to add the issue to a VIP or Wave project
• If you have any questions, don't hesitate to start a discussion in #expensify-open-source

Thanks!

[JmillsExpensify]

Based on the above discussion, should we close this issue or leave it open?

[lakchote]

Based on the above discussion, should we close this issue or leave it open?

Looking at latest @eh2077's comment, we could put this on hold for #40565 to keep track of the issue, and revisit once it's merged?

[JmillsExpensify]

Fine putting it on Hold for now. That PR is being actively worked on.

[JmillsExpensify]

Moved to weekly given the hold

[JmillsExpensify]

Still on hold.