[$250] mWeb/Safari - UI - The top part of the UI is white while the page is loading in dark mode

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.62.17
Reproducible in staging?: Y
Reproducible in production?: N
Found when validating PR : https://github.com/Expensify/Expensify/issues/302570
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

Precondition: Dark mode should be enabled.

1. Open any chat or room
2. Refresh the page

Expected Result:

The whole UI should be in dark mode.

Actual Result:

The top part of the UI is white while the page is loading in dark mode. The issue appears when refreshing any room, or chat, or LHN and when you kill and re-open Safari.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6456678_1713720715815.KRDX1564.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01a67f702d8230d48e
• Upwork Job ID: 1784920320468824064
• Last Price Increase: 2024-04-29
• Automatic offers:
• getusha | Reviewer | 0
• bernhardoj | Contributor | 0

[melvin-bot]

Triggered auto assignment to @grgia (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[izarutskaya]

@johncschuster I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

[mountiny]

This is minor ui bug, lets not block deploy on this given we are close to shipping it

[grgia]

@izarutskaya is this reproducible on the previous version?

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The status bar of the mobile web (safari) is white instead of following the splash screen color.

What is the root cause of that problem?

The status bar color is based on the theme-color value

App/web/index.html

Line 7 in 76d6539

<meta name="theme-color" content="">

Since the value is empty, it just follows the device theme. The status bar is then updated depends on the page every time the nav state changes.

App/src/components/CustomStatusBarAndBackground/index.tsx

Lines 63 to 115 in 76d6539

	const updateStatusBarStyle = useCallback(
	(listenerID?: number) => {
	// Check if this function is either called through the current navigation listener
	// react-navigation library has a bug internally, where it can't keep track of the listeners, therefore, sometimes when the useEffect would re-render and we run navigationRef.removeListener the listener isn't removed and we end up with two or more listeners.
	// https://github.com/Expensify/App/issues/34154#issuecomment-1898519399
	if (listenerID !== undefined && listenerID !== listenerCount.current) {
	return;
	}
	// Set the status bar colour depending on the current route.
	// If we don't have any colour defined for a route, fall back to
	// appBG color.
	let currentRoute: ReturnType<typeof navigationRef.getCurrentRoute> | undefined;
	if (navigationRef.isReady()) {
	currentRoute = navigationRef.getCurrentRoute();
	}
	let newStatusBarStyle = theme.statusBarStyle;
	let currentScreenBackgroundColor = theme.appBG;
	if (currentRoute && 'name' in currentRoute && currentRoute.name in theme.PAGE_THEMES) {
	const pageTheme = theme.PAGE_THEMES[currentRoute.name];
	newStatusBarStyle = pageTheme.statusBarStyle;
	const backgroundColorFromRoute =
	currentRoute?.params && 'backgroundColor' in currentRoute.params && typeof currentRoute.params.backgroundColor === 'string' && currentRoute.params.backgroundColor;
	// It's possible for backgroundColorFromRoute to be empty string, so we must use "||" to fallback to backgroundColorFallback.
	// eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing
	currentScreenBackgroundColor = backgroundColorFromRoute || pageTheme.backgroundColor;
	}
	prevStatusBarBackgroundColor.current = statusBarBackgroundColor.current;
	statusBarBackgroundColor.current = currentScreenBackgroundColor;
	if (currentScreenBackgroundColor !== theme.appBG || prevStatusBarBackgroundColor.current !== theme.appBG) {
	statusBarAnimation.value = 0;
	statusBarAnimation.value = withDelay(300, withTiming(1));
	}
	// Don't update the status bar style if it's the same as the current one, to prevent flashing.
	// Force update if the root status bar is back on active or it won't overwirte the nested status bar style
	if ((!didForceUpdateStatusBarRef.current && !prevIsRootStatusBarEnabled && isRootStatusBarEnabled) || newStatusBarStyle !== statusBarStyle) {
	updateStatusBarAppearance({statusBarStyle: newStatusBarStyle});
	setStatusBarStyle(newStatusBarStyle);
	if (!prevIsRootStatusBarEnabled && isRootStatusBarEnabled) {
	didForceUpdateStatusBarRef.current = true;
	}
	}
	},
	[prevIsRootStatusBarEnabled, isRootStatusBarEnabled, statusBarAnimation, statusBarStyle, theme.PAGE_THEMES, theme.appBG, theme.statusBarStyle],
	);

What changes do you think we should make in order to solve the problem?

Set theme-color initial value to the same as the splash background color, #03D47C.

[johncschuster]

@grgia I've asked your in question in QA

[mvtglobally]

@grgia do you need us to check if it's still repro on the current build ?

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01a67f702d8230d48e

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @getusha (External)

[grgia]

I'm going to make this external

[johncschuster]

Not overdue. This was just made External

[getusha]

@bernhardoj's proposal looks good to me
🎀 👀 🎀 C+ Reviewed!

[melvin-bot]

Current assignee @grgia is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.

[melvin-bot]

@johncschuster, @grgia, @getusha Huh... This is 4 days overdue. Who can take care of this?

[melvin-bot]

📣 @getusha 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @bernhardoj 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[bernhardoj]

PR is ready

cc: @getusha

[melvin-bot]

This issue has not been updated in over 15 days. @johncschuster, @grgia, @bernhardoj, @getusha eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!