[Awaiting checklist] [$250] Distance Request -"Distance" option does not appear in QAB for a gmail account #40790

lanitochka17 · 2024-04-23T13:00:06Z

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.64-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by:
Slack conversation:

Issue found when executing PR #39413

Action Performed:

Open the testing app and login with a gmail account
Submit an expense request using Distance request
Click on FAB menu and select "Record distance" from the QAB

Expected Result:

User should be navigated to the Distance tab

Actual Result:

No Distance tab / user is directed to the Manual request tab

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

Bug6458086_1713825666275.Screen_Recording_2024-04-23_at_1.13.14_AM.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~013f4eac573fdf1cb2
Upwork Job ID: 1783176218489765888
Last Price Increase: 2024-05-01
Automatic offers:

getusha | Reviewer | 0
nkdengineer | Contributor | 0

Issue Owner

Current Issue Owner: @getusha

melvin-bot · 2024-04-23T13:00:16Z

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

lanitochka17 · 2024-04-23T13:00:42Z

@twisterdotcom FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

lanitochka17 · 2024-04-23T13:01:20Z

We think that this bug might be related to #wave-collect - Release 1

allgandalf · 2024-04-23T20:14:31Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

We show P2P details for submit expense distance even when the user is not under beta

What is the root cause of that problem?

In chat options:

App/src/pages/iou/request/MoneyTemporaryForRefactorRequestParticipantsSelector.js

Line 109 in c90b46e

const chatOptions = OptionsListUtils.getFilteredOptions(

We currently only check if the action is not isCategorizeOrShareAction and show the personal contact without checking if p2p beta access is allowed to the user or not:

App/src/pages/iou/request/MoneyTemporaryForRefactorRequestParticipantsSelector.js

Line 136 in c90b46e

!isCategorizeOrShareAction,

App/src/libs/OptionsListUtils.ts

Line 1995 in f421923

includePersonalDetails = true,

Note as comments #40790 (comment), P2P distance is still in beta so we need to hide the personal details in this case

What changes do you think we should make in order to solve the problem?

We have extra checks in place for P2P distance beta already during filtering :

App/src/pages/iou/request/MoneyTemporaryForRefactorRequestParticipantsSelector.js

Line 121 in c90b46e

    
           (canUseP2PDistanceRequests || iouRequestType !== CONST.IOU.REQUEST_TYPE.DISTANCE) && !isCategorizeOrShareAction,

App/src/pages/iou/request/MoneyTemporaryForRefactorRequestParticipantsSelector.js

Line 128 in c90b46e

    
           (canUseP2PDistanceRequests || iouRequestType !== CONST.IOU.REQUEST_TYPE.DISTANCE) && !isCategorizeOrShareAction,

So we should follow the same pattern and update the !isCategorizeOrShareAction, to !isCategorizeOrShareAction && (canUseP2PDistanceRequests || iouRequestType !== CONST.IOU.REQUEST_TYPE.DISTANCE),

--- a/src/pages/iou/request/MoneyTemporaryForRefactorRequestParticipantsSelector.js
+++ b/src/pages/iou/request/MoneyTemporaryForRefactorRequestParticipantsSelector.js

@@ -124,26 +122,14 @@ function MoneyTemporaryForRefactorRequestParticipantsSelector({participants, onF
             undefined,
             undefined,
             undefined,
-            !isCategorizeOrShareAction,
+            !isCategorizeOrShareAction && (canUseP2PDistanceRequests || iouRequestType !== CONST.IOU.REQUEST_TYPE.DISTANCE),
             isCategorizeOrShareAction ? 0 : undefined,
         );

Result:

twisterdotcom · 2024-04-24T16:48:26Z

@neil-marcellini keen for your take on this one, so going to make you the internal reviewer ahead of time. I agree though, it's odd to allow a QAB but not direct to it.

40790.mp4

melvin-bot · 2024-04-24T16:48:37Z

Job added to Upwork: https://www.upwork.com/jobs/~013f4eac573fdf1cb2

melvin-bot · 2024-04-24T16:48:42Z

Triggered auto assignment to Contributor-plus team member for initial proposal review - @getusha (External)

nkdengineer · 2024-04-24T17:23:40Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

The user is able to do P2P distance request even though they're not in P2PDistanceRequests beta.

What is the root cause of that problem?

The problem here is not that "Distance" does not show, it's expected that it will not show if the user is not in P2PDistanceRequests beta (the logic is here).

The issue is the user's able to do P2P distance request in the first place, even though they're not in P2PDistanceRequests beta. Once they did the P2P distance request, of course the "Distance" tab will not show when they attempt again, because the user indeed is not in the P2PDistanceRequests beta. To validate that this is right, can just return true in function canUseP2PDistanceRequests and you'll see that this issue doesn't happen.

The issue is the user's able to do P2P distance request in the first place

The root cause of this is the user can still see the personalDetails options that contain individual users, because we don't have any restriction here if the includeP2P is false. As we can see, we have such restriction here, that's why we don't see any 1-1 chat when trying to do "Distance" request.

What changes do you think we should make in order to solve the problem?

Update this to

const havingLoginPersonalDetails = includeP2P ? options.personalDetails.filter((detail) => !!detail?.login && !!detail.accountID && !detail?.isOptimisticPersonalDetail) : [];

So it will not show any option in Contacts, if includeP2P is false (aka the user is not in P2PDistanceRequests beta)

If there's any other section of options besides personalDetails, that misses this check, we need to add there too.

What alternative solutions did you explore? (Optional)

NA

suneox · 2024-04-24T17:36:18Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

The quick action bar shows the "Record distance" option when a request for OneOnOne, so the user can see and select it.

What is the root cause of that problem?

When buildOnyxDataForMoneyRequest we doesn't pass isOneOnOneChat into buildOnyxDataForMoneyRequest so at this lines we have condition to set quick report action

What changes do you think we should make in order to solve the problem?

We will check condition isOneOnOneChat from report then pass into buildOnyxDataForMoneyRequest

+   const isOneOnOneChat = ReportUtils.isOneOnOneChat(chatReport);
    // STEP 5: Build Onyx Data
    const [optimisticData, successData, failureData] = buildOnyxDataForMoneyRequest(
        chatReport,
        iouReport,
        optimisticTransaction,
        optimisticCreatedActionForChat,
        optimisticCreatedActionForIOUReport,
        iouAction,
        optimisticPersonalDetailListAction,
        reportPreviewAction,
        optimisticPolicyRecentlyUsedCategories,
        optimisticPolicyRecentlyUsedTags,
        isNewChatReport,
        optimisticTransactionThread ?? {},
        optimisticCreatedActionForTransactionThread ?? {},
        shouldCreateNewMoneyRequestReport,
        policy,
        policyTagList,
        policyCategories,
        optimisticNextStep,
+       isOneOnOneChat,
    );

Optional: for out of date data we can hide the quick action menu item at this line when isOneOnOneChat

What alternative solutions did you explore? (Optional)

getusha · 2024-04-26T13:40:47Z

Reviewing proposals.

neil-marcellini · 2024-04-29T16:47:33Z

I'll take a peek in a bit

neil-marcellini · 2024-04-29T17:19:59Z

Here's what's happening.

P2P distance requests are still under beta
It's a front end only beta
There's a bug which allows users not on the beta to select individuals for distance requests
The p2p distance request is successfully created
The QAB is successfully updated, but it also properly prevents the user from submitting a distance request to the individual since they aren't on the beta

The solution should be to fix the bug in point 3. I will see if I can find the issue for that. I can't find any other issue like that. Please lmk if you find something, but otherwise let's fix it here.

Screen.Recording.2024-04-29.at.10.14.26.AM.mov

nkdengineer · 2024-04-29T19:31:31Z

The solution should be to fix the bug in point 3.

@neil-marcellini I agree with this, my proposal is doing just that.

twisterdotcom · 2024-04-29T20:06:33Z

Alright, shall we assign @nkdengineer?

allgandalf · 2024-04-29T20:35:47Z

Updated Proposal

Updated proposal to match new expectations as per comments

c,c, @getusha @neil-marcellini

twisterdotcom · 2024-04-30T08:27:16Z

Okay, this is with you then @getusha.

melvin-bot · 2024-05-01T16:00:12Z

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

getusha · 2024-05-01T17:17:04Z

@GandalfGwaihir's proposal looks good to me.
🎀 👀 🎀 C+ Reviewed!

melvin-bot · 2024-05-01T17:17:15Z

Current assignee @neil-marcellini is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.

allgandalf · 2024-05-13T22:04:57Z

@neil-marcellini , the question here is about the correct solution, can you please confirm whose solution is more correct?

nkdengineer · 2024-05-14T09:45:50Z

@getusha The PR is here.

neil-marcellini · 2024-05-21T19:31:35Z

PR is under review, commenting so this doesn't got overdue.

melvin-bot · 2024-06-11T23:26:27Z

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot · 2024-06-11T23:26:31Z

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.81-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

Hide contact option if we don't include P2P option #42142

If no regressions arise, payment will be issued on 2024-06-18. 🎊

For reference, here are some details about the assignees on this issue:

@getusha requires payment automatic offer (Reviewer)
@nkdengineer requires payment automatic offer (Contributor)

melvin-bot · 2024-06-11T23:26:33Z

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@getusha] The PR that introduced the bug has been identified. Link to the PR:
[@getusha] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@getusha] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@getusha] Determine if we should create a regression test for this bug.
[@getusha] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@twisterdotcom] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

melvin-bot · 2024-06-13T15:24:43Z

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.82-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

Hide contact option if we don't include P2P option #42142

If no regressions arise, payment will be issued on 2024-06-20. 🎊

For reference, here are some details about the assignees on this issue:

@getusha requires payment automatic offer (Reviewer)
@nkdengineer requires payment automatic offer (Contributor)

melvin-bot · 2024-06-13T15:24:44Z

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@getusha] The PR that introduced the bug has been identified. Link to the PR:
[@getusha] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@getusha] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@getusha] Determine if we should create a regression test for this bug.
[@getusha] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@twisterdotcom] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

twisterdotcom · 2024-06-20T11:41:35Z

Payment Summary:

@getusha requires paid $250 here (Reviewer)
@nkdengineer paid $250 here (Contributor)

twisterdotcom · 2024-06-25T17:05:07Z

Bump on this checklist @getusha.

melvin-bot · 2024-06-25T18:02:27Z

@twisterdotcom, @neil-marcellini, @getusha, @nkdengineer Huh... This is 4 days overdue. Who can take care of this?

twisterdotcom · 2024-06-26T10:06:49Z

Bump @getusha.

lanitochka17 added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Apr 23, 2024

melvin-bot bot assigned twisterdotcom Apr 23, 2024

kavimuru mentioned this issue Apr 23, 2024

Deploy Checklist: New Expensify 2024-04-22 #40702

Closed

95 tasks

twisterdotcom assigned neil-marcellini Apr 24, 2024

twisterdotcom added the External Added to denote the issue can be worked on by a contributor label Apr 24, 2024

melvin-bot bot changed the title ~~Distance Request -"Distance" option does not appear in QAB for a gmail account~~ [$250] Distance Request -"Distance" option does not appear in QAB for a gmail account Apr 24, 2024

melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Apr 24, 2024

melvin-bot bot assigned getusha Apr 24, 2024

melvin-bot bot added the Overdue label Apr 29, 2024

melvin-bot bot removed the Overdue label Apr 29, 2024

nkdengineer mentioned this issue May 14, 2024

Hide contact option if we don't include P2P option #42142

Merged

50 tasks

melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels May 14, 2024

melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Jun 11, 2024

melvin-bot bot changed the title ~~[$250] Distance Request -"Distance" option does not appear in QAB for a gmail account~~ [HOLD for payment 2024-06-18] [$250] Distance Request -"Distance" option does not appear in QAB for a gmail account Jun 11, 2024

melvin-bot bot removed the Reviewing Has a PR in review label Jun 11, 2024

melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Jun 13, 2024

melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Jun 18, 2024

twisterdotcom removed the Awaiting Payment Auto-added when associated PR is deployed to production label Jun 20, 2024

melvin-bot bot added the Overdue label Jun 25, 2024

melvin-bot bot removed the Overdue label Jun 26, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Awaiting checklist] [$250] Distance Request -"Distance" option does not appear in QAB for a gmail account #40790

[Awaiting checklist] [$250] Distance Request -"Distance" option does not appear in QAB for a gmail account #40790

lanitochka17 commented Apr 23, 2024 •

edited by twisterdotcom

Loading

melvin-bot bot commented Apr 23, 2024

lanitochka17 commented Apr 23, 2024

lanitochka17 commented Apr 23, 2024

allgandalf commented Apr 23, 2024 •

edited

Loading

twisterdotcom commented Apr 24, 2024

melvin-bot bot commented Apr 24, 2024

melvin-bot bot commented Apr 24, 2024

nkdengineer commented Apr 24, 2024 •

edited

Loading

suneox commented Apr 24, 2024 •

edited

Loading

getusha commented Apr 26, 2024

neil-marcellini commented Apr 29, 2024

neil-marcellini commented Apr 29, 2024

nkdengineer commented Apr 29, 2024

twisterdotcom commented Apr 29, 2024

allgandalf commented Apr 29, 2024 •

edited

Loading

twisterdotcom commented Apr 30, 2024

melvin-bot bot commented May 1, 2024

getusha commented May 1, 2024

melvin-bot bot commented May 1, 2024

allgandalf commented May 13, 2024

nkdengineer commented May 14, 2024

neil-marcellini commented May 21, 2024

melvin-bot bot commented Jun 11, 2024

melvin-bot bot commented Jun 11, 2024

melvin-bot bot commented Jun 11, 2024

melvin-bot bot commented Jun 13, 2024

melvin-bot bot commented Jun 13, 2024

twisterdotcom commented Jun 20, 2024

twisterdotcom commented Jun 25, 2024

melvin-bot bot commented Jun 25, 2024

twisterdotcom commented Jun 26, 2024

[Awaiting checklist] [$250] Distance Request -"Distance" option does not appear in QAB for a gmail account #40790

[Awaiting checklist] [$250] Distance Request -"Distance" option does not appear in QAB for a gmail account #40790

Comments

lanitochka17 commented Apr 23, 2024 • edited by twisterdotcom Loading

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

melvin-bot bot commented Apr 23, 2024

lanitochka17 commented Apr 23, 2024

lanitochka17 commented Apr 23, 2024

allgandalf commented Apr 23, 2024 • edited Loading

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

Result:

twisterdotcom commented Apr 24, 2024

melvin-bot bot commented Apr 24, 2024

melvin-bot bot commented Apr 24, 2024

nkdengineer commented Apr 24, 2024 • edited Loading

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

suneox commented Apr 24, 2024 • edited Loading

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

getusha commented Apr 26, 2024

neil-marcellini commented Apr 29, 2024

neil-marcellini commented Apr 29, 2024

nkdengineer commented Apr 29, 2024

twisterdotcom commented Apr 29, 2024

allgandalf commented Apr 29, 2024 • edited Loading

Updated Proposal

twisterdotcom commented Apr 30, 2024

melvin-bot bot commented May 1, 2024

getusha commented May 1, 2024

melvin-bot bot commented May 1, 2024

allgandalf commented May 13, 2024

nkdengineer commented May 14, 2024

neil-marcellini commented May 21, 2024

melvin-bot bot commented Jun 11, 2024

melvin-bot bot commented Jun 11, 2024

melvin-bot bot commented Jun 11, 2024

melvin-bot bot commented Jun 13, 2024

melvin-bot bot commented Jun 13, 2024

twisterdotcom commented Jun 20, 2024

twisterdotcom commented Jun 25, 2024

melvin-bot bot commented Jun 25, 2024

twisterdotcom commented Jun 26, 2024

lanitochka17 commented Apr 23, 2024 •

edited by twisterdotcom

Loading

allgandalf commented Apr 23, 2024 •

edited

Loading

nkdengineer commented Apr 24, 2024 •

edited

Loading

suneox commented Apr 24, 2024 •

edited

Loading

allgandalf commented Apr 29, 2024 •

edited

Loading