[$250] Onboarding - Infinite skeleton on concierge chat page when deleting a task and going back

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.65-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by:
Slack conversation:

Issue found when executing PR #39687

Action Performed:

1. Navigate to staging.new.expensify.com
2. Sign in with a new Gmail account
3. On the Onboarding select "Track business spend for taxes" as a purpose and click on continue
4. Input first name and last name and click on continue
5. Input a business name and click on continue
6. Open Concierge chat
7. Open "Track an expense" task
8. Delete the task
9. Click on the link on the header to go back to Concierge

Expected Result:

Concierge chat loads without any problem

Actual Result:

Infinite skeleton loading screen is seen

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6460267_1713964177563.bandicam_2024-04-24_15-55-10-302.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01d84dc757a6672e78
• Upwork Job ID: 1784968718723895296
• Last Price Increase: 2024-05-07
• Automatic offers:
• eh2077 | Reviewer | 0

[melvin-bot]

Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

@CortneyOfstad FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[lanitochka17]

We think that this bug might be related to #wave-collect - Release 1

[CortneyOfstad]

Sorry, I was OoO when this was assigned — reviewing everything now!

[CortneyOfstad]

Was able to recreate this, as shown below:

2024-04-29_10-28-05.mp4

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01d84dc757a6672e78

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eh2077 (External)

[eh2077]

Posted on slack to attract proposals

[CortneyOfstad]

Thank you @eh2077!!

[vradriano]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Encountering an infinite skeleton issue when attempting to delete a workspace and then returning to Expensify Concierge.

What is the root cause of that problem?

The problem originates from the completeOnboarding function in src/libs/actions/Report.ts. This function creates task objects from the concierge without assigning a parentReportActionID, leading to object issues when deleting these tasks in the deleteTask function in src/libs/actions/Task.ts. Consequently, when a user deletes one of these tasks created by completeOnboarding it generates malformed objects containing only two parameters: {linkedMetadata: [empty], message: ""}. As a result, when the View attempts to iterate over these objects, it crashes because it is missing required fields and continues to call the `OlderReportActions' route indefinitely, leading to the eternal skeleton.

What changes do you think we should make in order to solve the problem?

The solution involves adding the parameter parentReportActionID generated by taskReportAction to the currentTask object when it's in the process onboarding at the function completeOnboarding. We can't pass it directly because we need to generate the parentReportActionID in the const taskReportAction, then retrieve the value to assign it to the currentTask.

App/src/libs/actions/Report.ts

Lines 3049 to 3074 in 64695c8

	const tasksData = data.tasks.map((task, index) => {
	const currentTask = ReportUtils.buildOptimisticTaskReport(
	actorAccountID,
	undefined,
	targetChatReportID,
	task.title,
	undefined,
	targetChatPolicyID,
	CONST.REPORT.NOTIFICATION_PREFERENCE.HIDDEN,
	);
	const taskCreatedAction = ReportUtils.buildOptimisticCreatedReportAction(targetEmail);
	const taskReportAction = ReportUtils.buildOptimisticTaskCommentReportAction(
	currentTask.reportID,
	task.title,
	0,
	`task for ${task.title}`,
	targetChatReportID,
	actorAccountID,
	index + 3,
	{
	childVisibleActionCount: 2,
	childCommenterCount: 1,
	childLastVisibleActionCreated: DateUtils.getDBTime(),
	childOldestFourAccountIDs: `${actorAccountID}`,
	},
	);

After the line(3074) we can add this line:

currentTask.parentReportActionID = taskReportAction.reportAction.reportActionID 

or for better readability code:

const parentReportActionID = taskReportAction.reportAction.reportActionID 
currentTask.parentReportActionID = parentReportActionID

What alternative solutions did you explore? (Optional)

We also can create a map specifically to assign it to the tasksData. Like this:

tasksData = tasksData.map((taskData, index) => {
	taskData.currentTask.parentReportActionID = taskData.taskReportAction.reportAction.reportActionID;
	return taskData;
});

[melvin-bot]

📣 @vradriano! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[vradriano]

Contributor details
Your Expensify account email: vradriano@hotmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~0153de4aa593214c8f

[melvin-bot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[eh2077]

@vradriano Thanks for your proposal!

I'm not following your root cause analysis. Can you investigate why we have issue for onboarding tasks but normal tasks work fine?

[vradriano]

Proposal

[Updated] #40918 (comment)

[vradriano]

@eh2077 I apologize for the initial analysis misunderstanding. I misunderstood the problem at first, but I hope everything is clear now. Normal tasks are functioning as expected because the function that creates the task object includes code similar to this, ensuring the reportActionID is assigned to the task object.

[CortneyOfstad]

@eh2077 bump on the updated proposal here — thanks!

[eh2077]

Re-reviewing the proposal!

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[eh2077]

@vradriano Thanks for the update! While the updated RCA pointed out the key issue in method completeOnboarding, you omitted the explanations about what causes the infinite skeleton, which was mentioned in your previous draft. So, just a suggestion - in the second section of the proposal, it'll be great to comprehensively explain how the issue is caused instead of just trying to reveal the fix. No worries as it seems this is likely your first contribution to the App. You'll do it better in the future!

I think we can go with @vradriano 's proposal.

🎀👀🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @cristipaval, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

Current assignee @cristipaval is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.

[vradriano]

@eh2077 I was initially hesitant to write a big proposal, so I decided to remove it. Now, as you stated, I've added it again to make it clear. About my PR, if i don't face any issue, i will create it today (May 7th). It's my first one, and i promise will do better in the future. Thanks for the suggestion and for your help.

[eh2077]

@vradriano Please only open the PR after you're assigned by the internal engineer. Let's wait for @cristipaval 's review.

[melvin-bot]

@CortneyOfstad @cristipaval @eh2077 this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[eh2077]

@cristipaval Friendly bump! This is waiting for your review #40918 (comment)

[cristipaval]

Thanks for bumping me!

[melvin-bot]

📣 @eh2077 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @vradriano You have been assigned to this job!
Please apply to the Upwork job and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Once you apply to this job, your Upwork ID will be stored and you will be automatically hired for future jobs!
Keep in mind: Code of Conduct | Contributing 📖

[vradriano]

Hi, i'm going to create the pull request for review today (May 9) if i don't encounter any issues.

UPDATE: I'm setting the native apps to run the tests, so it can take time.

[CortneyOfstad]

Sounds good — thanks @vradriano!

[CortneyOfstad]

Deployed to staging 7 hours ago!

[CortneyOfstad]

We're in a merge freeze until Wednesday, so it will be a bit before this is launched to production

[CortneyOfstad]

Merge freeze is planned to end today 🤞

[vradriano]

Hi @CortneyOfstad, I hope you're well. Since the PR was merged to production #42022 (comment), could i get an update on it?
Thanks!