[HOLD for payment 2024-06-05] [$250] Merge account - Email for merged account is prefixed with 0@ in archived workspace chat

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.65-5
Reproducible in staging?: y
Reproducible in production?: y
Issue reported by: Applause - Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. [Admin] Invite User A and B to the workspace.
3. [Admin] Remove User A from the workspace.
4. [User B] Go to Old Dot.
5. [User B] Merge account with User A.
6. [User B] Return to New Dot.
7. [User B] Open workspace chat with User A (after merging).

Expected Result:

User A email will be displayed correctly in the archived workspace chat.

Actual Result:

User A email is prefixed with 0@ in the archived workspace chat.

Workaround:

n/a

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6461468_1714043719861.bandicam_2024-04-25_19-08-56-249.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01e83a7aa224f88987
• Upwork Job ID: 1785403324396785664
• Last Price Increase: 2024-05-14
• Automatic offers:
• getusha | Reviewer | 0

Issue Owner

Current Issue Owner: @sakluger / @trjExpensify

[melvin-bot]

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[kbecciv]

We think that this bug might be related to #vip-vsb

[kbecciv]

@sakluger FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

[melvin-bot]

@sakluger Huh... This is 4 days overdue. Who can take care of this?

[sakluger]

I wonder if we're looking for the account ID instead of the account email. When merging accounts, both accounts end up under a single account ID. That means that if you try referencing the account ID for the account that was merged into the current one, you won't find it.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01e83a7aa224f88987

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @getusha (External)

[sakluger]

Waiting for proposals.

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[getusha]

Waiting for proposals.

[melvin-bot]

@sakluger @getusha this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[sakluger]

Still waiting for proposals.

[getusha]

@rezkiy37's proposal works well and looks good to me
🎀 👀 🎀 C+ Reviewed!

[melvin-bot]

Triggered auto assignment to @srikarparsi, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[srikarparsi]

@rezkiy37 is from Callstack, could you ping @getusha and myself once the PR is ready :)

[rezkiy37]

Sure! I am opening a PR today.

[rezkiy37]

The PR has been opened.
cc @srikarparsi @getusha

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.76-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Replace the "MERGED_" prefix correctly #42260

If no regressions arise, payment will be issued on 2024-06-05. 🎊

For reference, here are some details about the assignees on this issue:

• @rezkiy37 does not require payment (Contractor)
• @getusha requires payment automatic offer (Reviewer)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@getusha] The PR that introduced the bug has been identified. Link to the PR:
• [@getusha] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@getusha] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@getusha] Determine if we should create a regression test for this bug.
• [@getusha] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@sakluger / @trjExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[sakluger]

@trjExpensify thanks for helping while I was out! I'm back and have unassigned you.

@getusha could you please complete the BZ checklist and accept the Upwork offer?

[getusha]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

1. Check if policy room is archived because of merging #14779
2. Check if policy room is archived because of merging #14779 (comment) commented by other c+ from similar issue
3. N/a
4. Yes, the steps written on the issue description looks good.

[getusha]

@sakluger could we hold the payment here? i am working on moving payments to ND

[sakluger]

@getusha is that being tracked anywhere? Do you know how much longer until you are moved to NewDot payments?

[getusha]

@sakluger here https://expensify.slack.com/archives/C02NK2DQWUX/p1717540786553359?thread_ts=1714605686.678029&cid=C02NK2DQWUX

[sakluger]

Thanks for linking! I'm going to set this issue as a weekly. Could you please leave a comment here when you're ready to accept payment via NewDot?