[HOLD for payment 2024-05-22] [$250] [QBO] Clicking on the hyperlink, the Accounting Page opens without sliding animation

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.67-0
Reproducible in staging?: y
Reproducible in production?: no, new feature
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: applause internal team
Slack conversation:

Action Performed:

1. Go to URL https://staging.new.expensify.com/

2. Login with any account

3. Go to the Workspace editor/settings page

4. Enable Tags on the More Features page

5. Enable accounting on the More Features page

6. Connect to QBO on the More Features page

7. Go back to the Tags Screen again

8. Click the hyperlink in the text

Expected Result:

Accounting Page opens with a sliding animation

Actual Result:

Accounting Page opens without sliding animation

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6463945_1714246485126.video_2024-04-27_22-21-37.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~011364a839038cebec
• Upwork Job ID: 1785028608866394112
• Last Price Increase: 2024-04-29
• Automatic offers:
• ahmedGaber93 | Reviewer | 0
• gijoe0295 | Contributor | 0

Issue Owner

Current Issue Owner: @slafortune

[melvin-bot]

Triggered auto assignment to @slafortune (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @yuwenmemon (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[m-natarajan]

@yuwenmemon FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

[m-natarajan]

We think this bug might be related to #wave-collect - Release 1

[francoisl]

cc @aldo-expensify @hayata-suenaga if you have an idea

[aldo-expensify]

Can't reproduce in MacOs WEB

from the video it looks like the animation is there, but it may be slow? I'm going to try to reproduce in android web

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~011364a839038cebec

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ahmedGaber93 (External)

[mountiny]

This is not a blocker since the accounting is still behind beta

[gijoe0295]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Accounting Page opens without sliding animation

What is the root cause of that problem?

We do not configure animation for Stack screen options

App/src/libs/Navigation/AppNavigator/ModalStackNavigators/WorkspaceSettingsModalStackNavigator.tsx

Line 9 in ff368b8

const screenOptions = useModalScreenOptions((styles) => ({cardStyle: styles.navigationScreenCardStyle, headerShown: false}));

Note that navigating from Workspace initial page to each feature page has animation thanks to the settings:

App/src/libs/Navigation/AppNavigator/Navigators/FullScreenNavigator.tsx

Line 19 in 5521a19

const screenOptions = getRootNavigatorScreenOptions(isSmallScreenWidth, styles, StyleUtils);

But navigating between these feature screens do not due to the above explanation.

What changes do you think we should make in order to solve the problem?

Configure the screen to only enable animation on small screen devices:

const screenOptions = useModalScreenOptions((styles) => ({
    cardStyle: styles.navigationScreenCardStyle,
    headerShown: false,
    cardStyleInterpolator: isSmallScreenWidth ? CardStyleInterpolators.forHorizontalIOS : undefined,
}));

What alternative solutions did you explore? (Optional)

We can reuse the modal navigator options from Workspace root navigators:

App/src/libs/Navigation/AppNavigator/Navigators/FullScreenNavigator.tsx

Line 19 in 5521a19

const screenOptions = getRootNavigatorScreenOptions(isSmallScreenWidth, styles, StyleUtils);

App/src/libs/Navigation/AppNavigator/Navigators/FullScreenNavigator.tsx

Line 31 in 5521a19

options={screenOptions.centralPaneNavigator}

[ahmedGaber93]

@gijoe0295 Thanks for the proposal.

Your RCA is correct, we don't have cardStyleInterpolator in WorkspaceSettingsModalStackNavigator screenOptions, so when we navigate between two screens, and the both is under this Navigator like from Tags to Accounting, it will finish without animation.

And this is different from when we navigate from workspace settings to Accounting (works well), because it uses the parent screenOptions here.

App/src/libs/Navigation/AppNavigator/Navigators/FullScreenNavigator.tsx

Lines 31 to 32 in ff368b8

	options={screenOptions.centralPaneNavigator}
	component={ModalStackNavigators.WorkspaceSettingsModalStackNavigator}

@gijoe0295's proposal main/alternative solution will fix the issue, but I am lean to the alternative solution which use screenOptions.centralPaneNavigator like what we use in parent level (in the above code), and also because this Navigator is displayed in center pane area.

🎀 👀 🎀 C+ reviewed

[melvin-bot]

Current assignee @yuwenmemon is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.

[mvtglobally]

Issue not reproducible during KI retests. (First week)

[melvin-bot]

@yuwenmemon, @slafortune, @ahmedGaber93 Eep! 4 days overdue now. Issues have feelings too...

[gijoe0295]

Reproducible:

Screen.Recording.2024-05-07.at.09.59.00-source.mov

[gijoe0295]

@yuwenmemon Could you check for assignment please?

[melvin-bot]

📣 @ahmedGaber93 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @gijoe0295 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[yuwenmemon]

@gijoe0295 any update here?

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.73-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: no animation between workspace feature pages #41950

If no regressions arise, payment will be issued on 2024-05-22. 🎊

For reference, here are some details about the assignees on this issue:

• @ahmedGaber93 requires payment automatic offer (Reviewer)
• @gijoe0295 requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@ahmedGaber93] The PR that introduced the bug has been identified. Link to the PR:
• [@ahmedGaber93] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@ahmedGaber93] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@ahmedGaber93] Determine if we should create a regression test for this bug.
• [@ahmedGaber93] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@slafortune] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[slafortune]

Paid!