Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$250] Chats don’t load when logging in using Google SSO from public room banner. #41246

Closed
1 of 6 tasks
m-natarajan opened this issue Apr 29, 2024 · 71 comments
Closed
1 of 6 tasks
Assignees
Labels
AutoAssignerNewDotQuality Used to assign quality issues to engineers Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Internal Requires API changes or must be handled by Expensify staff Reviewing Has a PR in review

Comments

@m-natarajan
Copy link

m-natarajan commented Apr 29, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.67-2
Reproducible in staging?: Yes
Reproducible in production?: yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @garrettmknight
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1714391455919649

Action Performed:

  1. Go to staging on Chrome - log out if you need to
  2. Access public room - https://staging.new.expensify.com/r/2376199970894587
  3. Navigate to the self DM that populates in LHN
  4. Click ‘Sign in’ in the banner
  5. Sign in w/ Google

Expected Result:

Your signed in profile’s chats load

Actual Result:

No additional chats load, ‘Hmm…’ flashes

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

don.t.load.google.sso.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0140408c8876b6a1dd
  • Upwork Job ID: 1785085627943718912
  • Last Price Increase: 2024-05-14
  • Automatic offers:
    • alitoshmatov | Reviewer | 0
Issue OwnerCurrent Issue Owner: @cristipaval
@m-natarajan m-natarajan added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Apr 29, 2024
Copy link

melvin-bot bot commented Apr 29, 2024

Triggered auto assignment to @lschurr (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@lschurr lschurr added the External Added to denote the issue can be worked on by a contributor label Apr 29, 2024
@melvin-bot melvin-bot bot changed the title High:Chats don’t load when logging in using Google SSO from public room banner. [$250] High:Chats don’t load when logging in using Google SSO from public room banner. Apr 29, 2024
Copy link

melvin-bot bot commented Apr 29, 2024

Job added to Upwork: https://www.upwork.com/jobs/~0140408c8876b6a1dd

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Apr 29, 2024
Copy link

melvin-bot bot commented Apr 29, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @alitoshmatov (External)

@nitinigi2
Copy link

Just add a page reload once user's SSO signIn is done. That will do the job.

Copy link

melvin-bot bot commented Apr 30, 2024

📣 @nitinigi2! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

  1. Make sure you've read and understood the contributing guidelines.
  2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
  3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
  4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
    Screen Shot 2022-11-16 at 4 42 54 PM
    Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

@melvin-bot melvin-bot bot added the Overdue label May 2, 2024
@lschurr
Copy link
Contributor

lschurr commented May 2, 2024

Hi @alitoshmatov - Can you take a looksie at this one?

@melvin-bot melvin-bot bot removed the Overdue label May 2, 2024
@alitoshmatov
Copy link
Contributor

Reproduced, couldn't find root cause yet

Copy link

melvin-bot bot commented May 7, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@melvin-bot melvin-bot bot added the Overdue label May 7, 2024
@lschurr
Copy link
Contributor

lschurr commented May 8, 2024

Any update @alitoshmatov? Are we just waiting for proposals?

@melvin-bot melvin-bot bot removed the Overdue label May 8, 2024
@alitoshmatov
Copy link
Contributor

Yes waiting for proposals here

@melvin-bot melvin-bot bot added the Overdue label May 10, 2024
@lschurr
Copy link
Contributor

lschurr commented May 10, 2024

Still waiting on proposals.

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels May 10, 2024
@lschurr
Copy link
Contributor

lschurr commented May 13, 2024

Still waiting on proposals.

@melvin-bot melvin-bot bot removed the Overdue label May 13, 2024
Copy link

melvin-bot bot commented May 13, 2024

@lschurr @alitoshmatov this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

Copy link

melvin-bot bot commented May 14, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@rezkiy37
Copy link
Contributor

Hi, I’m Michael (Mykhailo) from Callstack and I would like to work on this issue.

@jasperhuangg
Copy link
Contributor

Hmm my plate is pretty full at the moment, sorry!

@jasperhuangg jasperhuangg removed their assignment Jul 15, 2024
@melvin-bot melvin-bot bot added the Overdue label Jul 17, 2024
@lschurr lschurr removed the Weekly KSv2 label Jul 17, 2024
@lschurr
Copy link
Contributor

lschurr commented Jul 17, 2024

Talking in the original Slack thread - Still trying to get an engineer assigned. https://expensify.slack.com/archives/C049HHMV9SM/p1714391455919649

@melvin-bot melvin-bot bot removed the Overdue label Jul 17, 2024
@puneetlath puneetlath added AutoAssignerNewDotQuality Used to assign quality issues to engineers and removed AutoAssignerNewDotQuality Used to assign quality issues to engineers labels Jul 18, 2024
Copy link

melvin-bot bot commented Jul 18, 2024

Triggered auto assignment to @cristipaval (AutoAssignerNewDotQuality)

@cristipaval cristipaval removed Weekly KSv2 Hot Pick Ready for an engineer to pick up and run with labels Jul 22, 2024
@cristipaval
Copy link
Contributor

I'll look into this one today.

@melvin-bot melvin-bot bot removed the Overdue label Jul 22, 2024
@garrettmknight
Copy link
Contributor

I can't reproduce this anymore - the original link to the public room is on a deleted workspace so I used a new public room.

  1. Go to staging on Chrome - log out if you need to
  2. Access public room - https://staging.new.expensify.com/r/6997181192654972
  3. Navigate to the self DM that populates in LHN
  4. Click ‘Sign in’ in the banner
  5. Sign in w/ Google
Screen.Recording.2024-07-23.at.2.48.14.PM.mov

@m-natarajan
Copy link
Author

Issue reproducible

retest.41246.mp4

@melvin-bot melvin-bot bot added the Overdue label Jul 24, 2024
@cristipaval
Copy link
Contributor

my top priority today. I'll first try to reproduce in my local env.

@melvin-bot melvin-bot bot removed the Overdue label Jul 25, 2024
@puneetlath
Copy link
Contributor

Wait, I don't follow. From looking at that video, it seems like everything worked, no?

@cristipaval
Copy link
Contributor

As far as I understand, the problem is that the chats that should come in the LHN don't appear.

@puneetlath
Copy link
Contributor

Ohh I see.

@cristipaval
Copy link
Contributor

Okay, interesting bug! The app's wrong behavior is because we haven't implemented anonymous account claiming when signing with Google/Apple SSO. It was implemented only for regular sign-in.

The backend PRs are ready for review: Web-E and Auth.

@cristipaval cristipaval added the Reviewing Has a PR in review label Jul 25, 2024
@cristipaval
Copy link
Contributor

The fix is in production. Is there any payment due for this issue or should we just close?

@rezkiy37
Copy link
Contributor

rezkiy37 commented Aug 2, 2024

I am a contractor from Callstack. So no payments for me.

@lschurr
Copy link
Contributor

lschurr commented Aug 2, 2024

I think we're good to close. Thanks @cristipaval!

@lschurr lschurr closed this as completed Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AutoAssignerNewDotQuality Used to assign quality issues to engineers Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Internal Requires API changes or must be handled by Expensify staff Reviewing Has a PR in review
Projects
Development

No branches or pull requests