-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2024-06-05] [$250] Android - Composer - Draft text reappears after clearing the compose box and navigating back #41499
Comments
Triggered auto assignment to @kadiealexander ( |
@kadiealexander FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors |
We think that this bug might be related to #vip-vsp |
ProposalPlease re-state the problem that we are trying to solve in this issue.The draft text isn't cleared when we delete the message from another report screen. What is the root cause of that problem?When we leave a thread, it will navigate to the most recent report (except the current report). App/src/libs/actions/Report.ts Lines 2508 to 2515 in 7483d10
So, now there are 2 same reports in the navigation stack. If we clear the composer message from the 2nd report screen and go back, the 1st report screen will still show the composer message. It's because the onyx draft message and the composer message state aren't synchronized. This doesn't happen on other platforms because we have an effect to sync it. App/src/pages/home/report/ReportActionCompose/SilentCommentUpdater/index.tsx Lines 25 to 37 in 7483d10
But we don't have it for Android (it was removed in #32799) App/src/pages/home/report/ReportActionCompose/SilentCommentUpdater/index.android.tsx Lines 16 to 23 in 7483d10
What changes do you think we should make in order to solve the problem?We can update the navigate to the most recent report logic to just use goBack with the report screen as the fallback App/src/libs/actions/Report.ts Lines 2508 to 2515 in 7483d10
This will make sure we won't have 2 same report screens in the stack, so we don't need to sync the composer message state. |
Job added to Upwork: https://www.upwork.com/jobs/~01321f2f43059fc592 |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @mollfpr ( |
@mollfpr please review the proposal above, thanks! |
@bernhardoj I don't understand the changes you suggest, the permalink you attach already uses |
|
@mollfpr, @kadiealexander Whoops! This issue is 2 days overdue. Let's get this updated quick! |
The proposal from @bernhardoj makes sense to me and I have tested the solution it's fixed the issue. 🎀 👀 🎀 C+ reviewed! |
Triggered auto assignment to @NikkiWines, see https://stackoverflow.com/c/expensify/questions/7972 for more details. |
Yep, agreed - thanks for the proposal @bernhardoj 🙇 |
📣 @bernhardoj 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app! Offer link |
PR is ready cc: @mollfpr |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.76-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2024-06-05. 🎊 For reference, here are some details about the assignees on this issue:
|
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
Payouts due:
Upwork job is here. |
@mollfpr please don't forget about the checklist! |
@mollfpr bump! |
Sorry for the delay 🙏
I couldn't trace the offending PR.
The regression step should be enough.
|
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.4.69-2
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team
Action Performed:
Expected Result:
The compose box doesn't contain any draft text
Actual Result:
The compose box contains the previously cleared draft text
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
Bug6468639_1714636140879.Screen_Recording_20240502_104349_New_Expensify.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @mollfprThe text was updated successfully, but these errors were encountered: