[$250] iOS - Thread - Chat is scrolled up when opening message in thread

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.70-0
Reproducible in staging?: y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @danielrvidal
Slack conversation: expensify.slack.com/archives/C049HHMV9SM/p1714137578957479

Action Performed:
Launch New Expensify app.
Go to chat.
Send a message.
Long tap on the message > Reply in thread.
Expected Result:
The chat will be scrolled down with keyboard open and compose box focussed

Actual Result:
The chat view is at the top in the thread and keyboard is not open

Workaround:
unknown

Platforms:
Which of our officially supported platforms is this issue occurring on?

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidence

Bug6469277_1714677182947.RPReplay_Final1714676988.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @thesahindia

[melvin-bot]

Triggered auto assignment to @francoisl (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @kevinksullivan (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[m-natarajan]

@kevinksullivan FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[francoisl]

Something kind of similar is already happening on the production version, where the view doesn't scroll down after you send a new message. The keyboard not opening in this case looks is not reproducible on production though, let's see if we can identify the root cause.

Screen.Recording.2024-05-02.at.1.12.29.PM.mov

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01d93082b948cabfef

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia (External)

[francoisl]

Tested locally against the current production version 1.4.69-2 and the keyboard also doesn't open on new threads, so it doesn't appear to be a regression in the current checklist. I also can't consistently reproduce the issue where the initial thread view isn't scrolled, which makes it hard to identify when the issue started happening.

Going to demote for now and keep open as an external issue.

[mosesbabu]

Thread - Chat is scrolled up when opening message in thread
After looking into the issue with the chat feature in the Expensify app, I've come up with a list of probable causes and some suggestions for fixing them.

1. UI/UX Implementation: It seems like the design of our reply feature might be causing problems with scrolling and keyboard behavior. I'll review the design and make sure it handles these interactions properly. I'll also test it thoroughly to ensure it works well on different devices.
2. Event Handling: I think there might be some issues with how our app responds to long-taps on messages to start a reply. I'll double-check the event handlers and make sure they're triggering the right actions.
3. Keyboard Management: There could be some issues with how the keyboard is managed when someone starts a reply. I'll review the logic behind this and ensure the keyboard opens up correctly with the message box focused. I'll test it across different parts of the app to make sure it's consistent.
4. Platform-Specific Behavior: It's possible that the problem is showing up differently depending on whether users are on Android, iOS, or the web. I'll test the chat feature on all supported platforms to identify any platform-specific issues. I'll then implement fixes or workarounds to ensure a consistent experience.
5. Dependency Compatibility: there might also be some compatibility issues with the dependencies or libraries we're using in the app. I'll review them and make sure they're compatible with the platforms and versions supported. If needed, I'll update or replace any problematic dependencies.
   By addressing these potential causes and implementing the suggested fixes, I believe i can resolve the issue with the chat feature and provide a better experience for our users.

[melvin-bot]

📣 @mosesbabu! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[mosesbabu]

Contributor details
Your Expensify account email: mosesarara@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~019b1a49c108f99151

[melvin-bot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[bernhardoj]

@francoisl the keyboard doesn't open is being handled in #41402

[mosesbabu]

So is the issue being looked into or I can take a look as a contributor

…

On Friday 3 May 2024, Bernhard Owen Josephus ***@***.***> wrote: @francoisl <https://github.com/francoisl> the keyboard doesn't open is being handled in #41402 <#41402> — Reply to this email directly, view it on GitHub <#41532 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AKQTBI4PFHGE7FMV5KI2UTDZAM237AVCNFSM6AAAAABHEKJF4SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOJSGQ2DMMJSGI> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[cupliz]

Contributor details
Your Expensify account email: iyan.cupliz@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~0134106ade17d77663

[melvin-bot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[melvin-bot]

@francoisl, @kevinksullivan, @thesahindia Huh... This is 4 days overdue. Who can take care of this?

[mosesbabu]

I can take on it

…

On Wed, May 8, 2024, 9:15 PM melvin-bot[bot] ***@***.***> wrote: @francoisl <https://github.com/francoisl>, @kevinksullivan <https://github.com/kevinksullivan>, @thesahindia <https://github.com/thesahindia> Huh... This is 4 days overdue. Who can take care of this? — Reply to this email directly, view it on GitHub <#41532 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AKQTBI6N3T3GAFDEKFRMDO3ZBJTVJAVCNFSM6AAAAABHEKJF4SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMBRGE2TIMZVGU> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[mallenexpensify]

@thesahindia , can you review the above and provide an update plz?

[kevinksullivan]

Also @mosesbabu can you please use the proposal template format and repost your proposal?

[kevinksullivan]

Not overdue melv.

[melvin-bot]

@francoisl, @kevinksullivan, @thesahindia 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[francoisl]

Can we confirm if this is still reproducible? It looks like it's fixed for me on v1.4.72-1

Screen.Recording.2024-05-10.at.3.11.19.PM.mov

[mvtglobally]

Issue not reproducible during KI retests. (First week)

[melvin-bot]

@francoisl, @kevinksullivan, @thesahindia 10 days overdue. Is anyone even seeing these? Hello?

[mosesbabu]

Is it assigned if not I can look at it

…

On Tue, May 14, 2024, 9:17 PM melvin-bot[bot] ***@***.***> wrote: @francoisl <https://github.com/francoisl>, @kevinksullivan <https://github.com/kevinksullivan>, @thesahindia <https://github.com/thesahindia> 10 days overdue. Is anyone even seeing these? Hello? — Reply to this email directly, view it on GitHub <#41532 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AKQTBIYDO2SQ3VS7KF4J7FTZCJIMBAVCNFSM6AAAAABHEKJF4SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMJQHA2DANRWGM> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[francoisl]

Hi @mosesbabu, no the issue is not assigned, but for the future please review https://github.com/Expensify/App/blob/main/contributingGuides/CONTRIBUTING.md to see how to make proposals. Thanks!

That said, the issue can't be reproduced anymore, so I'm going to close this.