[Wave Collect] [Xero] Fix the ConnectionLayout component

[lakchote]

Problem

The ConnectionLayout component has some extra padding issues which prevent other PRs from reusing it.

Please see discussion here.

Solution

Let's fix the component and refactor the other Xero PRs to use it.

[hungvu193]

Taking a look 👀

[melvin-bot]

Triggered auto assignment to @carlosmiceli, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[carlosmiceli]

Hey @lakchote, sorry to bother you, but do I need to do something here?It seems reviewed and merged, right?

[lakchote]

Hey @lakchote, sorry to bother you, but do I need to do something here?It seems reviewed and merged, right?

Hi @carlosmiceli, yes nothing to do on your part here! You shouldn't have been assigned, I'm correcting the assignees list.

Also, not a blocker #41754 (comment)

[trjExpensify]

#41561 - deployed to prod 9 hours ago
#41660 - deployed to prod 9 hours ago
#41664 - deployed to staging 9 hours ago

Are payments going to be due here or is this just a regression clean-up issue from the original?

[lakchote]

#41561 - deployed to prod 9 hours ago #41660 - deployed to prod 9 hours ago #41664 - deployed to staging 9 hours ago

Are payments going to be due here or is this just a regression clean-up issue from the original?

These are just follow-up clean ups/regressions fixes. No payments due here, in my opinion.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.72-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Add ability to use View in ConnectionLayout #41664

If no regressions arise, payment will be issued on 2024-05-20. 🎊

For reference, here are some details about the assignees on this issue:

• @hungvu193 requires payment (Needs manual offer from BZ)

[melvin-bot]

Issue is ready for payment but no BZ is assigned. @abekkala you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!

[melvin-bot]

Payment Summary

Upwork Job

• ROLE: @hungvu193 paid $(AMOUNT) via Upwork (LINK)

BugZero Checklist (@abekkala)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[abekkala]

@lakchote
I'm assuming Melvin is wrong, and payments are not actually due for anyone?

comment:

These are just follow-up clean ups/regressions fixes. No payments due here, in my opinion.

[hungvu193]

Yeah, no payment needed here

@lakchote I'm assuming Melvin is wrong, and payments are not actually due for anyone?

comment:

These are just follow-up clean ups/regressions fixes. No payments due here, in my opinion.

[lakchote]

@lakchote I'm assuming Melvin is wrong, and payments are not actually due for anyone?

Yes, as @hungvu193 just said above, no payment is due here. Thank you!

[melvin-bot]

@hungvu193, @lakchote Whoops! This issue is 2 days overdue. Let's get this updated quick!

[lakchote]

Closing the issue, no payment due.