Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$125] [TS migration] Migrate str to Typescript (expensify-common) #42246

Closed
blazejkustra opened this issue May 16, 2024 · 13 comments
Closed

[$125] [TS migration] Migrate str to Typescript (expensify-common) #42246

blazejkustra opened this issue May 16, 2024 · 13 comments
Assignees
Labels
External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item. Typescript Migration Weekly KSv2

Comments

@blazejkustra
Copy link
Contributor

blazejkustra commented May 16, 2024

Typescript migration (expensify-common)

Make sure you read through our TypeScript's style guide before you start working on this migration issue.

Files

lib/str.js

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01eab386dd14c7df3a
  • Upwork Job ID: 1791121961019691008
  • Last Price Increase: 2024-05-16
Issue OwnerCurrent Issue Owner: @sobitneupane
@blazejkustra blazejkustra added Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 labels May 16, 2024
Copy link

melvin-bot bot commented May 16, 2024

Triggered auto assignment to @MitchExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@blazejkustra
Copy link
Contributor Author

I got approval from @roryabraham to create this issue on #typescript-new-expensify channel here. Let's add it to Typescript project and change labels as this is not a bug, thanks!

@ShridharGoel
Copy link
Contributor

I would like to pick this.

@blazejkustra
Copy link
Contributor Author

I would like to pick this.

@ShridharGoel I think we'll handle this one internally/by agency.

@roryabraham roryabraham added Typescript Migration NewFeature Something to build that is a new item. and removed Bug Something is broken. Auto assigns a BugZero manager. labels May 16, 2024
@roryabraham roryabraham added Weekly KSv2 External Added to denote the issue can be worked on by a contributor and removed Daily KSv2 labels May 16, 2024
@melvin-bot melvin-bot bot changed the title [TS migration] Migrate str to Typescript (expensify-common) [$250] [TS migration] Migrate str to Typescript (expensify-common) May 16, 2024
Copy link

melvin-bot bot commented May 16, 2024

Job added to Upwork: https://www.upwork.com/jobs/~01eab386dd14c7df3a

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label May 16, 2024
Copy link

melvin-bot bot commented May 16, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane (External)

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels May 16, 2024
@roryabraham roryabraham added Weekly KSv2 and removed Help Wanted Apply this label when an issue is open to proposals by contributors labels May 16, 2024
@roryabraham roryabraham changed the title [$250] [TS migration] Migrate str to Typescript (expensify-common) [$125] [TS migration] Migrate str to Typescript (expensify-common) May 16, 2024
@roryabraham roryabraham removed the Daily KSv2 label May 16, 2024
Copy link

melvin-bot bot commented May 16, 2024

Upwork job price has been updated to $125

@blazejkustra
Copy link
Contributor Author

Blocked by #42245 for now.

@blazejkustra
Copy link
Contributor Author

I’m Błażej Kustra from Software Mansion, an expert agency, and I’d like to work on this issue 😄

@blazejkustra
Copy link
Contributor Author

Update: PR is ready for internal and cross review

@melvin-bot melvin-bot bot added the Overdue label Jun 4, 2024
@MitchExpensify
Copy link
Contributor

Not overdue

@sobitneupane
Copy link
Contributor

Any update @blazejkustra ?

@melvin-bot melvin-bot bot removed the Overdue label Jun 6, 2024
@roryabraham
Copy link
Contributor

This is done, looks like it was merged w/o any C+ review, so we can close this out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item. Typescript Migration Weekly KSv2
Projects
Development

No branches or pull requests

5 participants