[$125] [TS migration] Migrate ExpensiMark to Typescript (expensify-common)

[blazejkustra]

Typescript migration (expensify-common)

Make sure you read through our TypeScript's style guide before you start working on this migration issue.

Files

lib/ExpensiMark.js

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~014925282fa7b2a6db
• Upwork Job ID: 1791121920495669248
• Last Price Increase: 2024-05-16

Issue Owner

Current Issue Owner: @hoangzinh

[melvin-bot]

Triggered auto assignment to @MitchExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[blazejkustra]

I got approval from @roryabraham to create this issue on #typescript-new-expensify channel here. Let's add it to Typescript project and change labels as this is not a bug, thanks!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~014925282fa7b2a6db

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @hoangzinh (External)

[tienifr]

Happy to take this

[blazejkustra]

@tienifr It's not ready for assignment yet, this issue is blocked by #42245 and #42246

[melvin-bot]

This issue has not been updated in over 15 days. @hoangzinh, @MitchExpensify, @blazejkustra eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[blazejkustra]

Update: I'm going to work on this one tomorrow

[blazejkustra]

Update: PR is up, it's on hold for now as it's based from another PR. In case you want to review it, here is a link to my changes.

[hoangzinh]

Thanks for updates @blazejkustra

[hoangzinh]

@MitchExpensify should we add back "daily" or "weekly" for this issue?

[roryabraham]

This is on main now, went to staging 5 hours ago in #44021.

[hoangzinh]

The PR Expensify/expensify-common#721 has been merged. Should we close this issue?

[roryabraham]

Any payments due?

[srikarparsi]

I don't think so, I think this is good to close @roryabraham

Migration PR: SWM handled
expensify-common bump: I created and SWM reviewed
App bump: I created and C+ reviewed but payment is being taken care of here