-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[$125] [TS migration] Migrate ExpensiMark
to Typescript (expensify-common)
#42247
Comments
Triggered auto assignment to @MitchExpensify ( |
I got approval from @roryabraham to create this issue on |
Job added to Upwork: https://www.upwork.com/jobs/~014925282fa7b2a6db |
ExpensiMark
to Typescript (expensify-common)ExpensiMark
to Typescript (expensify-common)
Triggered auto assignment to Contributor-plus team member for initial proposal review - @hoangzinh ( |
ExpensiMark
to Typescript (expensify-common)ExpensiMark
to Typescript (expensify-common)
Happy to take this |
This issue has not been updated in over 15 days. @hoangzinh, @MitchExpensify, @blazejkustra eroding to Monthly issue. P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do! |
Update: I'm going to work on this one tomorrow |
Update: PR is up, it's on hold for now as it's based from another PR. In case you want to review it, here is a link to my changes. |
Thanks for updates @blazejkustra |
@MitchExpensify should we add back "daily" or "weekly" for this issue? |
This is on main now, went to staging 5 hours ago in #44021. |
The PR Expensify/expensify-common#721 has been merged. Should we close this issue? |
Any payments due? |
I don't think so, I think this is good to close @roryabraham Migration PR: SWM handled |
Typescript migration (expensify-common)
Make sure you read through our TypeScript's style guide before you start working on this migration issue.
Files
lib/ExpensiMark.js
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @hoangzinhThe text was updated successfully, but these errors were encountered: