-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2024-08-19] [HOLD for payment 2024-06-20] [HOLD for payment 2024-06-18] Thread - Blue "Thread" above the parent message in thread is disable #43190
Comments
Triggered auto assignment to @twisterdotcom ( |
Triggered auto assignment to @marcochavezf ( |
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
|
@marcochavezf FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors |
We think that this bug might be related to #vip-vsb |
Fixed by [CP Staging] Revert "Fix get all ancestors in a thread" Screen.Recording.2024-06-06.at.11.06.34.AM.mov |
ProposalPlease re-state the problem that we are trying to solve in this issue.Thread - Blue "Thread" above the parent message in thread is disabled. What is the root cause of that problem?The root cause stems from #34640 where ReportUtils.getAllAncestorReportActions was originally written. We now know this because fixing that root cause in #42554 causes this issue. See #41519 (comment) for details. What changes do you think we should make in order to solve the problem?Address the root cause by using the correct ancestor, instead of leaving the root cause in place and reverting #42554. Do this by making the following changes: in all three lines of code below change
Without these proposed changes there will be two conflicting definitions of an ancestor object, one as used in ThreadDivider and another as used in ReportActionItem. It will clarify code and help to prevent future issues by having only one definition of an ancestor object, the definition used in ReportActionItem. |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.81-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2024-06-18. 🎊 |
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.82-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2024-06-20. 🎊 |
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
Okay, looks like #43518 is still open. @rushatgabhane's C+ review will be handled in #41519. Nothing else to do here. |
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.18-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-08-19. 🎊 |
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.4.80-1
Reproducible in staging?: y
Reproducible in production?: no
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4601125&group_by=cases:section_id&group_order=asc&group_id=291937
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:
Action Performed:
Expected Result:
The blue "Thread" above the parent message should be clickable (production behavior).
Actual Result:
The blue "Thread" above the parent message is disable.
Workaround:
unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Bug6504084_1717688964698.20240606_234728.mp4
View all open jobs on GitHub
Issue Owner
Current Issue Owner: @twisterdotcomThe text was updated successfully, but these errors were encountered: