Deploy Checklist: New Expensify 2024-06-06

[github-actions]

Release Version: 1.4.80-17
Compare Changes: production...staging

This release contains changes from the following pull requests:

• Preserve transactions amount in create IOU #40062
• fix: IOU Scan - In dark mode, the damaged PDF - file is barely visible. #40607
• fix: Workspace switcher search bar is in the wrong place. #41158
• RBR transaction thread is disappearing from the LHN when navigating to another chat #41507
• [VIP-Travel] Trip room summary #41659
• DOCS: Create Set-up-your-wallet.md #41944
• Feature: Add the ability to configure tax rates on distance rates #42141
• Hide contact option if we don't include P2P option #42142
• [Details Revamp] Remove Delete Action from Collect Workspace Settings Pages #42146
• Fix go back from details page remove the linked report action  #42239
• Disabled distance rate is present in the rate list in confirmation p #42330
• feat: hold expense in one transaction view #42374
• cleanup: remove DetailsPage.tsx  #42385
• [TS migration] Update expensify-common usage in NewDot #42387
• fix: Error message only changes after clicking Split expense button for the second time #42450
• Show composer on public rooms after signing in #42497
• Make sure that the connection sync progress times out after 20 minutes using timestamp #42498
• Fix get all ancestors in a thread #42554
• fix: hold Expense option is displayed on expenses on a closed report #42574
• [MEDIUM][VIP-Travel] Use static .svg for Travel terms & conditions page, not a .lottie file #42625
• fix first action item background overlap on the next item #42629
• fix Deeplinking to a whisper results in hmm it is not here page #42672
• [fix]: Incorrect padding in group invite flow in RHP #42728
• Revert "Revert "Handle tax for split requests"" and fix reported bugs #42737
• Fix back button arrow won't back when viewing attachment image and additional fixes on modals #42738
• Add payment card #42771
• Create DistanceRates.ts Utils file #42786
• Display send money action as paid system message in combine report #42894
• DOCS: Create Book-with-Expensify-Travel.md #42927
• DOCS: Create Edit-or-cancel-travel-arrangements.md #42930
• DOCS: Create Edit-or-cancel-travel-arrangements.md #42931
• Fix report total and alignment #42932
• Create Configure-travel-policy-and-preferences.md #42940
• Create Configure-travel-policy-and-preferences.md #42941
• DOCS: Create Approve-travel-expenses.md #42943
• DOCS: Create Approve-travel-expenses.md #42944
• [Fix]: Inconsistency in merchant requirement during and after invoice creation #42945
• [Payment card / Subscription] Implement “Subscription details” section (UI) #42975
• [Search v1] Add small followups for sorting in search #42980
• Fix scan in progress shown for manual request with receipt moved from tracked expense #42984
• Add bold style for switch labels in workflow and more features pages #43006
• Replace policy.submitsTo with PolicyUtils.getSubmitToAccountID #2 #43019
• Group chat cleanup #43027
• [HelpDot] add undefined checks #43030
• Delete docs/articles/expensify-classic/workspaces/reports/Report-Fiel… #43045
• Fix incorrect tax rate selected with distance rate #43052
• Fix LHN shows Not found when navigated from global create menu or report parent navigation link #43086
• fix User is able to add new tax rate using deep link #43087
• [Search v1] Improve performance of ReportListItem #43092
• fix currency breaking issue with currency conversion #43133
• Delete outdated API Keys #43141
• [CP Staging]Prevents custom unit from changing tax rate toggle #43182
• [CP Staging] Revert "Display send money action as paid system message in combine report" #43189
• [CP Staging] Revert "Fix get all ancestors in a thread" #43201
• Fix crash in MoneyRequestConfirmationList #43217
• [CP Staging] Revert "fix: Error message only changes after clicking Split expense button for the second time" #43223
• [CP Staging] Fix crash when submitting expense on a newly created workspace #43226
• Revert "feat: hold expense in one transaction view" #43237
• [CP Staging] Fix distance tax regression #43246
• [CP Staging] Bump react-native-live-markdown to 0.1.82 #43255
• [CP Staging] Fix navigation when changing amount of scan split #43280
• Revert "RBR transaction thread is disappearing from the LHN when navigating to another chat" #43304
• [CP Staging] Fix crash when opening distance rate after deleting a tax rate associated to it #43320
• [CP Staging] Bump live-markdown to 0.1.83 #43340

Deploy Blockers:

• [HOLD for payment 2024-06-20] Group chat - Member amount is 0 when creating group chat offline #43042
• [HOLD for payment 2024-06-20] [HOLD for payment 2024-06-18] Expense - App crashes when submitting expense on a newly created workspace #43171
• [HOLD for payment 2024-06-20] [HOLD for payment 2024-06-18] Thread - App shows not here page when clicking on blue "Thread" in thread view #43172
• [HOLD for payment 2024-06-20] [HOLD for payment 2024-06-18] Track tax - Track tax rate is disabled when changing unit #43173
• Distance tax - Tax rate and tax reclaimable on rows are not grayed out when edited offline #43174
• [HOLD for payment 2024-06-20] [HOLD for payment 2024-06-18] [$250] Chat - "Deleted Message" Notification Appears with Its Reply in IOU #43175
• mWeb - Chat - 3 backtick code block is not applied correctly #43176
• [Track Tax] Vague system messages are displayed when changing Track tax, and Tax rate #43179
• [HOLD for payment 2024-06-21] [$250] mWeb - Chat - Quote markdown is not applied #43180
• [HOLD for payment 2024-06-28] [Payment card / Subscription] [$250] Subscription - Keyboard opens when neither of the fields are in focus after selecting currency #43181
• [HOLD for payment 2024-06-20] [HOLD for payment 2024-06-18] Pay someone - Replies sent to paid system message appear again in transaction thread #43183
• [HOLD for payment 2024-06-28] [$250] Send invoice - Error above Submit button is delayed by a moment when sending invoice without merchant #43184
• [HOLD for payment 2024-06-20] [HOLD for payment 2024-06-18] iOS - Pay someone - Paid system message is not highlighted when tapping on the message link #43187
• mWeb - Workspace - Error shown while inviting workspace member #43188
• [HOLD for payment 2024-06-20] [HOLD for payment 2024-06-18] Thread - Blue "Thread" above the parent message in thread is disable #43190
• Subscription-Expensify is barely visible in Expensify approved section in device setting mode #43195
• [HOLD for payment 2024-06-20] [HOLD for payment 2024-06-18] Track Expense-App crashes when clicking on "share it with my accountant" #43197
• [HOLD for payment 2024-06-20] [HOLD for payment 2024-06-18] [REGRESSION] Android & iOS - Track tax - "Track tax" message does not scale according to device font size #43202
• [HOLD for payment 2024-06-20] [HOLD for payment 2024-06-18] Hold expense - Inconsistency in showing Submit button in main chat vs report for held expense #43203
• [$250] [HOLD for payment 2024-06-20] Hold expense - Unable to hold expense with failed scanning when there is only one expense #43207
• Group chat - Not here page is hidden behind chat member profile page when URL modified #43212
• Expense - Inconsistency in showing last digits as 0 when spliting, submitting and paying #43214
• [$250] Expense- Zeros are added to currency that does not support decimal and unable to delete amount #43215
• [HOLD for payment 2024-06-28] [HOLD for payment 2024-06-21] Split - App allows splitting when the sum of splits is not equal to total amount #43216
• [$250] Chat - Edit box is not focused #43222
• [HOLD for payment 2024-07-22] [HOLD for payment 2024-07-17] Expense - Header subtitle from report with RBR in LHN leads to the same transaction view  #43238
• [HOLD for payment 2024-06-20] [$250] Track tax - App crashes after assigning deleted tax rate to distance rate offline #43241
• [HOLD for payment 2024-06-20] [HOLD for payment 2024-06-18] Position 'Track tax' is shifted to the left relative to other data on the settings page #43242
• [$250] Expense - Leading zeros are not removed when returning to amount input page #43243
• Expense - Duplicate transaction threads with RBR in LHN when sending expense to each other #43252
• [HOLD for payment 2024-06-20] [HOLD for payment 2024-06-18] Split - App closes split details RHP when saving existing amount without editing it #43259
• Android - Receipt - After uploading image user directed to search page #43274
• [$250] Workspace switcher - Expensify and workspace are highlighted when navigating by keyboard #43296
• [HOLD for payment 2024-06-20] [HOLD for payment 2024-06-18] [$250] Mark down - Mention suggestion list does not show up when typing @ #43310
• [HOLD for payment 2024-06-20] [HOLD for payment 2024-06-18] [$500] Chat - Emoji gets inserted in front of entered text #43312
• [HOLD for payment 2024-06-20] [HOLD for payment 2024-06-18] Track tax - App crashes when opening distance rate after deleting a tax rate associated to it #43313
• Track tax - Track tax switch does not appear grayed out when enabled/disabled offline #43318
• [Awaiting checklist] [$250] Edit comment - Remaining text in the composer is highlighted after deleting text #43332
• [$250] Chat - Sometimes self DM and Track expense aren't available for new expensifail accounts #43335

Deployer verifications:

• I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
• I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
• I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

[OSBotify]

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.4.80-1 🚀

[rlinoz]

Checking off #43173, CP'd the fix to staging and it worked.

[francoisl]

Revert fix for #43172 tested on staging, checking it off.

Edit: it also fixes #43175 and #43190, clearing those too.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[roryabraham]

#43181 is NAB, demoting.

[roryabraham]

Demoting #43203 per https://expensify.slack.com/archives/C07J32337/p1717701104793859?thread_ts=1717696954.597609&cid=C07J32337

[amyevans]

Closed #43212 as expected behavior

[luacmartins]

Checking off #43214. Not a real bug

[kavimuru]

Regression is 69% of progress
unchecked PRs:
#43030 production PR (help.expensify.com) checked off
#43052 - iOS validation is pending
#43027 failing with #43212
#42737 Desktop validation is pending
#42574 Web, mWeb, android and iOS validation are pending
#42554 iOS validation pending
#42498 validation pending in all the platforms
#42497 Desktop validation pending
#42387 Android validation pending
#42330 iOS validation pending

[marcaaron]

Checking off #43215 as NAB

[MonilBhavsar]

Checked off #43242, NAB

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[blimpich]

Checking off #43207 because we reverted the PR that caused it.

[kavimuru]

Regression is 10% left in the TR
Unchecked PRs:
#43027 failing with #43212
#42498 blocked in android with the issue #40978 reproduced in PROD checking it off.
#42554 failing with #43213

[luacmartins]

Checking off #43222. Demoted to NAB.

[luacmartins]

Checking off #43238. Demoted to NAB

[rlinoz]

Checking off #43259, tested and it is fixed by a CP.

[luacmartins]

Checking off #43243. It was demoted

[blimpich]

Demoting #43296, NAB

[luacmartins]

Checking off #43274. Expected behavior.

[luacmartins]

Demoted #43318

[luacmartins]

Checking off #43313. Fixed on staging

[mountiny]

demoted #43335

[mountiny]

Checked #42554 off as the raised issue was closed
Checked #43027 off for the same reason as above.

[mountiny]

All cleared, retested the last CPed PR.

[mountiny]