Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subscription-Expensify is barely visible in Expensify approved section in device setting mode #43195

Closed
1 of 6 tasks
m-natarajan opened this issue Jun 6, 2024 · 13 comments
Closed
1 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Design Engineering

Comments

@m-natarajan
Copy link

m-natarajan commented Jun 6, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


issue found when validating #42975
Version Number: 1.4.80-1
Reproducible in staging?: y
Reproducible in production?: no new feature
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

Action Performed:

  1. Log into the app using an account that has a Collect/Control workspace
  2. Go to Preferences> Theme> Use device settings
  3. Navigate to the Subscription Settings page (staging.new.expensify.com/settings/subscription)
  4. Take a look at Subscription details card section

Expected Result:

Expensify should be clearly visible

Actual Result:

Expensify is barely visible because it has the same color as the background

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6504104_1717690155836!Capture

Bug6504104_1717690155844.Recording__3129.mp4

View all open jobs on GitHub

@m-natarajan m-natarajan added DeployBlockerCash This issue or pull request should block deployment Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. DeployBlocker Indicates it should block deploying the API labels Jun 6, 2024
Copy link

melvin-bot bot commented Jun 6, 2024

Triggered auto assignment to @roryabraham (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Jun 6, 2024

Triggered auto assignment to @garrettmknight (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link
Contributor

github-actions bot commented Jun 6, 2024

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@m-natarajan
Copy link
Author

@garrettmknight FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

@roryabraham roryabraham removed the DeployBlocker Indicates it should block deploying the API label Jun 6, 2024
@roryabraham
Copy link
Contributor

Looks definitely front-end only.

Copy link

melvin-bot bot commented Jun 6, 2024

Triggered auto assignment to @dannymcclain (Design), see these Stack Overflow questions for more details.

@garrettmknight garrettmknight added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Jun 6, 2024
@garrettmknight
Copy link
Contributor

@dannymcclain any thoughts on a more appropriate color scheme for Expensify Approved! and light mode here?

@dannymcclain
Copy link
Contributor

Pretty positive this has already been fixed in an open PR. Let me try to track it down.

@roryabraham
Copy link
Contributor

roryabraham commented Jun 6, 2024

Am I mistaken or is this currently only accessible by navigating directly to the URL?

@dannymcclain
Copy link
Contributor

Ok you can see here where this was caught: #42975 (comment)

And then a commit was pushed to update it.

And then @amyevans approved and merged the changes. So I think it's just still waiting to be deployed to staging.

@garrettmknight
Copy link
Contributor

Sweet - thanks for the quick work @dannymcclain - I think we can close this then.

@dannymcclain
Copy link
Contributor

Am I mistaken or is this currently only accessible by navigating directly to the URL?

Also yes, I don't believe there's any way to actually get to this subscription page in production. This is all still very much in the implementation phase.

@roryabraham
Copy link
Contributor

cool cool.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Design Engineering
Projects
Status: Done
Development

No branches or pull requests

4 participants