[HOLD for payment 2024-06-28] [HOLD for payment 2024-06-21] Split - App allows splitting when the sum of splits is not equal to total amount

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.80-6
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4601034
Issue reported by: Applause - Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Go to group chat
3. Go to + > Split expense
4. Enter amount > Next
5. Enter 0 as split amount for each participants
6. Click Split button

Expected Result:

The split will not be created because "The sum of splits must equal the total amount."

Actual Result:

The split is created despite the error "The sum of splits must equal the total amount."
Error shows up after the split is created

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6504309_1717701794847.20240607_031950.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @sonialiap

[melvin-bot]

Triggered auto assignment to @thienlnam (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[lanitochka17]

@thienlnam FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[lanitochka17]

We think that this bug might be related to #vip-split

[neil-marcellini]

This issue is about frontend error handling, so it's not a backend blocker.

[ishpaul777]

found the potential offending PR #42450,

Edit: Confirmed with revert #43223

cc @nkdengineer @rushatgabhane

[mountiny]

To unblock deploy as fast as possible, I will go with the revert

[mountiny]

CPing the revert

[thienlnam]

Thanks for handling Vit - we should be good here now

[ishpaul777]

hello @mountiny! Just want a quick clarification, will i be eligible for the bounty for PR for this issue?

[mountiny]

Oh yeah, we can offer $75 for helping find this and confirming that the PR is the root cause. Does that work for you? There was not much work involved in this and we still need to get the original PR deployed

[ishpaul777]

Works for me, Thanks!

[melvin-bot]

Triggered auto assignment to @laurenreidexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[mountiny]

$75 to @ishpaul777

[sonialiap]

Payment summary:

• @ishpaul777 $75 - offer sent

upwork link

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.85-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: App allows splitting when the sum of splits is not equal to total #43342

If no regressions arise, payment will be issued on 2024-06-28. 🎊

For reference, here are some details about the assignees on this issue:

• @ishpaul777 requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@ishpaul777] The PR that introduced the bug has been identified. Link to the PR:
• [@ishpaul777] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@ishpaul777] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@ishpaul777] Determine if we should create a regression test for this bug.
• [@ishpaul777] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@sonialiap] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[ishpaul777]

@sonialiap I have accepted offer, Thanks!

[ishpaul777]

• [@ishpaul777] The PR that introduced the bug has been identified. Link to the PR: fix: Error message only changes after clicking Split expense button for the second time #42450
• [@ishpaul777] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: fix: Error message only changes after clicking Split expense button for the second time #42450 (comment)
• [@ishpaul777] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: - Not required
• [@ishpaul777] Determine if we should create a regression test for this bug. -This was caught during staging QA, there must already be a TR for this flow.
• [@ishpaul777] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

[sonialiap]

Paid ✔️