-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[$250] Chat - Edit box is not focused #43222
Comments
Triggered auto assignment to @chiragsalian ( |
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
|
@chiragsalian FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors |
We think that this bug might be related to #vip-vsp |
Job added to Upwork: https://www.upwork.com/jobs/~01033dcbb85796aa97 |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @eh2077 ( |
I noticed this issue at #42645 (comment) and will be fixed there too. |
If you noticed this issue last week @bernhardoj is it reproducible on production and thus not a deploy blocker? |
I can't repro it on prod, unfortunately. |
Hm, then I'm not sure if that's the root cause then. @eh2077 have you looked into this? |
I think this issue was caused by commit 29992cf894d0ebcdcb2e20311435638ee1dedf58 from #42738. I'll demote this since it's a small issue and let the contributor fix it. @tsa321 can you please comment here so I can assign it to you? |
@luacmartins Yes, I will make a revert PR |
@luacmartins The revert PR is here : #43298 |
I can fix this if no one has picked it before now... |
📣 @Taiwrash! 📣
|
✅ Contributor details stored successfully. Thank you for contributing to Expensify! |
What next to continue with this? |
@Taiwrash yes, and we want to fix the original issue too. |
if i get this right, it means i can go for original issue instead? |
@Taiwrash the PR of original issue that I am assigned to causing this regression. The PR is merged recently so it is currently regression period. Since my PR causing this issue, so I must fix this issue. Anyways, in latest main after bumping @Taiwrash I suggest you to search for other open |
The latest code from new pull seems to be fixing this issue. |
Not overdue. This is a regression from #42368 and @tsa321 is actively re-working the fix here #43343 I think @DylanDylann as the original C+ should take care of this, so I'm going to unassign myself. cc @luacmartins |
We reverted the offending PR. I think we can close this one. |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.4.80-6
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): berhanesarah.testing+dfewui@gmail.com
Issue reported by: Applause - Internal Team
Action Performed:
Expected Result:
The edit box is automatically focused
Actual Result:
The compose box is focused instead of the edit box
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
Bug6504353_1717706123822.2024-06-06_23_33_04.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @eh2077The text was updated successfully, but these errors were encountered: