Report field-List value added & saved in offline is not greyed out

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.20
Reproducible in staging?: Y
Reproducible in production?: N
Issue reported by: Applause Internal Team

Action Performed:

1. Go to https://staging.new.expensify.com/home

2. Tap profile -> workspaces -> workspace

3. Tap more features -> Enable report field

4. Tap on the report field

5. Go offline

6. Enter name & save

7. Select "List" type & save

8. Tap save

9. Note field added is greyed

10. Open the newly created field

11. Tap list value

12. Add a value & save

Expected Result:

List value added & saved in offline must be greyed out.

Actual Result:

List value added & saved in offline is not greyed out.

Workaround:

Unknown

Platforms:

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6571677_1723611500780.lid.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @NikkiWines (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @VictoriaExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[IuliiaHerets]

We think that this bug might be related to #vip-vsb

[dominictb]

Proposal

Please re-state the problem that we are trying to solve in this issue.

List value added & saved in offline is not greyed out.

What is the root cause of that problem?

When we add the report field list value, we only update the list value and the disable option list.

App/src/libs/actions/Policy/ReportField.ts

Lines 435 to 436 in b7f7f1b

	fieldList: {
	[reportFieldKey]: updatedReportField,

What changes do you think we should make in order to solve the problem?

1. We can add a pendingActions array for the report field list value that is the same pattern with disabledOptions array. When we add or update or delete the report field list value we will update the pendingActions accordingly.

2. Get the pendingActions of the list value here. If we're creating the report field the pendingActions will be an empty array

3. Finally, add pendingAction for the value item here

pendingAction: pendingActions?.[index];

What alternative solutions did you explore? (Optional)

[Nodebrute]

@NikkiWines @VictoriaExpensify Issue is not reproducible on the latest main.

Screen.Recording.2024-08-14.at.11.50.36.AM.mov

[NikkiWines]

@IuliiaHerets, to just confirm something - was this issue was the result of testing from a particular PR? or was found during our standard regression test?

[NikkiWines]

Also based on this PR it seems the behavior is expected and that the values should not be greyed out.

Offline tests

1. Create, edit, or delete list values of a report field of a workspace.
2. Verify that changes are applied immediately.
3. Verify that the list values are not grayed out.

cc: @rezkiy37 @shubham1206agra @mountiny to confirm this is the behavior we want🙏

[shubham1206agra]

Yes, this is the new behaviour now. Please update the tests and close this issue.

[mountiny]

@NikkiWines Correct this is now expected. @IuliiaHerets @kavimuru @lanitochka17 Can you please make sure the regression tests are updated to cover this change?

[NikkiWines]

Closing as this is a non-issue