[HOLD for payment 2021-11-04] VBA - User can proceed to next steps when entering 0's to the fields without any error message

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Bug found when executing #5531

Action Performed:

1. Launch the app
2. Log in with expensifail account
3. Enable the Staging Server
4. Click on deeplink
5. Select Chase
6. Put Log in and Password
7. Select Saving
8. Start put all Information for VBA flow
9. Enter invalid values for zip Code, TaxID Number and phone Number
10. In Personal Information put invalid values for SSN

Expected Result:

Error message is displayed for the fields with invalid values

Actual Result:

Able to procced with flow without any error message using 0's as value for fields

Workaround:

Unknown

Platform:

Where is this issue occurring?

• Web
• iOS
• Android
• Desktop App
• Mobile Web

Version Number: 1.1.6-0

Reproducible in staging?: Yes
Reproducible in production?: Credentials doesn't work for production

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos:

Bug5268769_Screen_Recording_20211006-164441_New_Expensify.mp4

Bug5268769_Screen_Recording_20211006-164109_New_Expensify.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause.
Slack conversation:

View all open jobs on GitHub

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[MelvinBot]

Triggered auto assignment to @cead22 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[akshayasalvi]

Proposal

I am guessing the valid range for SSN is 0001 to 9999. In the ValidationUtils, we have a function to check valid SSN.

function isValidSSNLastFour(ssnLast4) {
    return CONST.REGEX.SSN_LAST_FOUR.test(ssnLast4) && ssnLast4 !== '0000';
}

What are the invalid values for Tax IDs? and for Zipcode also is it 00001 as the smallest value? Will accordingly handle for TaxId and Zipcode.

[MelvinBot]

Triggered auto assignment to @Christinadobrzyn (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[Christinadobrzyn]

I'm ooo so unassigning myself/adding a new teammate!

[MelvinBot]

Triggered auto assignment to @puneetlath (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[mvtglobally]

Issue reproducible during KI retests.

[puneetlath]

Job post is here: https://www.upwork.com/jobs/~01bab34e1f30eef399

@akshayasalvi is there a simple way to udpate the SSN_LAST_FOUR regex to account for this? If not, your solution seems good.

[akshayasalvi]

@puneetlath Afaik certain look ahead operations and logics are not possible with javascript regex. If awarded, I'll try to otherwise implement the one I suggested. Does that work?

Can you also help me with the valid/invalid values for Tax Id Number? I'll get that fixed too in this one.

[parasharrajat]

Proposal

1. As per the rule, the last four digits of SSN can not be 0000. We have to update the regex for matching the SSN's last digits SSN_LAST_FOUR. It will skip 0000 .

^(?!0000)[0-9]{4}$

2. Other parts are all set, We are already validating the SSN

   App/src/pages/ReimbursementAccount/RequestorStep.js

   Line 117 in c9926d9

   const errors = validateIdentity({

   .

It is supported in all browsers and other platforms.

[parasharrajat]

@puneetlath Gentle Bump. I think this is part of N6. Thanks.

[puneetlath]

Let's go with @parasharrajat's solution. I prefer the method of just updating the regex.

[mvtglobally]

Issue reproducible during KI retests.

[puneetlath]

Not overdue. Waiting for production deploy.

[mvtglobally]

Issue reproducible during KI retests.

[mvtglobally]

Issue reproducible during KI retests

[puneetlath]

Paid!