Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VBA Let's finish in Chat modal - Update spanish translation #5990

Closed
isagoico opened this issue Oct 21, 2021 · 0 comments
Closed

VBA Let's finish in Chat modal - Update spanish translation #5990

isagoico opened this issue Oct 21, 2021 · 0 comments
Assignees
Labels
Engineering Improvement Item broken or needs improvement. Reviewing Has a PR in review Weekly KSv2

Comments

@isagoico
Copy link

isagoico commented Oct 21, 2021

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Navigate to add bank account flow (app must be in spanish)
  2. Add a Verifying bank account (must go through onfido flow)
  3. Reach the "Let's finish in chat" Modal (In spanish "Acabemos en el chat")

Expected Result:

There should be a friendly message like "Terminemos en el chat", "Finalicemos en el chat" or "continuemos en el chat".
Also the text below should say "Gracias! ...."

Actual Result:

While translations are correct the modal says "Acabemos en el chat" and "Gracias por hacer eso" which in spanish sounds really weird.

Workaround:

Be tolerant with weird direct translations from english (?)

Platform:

Where is this issue occurring?

  • Web
  • iOS
  • Android
  • Desktop App
  • Mobile Web

Version Number: 1.1.8-8

Reproducible in staging?: Yes
Reproducible in production?: Yes

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

image

Expensify/Expensify Issue URL:

Issue reported by: @cead22
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1634752663006100

View all open jobs on GitHub

@pecanoro pecanoro added Improvement Item broken or needs improvement. Weekly KSv2 Reviewing Has a PR in review and removed Daily KSv2 labels Oct 22, 2021
@botify botify closed this as completed Oct 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Engineering Improvement Item broken or needs improvement. Reviewing Has a PR in review Weekly KSv2
Projects
None yet
Development

No branches or pull requests

3 participants